Code review remarks applied.

Author: HHobeck

BREAKING_CHANGES.md

@@ -32,6 +32,7 @@
 *   The `BranchPrefixToTrim` configuration property has been removed. `RegularExpression` is now used to capture named groups instead.
     *   Default `RegularExpression` for feature branches is changed from `^features?[/-]` to `^features?[/-](?<BranchName>.+)` to support using `{BranchName}` out-of-the-box
     *   Default `RegularExpression` for unknown branches is changed from `.*` to `(?<BranchName>.*)` to support using `{BranchName}` out-of-the-box
+*   The branch related property `IsMainline` in the configuration system has been renamed to `IsMainBranch`
 
 ## v5.0.0
 

schemas/6.0/GitVersion.configuration.json

@@ -69,7 +69,7 @@
     },
     "increment": {
       "$ref": "#/$defs/incrementStrategy"
-    },f
+    },
     "is-main-branch": {
       "$ref": "#/$defs/nullableOfBoolean"
     },

src/GitVersion.Core/Core/MainlineBranchFinder.cs

@@ -30,14 +30,14 @@ public IDictionary<string, List<IBranch>> FindMainlineBranches(ICommit commit)
     {
         var branchOriginFinder = new BranchOriginFinder(commit, this.repositoryStore, this.configuration, this.log);
         return this.repository.Branches
-            .Where(BranchIsMainBranch)
+            .Where(IsMainBranch)
             .Select(branchOriginFinder.BranchOrigin)
             .Where(bc => bc != BranchCommit.Empty)
             .GroupBy(bc => bc.Commit.Sha, bc => bc.Branch)
             .ToDictionary(group => group.Key, x => x.ToList());
     }
 
-    private bool BranchIsMainBranch(INamedReference branch)
+    private bool IsMainBranch(INamedReference branch)
     {
         var matcher = new MainlineConfigBranchMatcher(branch, this.log);
         return this.mainlineBranchConfigurations.Any(matcher.IsMainBranch);