Refactor property requirement check in CommandBaseGenerator

arturcic · arturcic · commit 3dde5204a406 · 2025-07-09T18:36:21.000+02:00
Replaced the nullable annotation check with the IsRequired property on propertySymbol for determining if a field is required. This improves code clarity and aligns with more explicit APIs.
diff --git a/new-cli/GitVersion.Cli.Generator/CommandBaseGenerator.cs b/new-cli/GitVersion.Cli.Generator/CommandBaseGenerator.cs
@@ -103,7 +103,7 @@ private static SettingsPropertyInfo MapToPropertyInfo(IPropertySymbol propertySy
             alias = string.Join(", ", aliases);
         }
 
-        var isRequired = propertySymbol.Type.NullableAnnotation == NullableAnnotation.NotAnnotated;
+        var isRequired = propertySymbol.IsRequired;
         return new()
         {
             Name = propertySymbol.Name,

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ private static SettingsPropertyInfo MapToPropertyInfo(IPropertySymbol propertySy`
`103`	`103`	`alias = string.Join(", ", aliases);`
`104`	`104`	`}`
`105`	`105`
`106`		`- var isRequired = propertySymbol.Type.NullableAnnotation == NullableAnnotation.NotAnnotated;`
	`106`	`+ var isRequired = propertySymbol.IsRequired;`
`107`	`107`	`return new()`
`108`	`108`	`{`
`109`	`109`	`Name = propertySymbol.Name,`