CA2208: Instantiate argument exceptions correctly

Evangelink · arturcic · commit 3e71df3a8389 · 2021-07-23T13:39:29.000+02:00
diff --git a/.editorconfig b/.editorconfig
@@ -166,3 +166,6 @@ dotnet_diagnostic.CA1825.severity = warning
 
 # CA1822: Mark members as static
 dotnet_diagnostic.CA1822.severity = warning
+
+# CA2208: Instantiate argument exceptions correctly
+dotnet_diagnostic.CA2208.severity = warning
diff --git a/src/GitVersion.Core/VersionCalculation/SemanticVersioning/SemanticVersion.cs b/src/GitVersion.Core/VersionCalculation/SemanticVersioning/SemanticVersion.cs
@@ -298,7 +298,7 @@ public SemanticVersion IncrementVersion(VersionField incrementStrategy)
                         incremented.Patch++;
                         break;
                     default:
-                        throw new ArgumentOutOfRangeException();
+                        throw new ArgumentOutOfRangeException(nameof(incrementStrategy));
                 }
             }
             else

Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,7 @@ public SemanticVersion IncrementVersion(VersionField incrementStrategy)`
`298`	`298`	`incremented.Patch++;`
`299`	`299`	`break;`
`300`	`300`	`default:`
`301`		`- throw new ArgumentOutOfRangeException();`
	`301`	`+ throw new ArgumentOutOfRangeException(nameof(incrementStrategy));`
`302`	`302`	`}`
`303`	`303`	`}`
`304`	`304`	`else`