Skip to content

Commit 42e0e82

Browse files
committed
Removed duplication in member formatting
1 parent 68fa126 commit 42e0e82

File tree

1 file changed

+7
-14
lines changed

1 file changed

+7
-14
lines changed

src/GitVersionTask/AssemblyInfoBuilder/AssemblyInfoBuilder.cs

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -61,29 +61,22 @@ sealed class GitVersionInformationAttribute : System.Attribute
6161

6262
static string GenerateStaticVariableMembers(IList<KeyValuePair<string, string>> vars)
6363
{
64-
var members = new StringBuilder();
65-
for (var i = 0; i < vars.Count; i++)
66-
{
67-
var variable = vars[i];
68-
members.AppendFormat(" public static string {0} = \"{1}\";", variable.Key, variable.Value);
69-
70-
if (i < vars.Count - 1)
71-
{
72-
members.AppendLine();
73-
}
74-
}
75-
76-
return members.ToString();
64+
return GenerateMembers(vars, " public static string {0} = \"{1}\";");
7765
}
7866

7967

8068
static string GenerateAttributeVariableMembers(IList<KeyValuePair<string, string>> vars)
69+
{
70+
return GenerateMembers(vars, " public string {0} {{ get {{ return \"{1}\"; }} }}");
71+
}
72+
73+
static string GenerateMembers(IList<KeyValuePair<string, string>> vars, string memberFormat)
8174
{
8275
var members = new StringBuilder();
8376
for (var i = 0; i < vars.Count; i++)
8477
{
8578
var variable = vars[i];
86-
members.AppendFormat(" public string {0} {{ get {{ return \"{1}\"; }} }}", variable.Key, variable.Value);
79+
members.AppendFormat(memberFormat, variable.Key, variable.Value);
8780

8881
if (i < vars.Count - 1)
8982
{

0 commit comments

Comments
 (0)