www

Author: arturcic

src/GitVersion.Core.Tests/Helpers/TestConsoleAdapter.cs

@@ -7,8 +7,6 @@ public class TestConsoleAdapter(StringBuilder sb) : IConsole
 {
     public void WriteLine(string? msg) => sb.AppendLine(msg);
 
-    public void WriteLine() => sb.AppendLine();
-
     public void Write(string? msg) => sb.Append(msg);
 
     public override string ToString() => sb.ToString();

src/GitVersion.Core/Core/RegexPatterns.cs

@@ -4,6 +4,7 @@
 
 namespace GitVersion.Core;
 
+[SuppressMessage("Performance", "SYSLIB1045:Convert to \'GeneratedRegexAttribute\'.")]
 internal static class RegexPatterns
 {
     private const RegexOptions Options = RegexOptions.IgnoreCase | RegexOptions.Compiled;

src/GitVersion.Core/Logging/Abstractions/IConsole.cs

@@ -3,7 +3,6 @@ namespace GitVersion.Logging;
 public interface IConsole
 {
     void WriteLine(string? msg);
-    void WriteLine();
     void Write(string? msg);
     string? ReadLine();
     IDisposable UseColor(ConsoleColor consoleColor);

src/GitVersion.Core/Logging/ConsoleAdapter.cs

@@ -6,8 +6,6 @@ internal class ConsoleAdapter : IConsole
 {
     public void WriteLine(string? msg) => Console.WriteLine(msg);
 
-    public void WriteLine() => Console.WriteLine();
-
     public void Write(string? msg) => Console.Write(msg);
 
     public string? ReadLine() => Console.ReadLine();

src/GitVersion.Core/PublicAPI.Shipped.txt

@@ -377,7 +377,6 @@ GitVersion.Logging.IConsole
 GitVersion.Logging.IConsole.ReadLine() -> string?
 GitVersion.Logging.IConsole.UseColor(System.ConsoleColor consoleColor) -> System.IDisposable!
 GitVersion.Logging.IConsole.Write(string? msg) -> void
-GitVersion.Logging.IConsole.WriteLine() -> void
 GitVersion.Logging.IConsole.WriteLine(string? msg) -> void
 GitVersion.Logging.ILog
 GitVersion.Logging.ILog.AddLogAppender(GitVersion.Logging.ILogAppender! logAppender) -> void

src/GitVersion.MsBuild.Tests/GitVersion.MsBuild.Tests.csproj

@@ -27,10 +27,8 @@
     </ItemGroup>
     <ItemGroup>
         <Compile Include="..\GitVersion.Core.Tests\Helpers\GitVersionCoreTestModule.cs" Link="Helpers\GitVersionCoreTestModule.cs" />
-        <Compile Include="..\GitVersion.Core.Tests\Helpers\ExecutableHelper.cs" Link="Helpers\ExecutableHelper.cs" />
         <Compile Include="..\GitVersion.Core.Tests\Helpers\TestBase.cs" Link="Helpers\TestBase.cs" />
         <Compile Include="..\GitVersion.Core.Tests\Helpers\TestEnvironment.cs" Link="Helpers\TestEnvironment.cs" />
-        <Compile Include="..\GitVersion.Core.Tests\Helpers\TestLogAppender.cs" Link="Helpers\TestLogAppender.cs" />
         <Compile Include="..\GitVersion.Core.Tests\Extensions\GitRepositoryTestingExtensions.cs" Link="Extensions\GitRepositoryTestingExtensions.cs" />
         <Compile Include="..\GitVersion.Core.Tests\Extensions\GitVersionVariablesExtensions.cs" Link="Extensions\GitVersionVariablesExtensions.cs" />
         <Compile Include="..\GitVersion.Core.Tests\Extensions\MockCollectionExtensions.cs" Link="Extensions\MockCollectionExtensions.cs" />

src/GitVersion.MsBuild.Tests/Helpers/MsBuildExeFixtureResult.cs

@@ -4,8 +4,8 @@ namespace GitVersion.MsBuild.Tests.Helpers;
 
 public sealed class MsBuildExeFixtureResult(IDisposable fixture) : IDisposable
 {
-    public IAnalyzerResults MsBuild { get; set; }
-    public string Output { get; set; }
-    public string ProjectPath { get; set; }
+    public IAnalyzerResults MsBuild { get; init; }
+    public string Output { get; init; }
+    public string ProjectPath { get; init; }
     public void Dispose() => fixture.Dispose();
 }

src/GitVersion.MsBuild.Tests/Helpers/MsBuildTaskFixtureResult.cs

@@ -5,14 +5,14 @@ namespace GitVersion.MsBuild.Tests.Helpers;
 public sealed class MsBuildTaskFixtureResult<T>(IDisposable fixture) : IDisposable
     where T : ITask
 {
-    public bool Success { get; set; }
+    public bool Success { get; init; }
 
-    public T Task { get; set; }
+    public T Task { get; init; }
 
-    public int Errors { get; set; }
+    public int Errors { get; init; }
     public int Warnings { get; set; }
     public int Messages { get; set; }
-    public string Log { get; set; }
+    public string Log { get; init; }
 
     public void Dispose() => fixture.Dispose();
 }

src/GitVersion.MsBuild/Helpers/MsBuildAdapter.cs

@@ -12,8 +12,6 @@ public void WriteLine(string? msg)
         WriteLine();
     }
 
-    public void WriteLine() => taskLog.LogMessage("\n");
-
     public void Write(string? msg) => taskLog.LogMessage(msg);
 
     public string? ReadLine() => Console.ReadLine();
@@ -25,4 +23,6 @@ public IDisposable UseColor(ConsoleColor consoleColor)
 
         return Disposable.Create(() => Console.ForegroundColor = old);
     }
+
+    private void WriteLine() => taskLog.LogMessage("\n");
 }

src/GitVersion.Output/AssemblyInfo/ProjectFileUpdater.cs

@@ -7,10 +7,7 @@
 
 namespace GitVersion.Output.AssemblyInfo;
 
-internal interface IProjectFileUpdater : IVersionConverter<AssemblyInfoContext>
-{
-    bool CanUpdateProjectFile(XElement xmlRoot);
-}
+internal interface IProjectFileUpdater : IVersionConverter<AssemblyInfoContext>;
 
 internal sealed class ProjectFileUpdater(ILog log, IFileSystem fileSystem) : IProjectFileUpdater
 {