qodana

Author: arturcic

qodana.yaml

@@ -7,79 +7,81 @@ version: "1.0"
 ide: QDNET
 #Specify inspection profile for code analysis
 profile:
-  name: qodana.starter
+    name: qodana.starter
 include:
-  - name: ConvertIfStatementToReturnStatement
-  - name: ConvertIfStatementToConditionalTernaryExpression
-  - name: AutoPropertyCanBeMadeGetOnly.Global
-  - name: CanReplaceCastWithLambdaReturnType
-  - name: ChangeFieldTypeToSystemThreadingLock
-  - name: ConvertIfStatementToSwitchStatement
-  - name: ConvertToConstant.Local
-  - name: DuplicatedSequentialIfBodies
-  - name: InlineTemporaryVariable
-  - name: InvertIf
-  - name: UseVerbatimString
-  - name: MemberCanBePrivate.Global
-  - name: MemberCanBeProtected.Global
-  - name: MergeIntoPattern
-  - name: UnusedMethodReturnValue.Global
-  - name: EditorConfigNoMatchingFiles
-  - name: PreferConcreteValueOverDefault
-  - name: PropertyCanBeMadeInitOnly.Global
-  - name: MoveLocalFunctionAfterJumpStatement
-  - name: RedundantExplicitParamsArrayCreation
-  - name: RedundantOverload.Global
-  - name: RedundantStringInterpolation
-  - name: RedundantVerbatimStringPrefix
-  - name: ReplaceSubstringWithRangeIndexer
-  - name: RCS1001
-  - name: RCS1003
-  - name: RCS1123
-  - name: SYSLIB1045
-  - name: CA1826
-  - name: RCS1256
-  - name: RCS1118
-  - name: RCS1077
-  - name: RCS1205
-  - name: RCS1214
-  - name: RCS1249
-  - name: RCS1192
-  - name: SYSLIB1054
-  - name: CA1512
-  - name: CA1866
-  - name: CA1859
-  - name: RCS1246
-  - name: CA1829
-  - name: RCS1266
-  - name: RCS1267
-  - name: RCS1227
-  - name: SwitchExpressionHandlesSomeKnownEnumValuesWithExceptionInDefault
-  - name: SwitchStatementHandlesSomeKnownEnumValuesWithDefault
-  - name: RedundantAlwaysMatchSubpattern
-  - name: UnusedType.Global
-  - name: UnusedMemberInSuper.Global
-  - name: UnusedMember.Local
-  - name: EditorConfigKeyCorrectness
-  - name: UseCollectionCountProperty
-  - name: UseDiscardAssignment
-  - name: ArrangeNamespaceBody
-  - name: SuggestDiscardDeclarationVarStyle
-  - name: ArrangeTrailingCommaInMultilineLists
-  - name: ArrangeObjectCreationWhenTypeNotEvident
-  - name: UseRawString
-  - name: VirtualMemberNeverOverridden.Global
-  - name: ArrangeVarKeywordsInDeconstructingDeclaration
-  - name: SuggestVarOrType_BuiltInTypes
+    -   name: ConvertIfStatementToReturnStatement
+    -   name: ConvertIfStatementToConditionalTernaryExpression
+    -   name: AutoPropertyCanBeMadeGetOnly.Global
+    -   name: CanReplaceCastWithLambdaReturnType
+    -   name: ChangeFieldTypeToSystemThreadingLock
+    -   name: ConvertIfStatementToSwitchStatement
+    -   name: ConvertToConstant.Local
+    -   name: DuplicatedSequentialIfBodies
+    -   name: InlineTemporaryVariable
+    -   name: InvertIf
+    -   name: UseVerbatimString
+    -   name: MemberCanBePrivate.Global
+    -   name: MemberCanBeProtected.Global
+    -   name: MergeIntoPattern
+    -   name: UnusedMethodReturnValue.Global
+    -   name: EditorConfigNoMatchingFiles
+    -   name: PreferConcreteValueOverDefault
+    -   name: PropertyCanBeMadeInitOnly.Global
+    -   name: MoveLocalFunctionAfterJumpStatement
+    -   name: RedundantExplicitParamsArrayCreation
+    -   name: RedundantOverload.Global
+    -   name: RedundantStringInterpolation
+    -   name: RedundantVerbatimStringPrefix
+    -   name: ReplaceSubstringWithRangeIndexer
+    -   name: RCS1001
+    -   name: RCS1003
+    -   name: RCS1123
+    -   name: SYSLIB1045
+    -   name: CA1826
+    -   name: RCS1256
+    -   name: RCS1118
+    -   name: RCS1077
+    -   name: RCS1205
+    -   name: RCS1214
+    -   name: RCS1249
+    -   name: RCS1192
+    -   name: SYSLIB1054
+    -   name: CA1512
+    -   name: CA1866
+    -   name: CA1859
+    -   name: RCS1246
+    -   name: CA1829
+    -   name: RCS1266
+    -   name: RCS1267
+    -   name: RCS1227
+    -   name: SwitchExpressionHandlesSomeKnownEnumValuesWithExceptionInDefault
+    -   name: SwitchStatementHandlesSomeKnownEnumValuesWithDefault
+    -   name: RedundantAlwaysMatchSubpattern
+    -   name: UnusedType.Global
+    -   name: UnusedMemberInSuper.Global
+    -   name: UnusedMember.Local
+    -   name: EditorConfigKeyCorrectness
+    -   name: UseCollectionCountProperty
+    -   name: UseDiscardAssignment
+    -   name: ArrangeNamespaceBody
+    -   name: SuggestDiscardDeclarationVarStyle
+    -   name: ArrangeTrailingCommaInMultilineLists
+    -   name: ArrangeObjectCreationWhenTypeNotEvident
+    -   name: UseRawString
+    -   name: VirtualMemberNeverOverridden.Global
+    -   name: ArrangeVarKeywordsInDeconstructingDeclaration
+    -   name: SuggestVarOrType_BuiltInTypes
 #Enable inspections
 #include:
 #  - name: <SomeEnabledInspectionId>
 #Disable inspections
 exclude:
-    - name: ConvertIfStatementToConditionalTernaryExpression
-      paths:
-          - GitVersion.Core.Tests/IntegrationTests/AlignGitFlowWithMainlineVersionStrategy.cs
-          - GitVersion.Core.Tests/IntegrationTests/AlignGitHubFlowWithMainlineVersionStrategy.cs
+    -   name: LoopCanBeConvertedToQuery
+    -   name: ForeachCanBePartlyConvertedToQueryUsingAnotherGetEnumerator
+    -   name: ConvertIfStatementToConditionalTernaryExpression
+        paths:
+            - GitVersion.Core.Tests/IntegrationTests/AlignGitFlowWithMainlineVersionStrategy.cs
+            - GitVersion.Core.Tests/IntegrationTests/AlignGitHubFlowWithMainlineVersionStrategy.cs
 #Execute shell command before Qodana execution (Applied in CI/CD pipeline)
 bootstrap: dotnet build src/GitVersion.slnx
 dotnet:

src/GitVersion.Core/Core/SourceBranchFinder.cs

@@ -34,7 +34,7 @@ public bool IsSourceBranch(INamedReference sourceBranchCandidate)
         private static IEnumerable<Regex> GetSourceBranchRegexes(INamedReference branch, IGitVersionConfiguration configuration)
         {
             var currentBranchConfig = configuration.GetBranchConfiguration(branch.Name);
-            if (currentBranchConfig.SourceBranches == null)
+            if (currentBranchConfig is { SourceBranches: null })
             {
                 yield return RegexPatterns.Cache.GetOrAdd(".*");
             }