Fixed libgit2 bug/deprecated

Yannis Guedel · Yannis Guedel · commit 6c7814f8856d · 2014-12-02T11:54:19.000+01:00
In libgit2 the "Credentials" property is deprecated, instead CredentialsHelper should be used. In 0.19 there is a bug with the Credentials property when cloning, using the "correct" way (CredentialsHelper) fixes the bug: libgit2/libgit2sharp#834 In order to be consistent I changed also the fetch method.
diff --git a/GitVersionCore/BuildServers/GitHelper.cs b/GitVersionCore/BuildServers/GitHelper.cs
@@ -101,7 +101,7 @@ static FetchOptions BuildFetchOptions(string username, string password)
 
             if (!string.IsNullOrEmpty(username))
             {
-                fetchOptions.Credentials = new UsernamePasswordCredentials
+                fetchOptions.CredentialsProvider = (url, user, types) =>  new UsernamePasswordCredentials
                 {
                     Username = username,
                     Password = password
diff --git a/GitVersionExe/GitPreparer.cs b/GitVersionExe/GitPreparer.cs
@@ -57,7 +57,7 @@ string GetGitInfoFromUrl()
             Logger.WriteInfo(string.Format("Retrieving git info from url '{0}'", arguments.TargetUrl));
 
             Repository.Clone(arguments.TargetUrl, gitDirectory, 
-                new CloneOptions { IsBare = true, Checkout = false, Credentials = credentials});
+                new CloneOptions { IsBare = true, Checkout = false, CredentialsProvider = (url, user, types) => credentials });
 
             if (!string.IsNullOrWhiteSpace(arguments.TargetBranch))
             {

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ static FetchOptions BuildFetchOptions(string username, string password)`
`101`	`101`
`102`	`102`	`if (!string.IsNullOrEmpty(username))`
`103`	`103`	`{`
`104`		`- fetchOptions.Credentials = new UsernamePasswordCredentials`
	`104`	`+ fetchOptions.CredentialsProvider = (url, user, types) => new UsernamePasswordCredentials`
`105`	`105`	`{`
`106`	`106`	`Username = username,`
`107`	`107`	`Password = password`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ string GetGitInfoFromUrl()`
`57`	`57`	`Logger.WriteInfo(string.Format("Retrieving git info from url '{0}'", arguments.TargetUrl));`
`58`	`58`
`59`	`59`	`Repository.Clone(arguments.TargetUrl, gitDirectory,`
`60`		`- new CloneOptions { IsBare = true, Checkout = false, Credentials = credentials});`
	`60`	`+ new CloneOptions { IsBare = true, Checkout = false, CredentialsProvider = (url, user, types) => credentials });`
`61`	`61`
`62`	`62`	`if (!string.IsNullOrWhiteSpace(arguments.TargetBranch))`
`63`	`63`	`{`