use ConfigurationConstants instead of hardcoded strings

Author: arturcic

src/GitVersion.Core/Configuration/ConfigurationBuilderBase.cs

@@ -41,6 +41,54 @@ internal abstract class ConfigurationBuilderBase<TConfigurationBuilder>
     private bool? isMainline;
     private int? preReleaseWeight;
 
+    protected readonly BranchMetaData MainBranch = new()
+    {
+        Name = ConfigurationConstants.MainBranchKey,
+        RegexPattern = ConfigurationConstants.MainBranchRegex
+    };
+
+    protected readonly BranchMetaData DevelopBranch = new()
+    {
+        Name = ConfigurationConstants.DevelopBranchKey,
+        RegexPattern = ConfigurationConstants.DevelopBranchRegex
+    };
+
+    protected readonly BranchMetaData ReleaseBranch = new()
+    {
+        Name = ConfigurationConstants.ReleaseBranchKey,
+        RegexPattern = ConfigurationConstants.ReleaseBranchRegex
+    };
+
+    protected readonly BranchMetaData FeatureBranch = new()
+    {
+        Name = ConfigurationConstants.FeatureBranchKey,
+        RegexPattern = ConfigurationConstants.FeatureBranchRegex
+    };
+
+    protected readonly BranchMetaData PullRequestBranch = new()
+    {
+        Name = ConfigurationConstants.PullRequestBranchKey,
+        RegexPattern = ConfigurationConstants.PullRequestBranchRegex
+    };
+
+    protected readonly BranchMetaData HotfixBranch = new()
+    {
+        Name = ConfigurationConstants.HotfixBranchKey,
+        RegexPattern = ConfigurationConstants.HotfixBranchRegex
+    };
+
+    protected readonly BranchMetaData SupportBranch = new()
+    {
+        Name = ConfigurationConstants.SupportBranchKey,
+        RegexPattern = ConfigurationConstants.SupportBranchRegex
+    };
+
+    protected readonly BranchMetaData UnknownBranch = new()
+    {
+        Name = ConfigurationConstants.UnknownBranchKey,
+        RegexPattern = ConfigurationConstants.UnknownBranchRegex
+    };
+
     protected ConfigurationBuilderBase()
     {
         if (GetType() != typeof(TConfigurationBuilder))
@@ -432,7 +480,7 @@ private static void ValidateConfiguration(GitVersionConfiguration configuration)
         }
     }
 
-    public record BranchMetaData
+    protected record BranchMetaData
     {
         public string Name { get; init; }
 

src/GitVersion.Core/Configuration/GitFlowConfigurationBuilder.cs

@@ -167,52 +167,4 @@ private GitFlowConfigurationBuilder()
             }
         });
     }
-
-    public static readonly BranchMetaData MainBranch = new()
-    {
-        Name = ConfigurationConstants.MainBranchKey,
-        RegexPattern = ConfigurationConstants.MainBranchRegex
-    };
-
-    public static readonly BranchMetaData DevelopBranch = new()
-    {
-        Name = ConfigurationConstants.DevelopBranchKey,
-        RegexPattern = ConfigurationConstants.DevelopBranchRegex
-    };
-
-    public static readonly BranchMetaData ReleaseBranch = new()
-    {
-        Name = ConfigurationConstants.ReleaseBranchKey,
-        RegexPattern = ConfigurationConstants.ReleaseBranchRegex
-    };
-
-    public static readonly BranchMetaData FeatureBranch = new()
-    {
-        Name = ConfigurationConstants.FeatureBranchKey,
-        RegexPattern = ConfigurationConstants.FeatureBranchRegex
-    };
-
-    public static readonly BranchMetaData PullRequestBranch = new()
-    {
-        Name = ConfigurationConstants.PullRequestBranchKey,
-        RegexPattern = ConfigurationConstants.PullRequestBranchRegex
-    };
-
-    public static readonly BranchMetaData HotfixBranch = new()
-    {
-        Name = ConfigurationConstants.HotfixBranchKey,
-        RegexPattern = ConfigurationConstants.HotfixBranchRegex
-    };
-
-    public static readonly BranchMetaData SupportBranch = new()
-    {
-        Name = ConfigurationConstants.SupportBranchKey,
-        RegexPattern = ConfigurationConstants.SupportBranchRegex
-    };
-
-    public static readonly BranchMetaData UnknownBranch = new()
-    {
-        Name = ConfigurationConstants.UnknownBranchKey,
-        RegexPattern = ConfigurationConstants.UnknownBranchRegex
-    };
 }

src/GitVersion.Core/Configuration/GitHubFlowConfigurationBuilder.cs

@@ -111,34 +111,4 @@ private GitHubFlowConfigurationBuilder()
             }
         });
     }
-
-    public static readonly BranchMetaData MainBranch = new()
-    {
-        Name = ConfigurationConstants.MainBranchKey,
-        RegexPattern = ConfigurationConstants.MainBranchRegex
-    };
-
-    public static readonly BranchMetaData ReleaseBranch = new()
-    {
-        Name = ConfigurationConstants.ReleaseBranchKey,
-        RegexPattern = ConfigurationConstants.ReleaseBranchRegex
-    };
-
-    public static readonly BranchMetaData FeatureBranch = new()
-    {
-        Name = ConfigurationConstants.FeatureBranchKey,
-        RegexPattern = ConfigurationConstants.FeatureBranchRegex
-    };
-
-    public static readonly BranchMetaData PullRequestBranch = new()
-    {
-        Name = ConfigurationConstants.PullRequestBranchKey,
-        RegexPattern = ConfigurationConstants.PullRequestBranchRegex
-    };
-
-    public static readonly BranchMetaData UnknownBranch = new()
-    {
-        Name = ConfigurationConstants.UnknownBranchKey,
-        RegexPattern = ConfigurationConstants.UnknownBranchRegex
-    };
 }