Skip to content

Commit 83f304f

Browse files
committed
R# cleanup
1 parent 9d3149c commit 83f304f

File tree

1 file changed

+39
-8
lines changed

1 file changed

+39
-8
lines changed

src/GitVersionCore/OutputVariables/VersionVariables.cs

Lines changed: 39 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,28 @@
66

77
public class VersionVariables : IEnumerable<KeyValuePair<string, string>>
88
{
9-
public VersionVariables(string major, string minor, string patch, string buildMetaData, string buildMetaDataPadded, string fullBuildMetaData, string branchName, string sha, string majorMinorPatch, string semVer, string legacySemVer, string legacySemVerPadded, string fullSemVer, string assemblySemVer, string preReleaseTag, string preReleaseTagWithDash, string informationalVersion,
10-
string commitDate, string nugetVersion, string nugetVersionV2, string commitsSinceVersionSource, string commitsSinceVersionSourcePadded)
9+
public VersionVariables(string major,
10+
string minor,
11+
string patch,
12+
string buildMetaData,
13+
string buildMetaDataPadded,
14+
string fullBuildMetaData,
15+
string branchName,
16+
string sha,
17+
string majorMinorPatch,
18+
string semVer,
19+
string legacySemVer,
20+
string legacySemVerPadded,
21+
string fullSemVer,
22+
string assemblySemVer,
23+
string preReleaseTag,
24+
string preReleaseTagWithDash,
25+
string informationalVersion,
26+
string commitDate,
27+
string nugetVersion,
28+
string nugetVersionV2,
29+
string commitsSinceVersionSource,
30+
string commitsSinceVersionSourcePadded)
1131
{
1232
Major = major;
1333
Minor = minor;
@@ -33,6 +53,7 @@ public VersionVariables(string major, string minor, string patch, string buildMe
3353
CommitsSinceVersionSourcePadded = commitsSinceVersionSourcePadded;
3454
}
3555

56+
3657
public string Major { get; private set; }
3758
public string Minor { get; private set; }
3859
public string Patch { get; private set; }
@@ -57,30 +78,39 @@ public VersionVariables(string major, string minor, string patch, string buildMe
5778

5879
public static IEnumerable<string> AvailableVariables
5980
{
60-
get { return typeof(VersionVariables).GetProperties().Select(p => p.Name).OrderBy(a => a); }
81+
get
82+
{
83+
return typeof(VersionVariables)
84+
.GetProperties()
85+
.Select(p => p.Name)
86+
.OrderBy(a => a);
87+
}
6188
}
6289

6390
public string CommitDate { get; set; }
6491

92+
public string this[string variable]
93+
{
94+
get { return (string)typeof(VersionVariables).GetProperty(variable).GetValue(this, null); }
95+
}
96+
97+
6598
public IEnumerator<KeyValuePair<string, string>> GetEnumerator()
6699
{
67100
var type = typeof(string);
68101
return typeof(VersionVariables)
69102
.GetProperties()
70103
.Where(p => p.PropertyType == type && !p.GetIndexParameters().Any())
71-
.Select(p => new KeyValuePair<string, string>(p.Name, (string) p.GetValue(this, null)))
104+
.Select(p => new KeyValuePair<string, string>(p.Name, (string)p.GetValue(this, null)))
72105
.GetEnumerator();
73106
}
74107

108+
75109
IEnumerator IEnumerable.GetEnumerator()
76110
{
77111
return GetEnumerator();
78112
}
79113

80-
public string this [string variable]
81-
{
82-
get { return (string) typeof(VersionVariables).GetProperty(variable).GetValue(this, null); }
83-
}
84114

85115
public bool TryGetValue(string variable, out string variableValue)
86116
{
@@ -94,6 +124,7 @@ public bool TryGetValue(string variable, out string variableValue)
94124
return false;
95125
}
96126

127+
97128
public bool ContainsKey(string variable)
98129
{
99130
return typeof(VersionVariables).GetProperty(variable) != null;

0 commit comments

Comments
 (0)