Added support for forward slashes (unix paths) in command line arguments

Author: asbjornu

src/GitVersionExe.Tests/ArgumentParserTests.cs

@@ -284,4 +284,11 @@ public void other_arguments_can_be_parsed_after_nofetch()
         arguments.NoFetch = true;
         arguments.Proj = "foo.sln";
     }
+
+    [Test]
+    public void log_path_can_contain_forward_slash()
+    {
+        var arguments = ArgumentParser.ParseArguments("-l /some/path");
+        arguments.LogFilePath.ShouldBe("/some/path");
+    }
 }

src/GitVersionExe.Tests/ExecCmdLineArgumentTest.cs

@@ -45,4 +45,19 @@ public void InvalidArgumentsExitCodeShouldNotBeZero()
             result.Output.ShouldContain("Could not parse command line parameter '/invalid-argument'");
         }
     }
+
+    [Test]
+    public void LogPathContainsForwardSlash()
+    {
+        using (var fixture = new EmptyRepositoryFixture())
+        {
+            fixture.MakeATaggedCommit("1.2.3");
+            fixture.MakeACommit();
+
+            var result = GitVersionHelper.ExecuteIn(fixture.RepositoryPath, arguments: @" /l ""/some/path""", logToFile: false);
+
+            result.ExitCode.ShouldBe(0);
+            result.Output.ShouldContain(@"""MajorMinorPatch"":""1.2.4""");
+        }
+    }
 }

src/GitVersionExe/ArgumentParser.cs

@@ -316,13 +316,15 @@ static NameValueCollection CollectSwitchesAndValuesFromArguments(List<string> na
             var args = new NameValueCollection();
 
             string currentKey = null;
+            var isBooleanArgument = true;
             for (var index = 0; index < namedArguments.Count; index = index + 1)
             {
                 var arg = namedArguments[index];
-                //If this is a switch, create new name/value entry for it, with a null value.
-                if (IsSwitchArgument(arg))
+                // If the current (previous) argument doesn't require a parameter and this is a switch, create new name/value entry for it, with a null value.
+                if (isBooleanArgument && IsSwitchArgument(arg))
                 {
                     currentKey = arg;
+                    isBooleanArgument = IsBooleanArgument(arg);
                     args.Add(currentKey, null);
                 }
                 //If this is a value (not a switch)
@@ -338,14 +340,18 @@ static NameValueCollection CollectSwitchesAndValuesFromArguments(List<string> na
                     {
                         args.Add(currentKey, arg);
                     }
+
+                    // Reset the boolean argument flag so the next argument won't be ignored.
+                    isBooleanArgument = true;
                 }
             }
             return args;
         }
 
         static bool IsSwitchArgument(string value)
         {
-            return value != null && (value.StartsWith("-") || value.StartsWith("/"))
+            return value != null
+                && (value.StartsWith("-") || value.StartsWith("/"))
                 && !Regex.Match(value, @"/\w+:").Success; //Exclude msbuild & project parameters in form /blah:, which should be parsed as values, not switch names.
         }
 
@@ -376,5 +382,18 @@ static bool IsHelp(string singleArgument)
                 IsSwitch("help", singleArgument) ||
                 IsSwitch("?", singleArgument);
         }
+
+        static bool IsBooleanArgument(string switchName)
+        {
+            var booleanArguments = new[]
+            {
+                "init",
+                "updateassemblyinfo",
+                "ensureassemblyinfo",
+                "nofetch"
+            };
+
+            return booleanArguments.Contains(switchName, StringComparer.OrdinalIgnoreCase);
+        }
     }
 }