Skip to content

Commit 8c4273c

Browse files
committed
cleanup
1 parent c034dbc commit 8c4273c

17 files changed

+59
-76
lines changed

src/GitVersion.BuildAgents/Agents/BuildKite.cs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,10 @@ public override string[] GenerateSetParameterMessage(string name, string? value)
2828
{
2929
return Environment.GetEnvironmentVariable("BUILDKITE_BRANCH");
3030
}
31-
else
32-
{
33-
// For pull requests BUILDKITE_BRANCH refers to the head, so adjust the
34-
// branch name for pull request versioning to function as expected
35-
return string.Format("refs/pull/{0}/head", pullRequest);
36-
}
31+
32+
// For pull requests BUILDKITE_BRANCH refers to the head, so adjust the
33+
// branch name for pull request versioning to function as expected
34+
return string.Format("refs/pull/{0}/head", pullRequest);
3735
}
3836

3937
public override bool PreventFetch() => true;

src/GitVersion.Core.Tests/Configuration/ConfigurationProviderTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ public void ShouldOverrideTagPrefixWithOverrideConfigValue([Values] bool tagPref
412412
{
413413
var text = tagPrefixSetAtYmlFile ? "tag-prefix: custom-tag-prefix-from-yml" : "";
414414
SetupConfigFileContent(text);
415-
var overrideConfiguration = new Dictionary<object, object?>()
415+
var overrideConfiguration = new Dictionary<object, object?>
416416
{
417417
{ "tag-prefix", "tag-prefix-from-override-configuration" }
418418
};
@@ -426,7 +426,7 @@ public void ShouldNotOverrideDefaultTagPrefixWhenNotSetInOverrideConfig()
426426
{
427427
const string text = "";
428428
SetupConfigFileContent(text);
429-
var overrideConfiguration = new Dictionary<object, object?>()
429+
var overrideConfiguration = new Dictionary<object, object?>
430430
{
431431
{ "next-version", "1.0.0" }
432432
};
@@ -441,7 +441,7 @@ public void ShouldNotOverrideTagPrefixFromConfigFileWhenNotSetInOverrideConfig()
441441
{
442442
const string text = "tag-prefix: custom-tag-prefix-from-yml";
443443
SetupConfigFileContent(text);
444-
var overrideConfiguration = new Dictionary<object, object?>()
444+
var overrideConfiguration = new Dictionary<object, object?>
445445
{
446446
{ "next-version", "1.0.0" }
447447
};
@@ -455,7 +455,7 @@ public void ShouldOverrideTagPrefixFromConfigFileWhenSetInOverrideConfig()
455455
{
456456
const string text = "tag-prefix: custom-tag-prefix-from-yml";
457457
SetupConfigFileContent(text);
458-
var overrideConfiguration = new Dictionary<object, object?>()
458+
var overrideConfiguration = new Dictionary<object, object?>
459459
{
460460
{ "tag-prefix", "custom-tag-prefix-from-console" }
461461
};

src/GitVersion.Core.Tests/IntegrationTests/IgnoreBeforeScenarios.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public void ShouldFallbackToBaseVersionWhenAllCommitsAreIgnored(string? nextVers
1717
fixture.MakeACommit();
1818

1919
var configuration = GitFlowConfigurationBuilder.New.WithNextVersion(nextVersion)
20-
.WithIgnoreConfiguration(new IgnoreConfiguration() { Before = dateTimeNow.AddDays(1) }).Build();
20+
.WithIgnoreConfiguration(new IgnoreConfiguration { Before = dateTimeNow.AddDays(1) }).Build();
2121

2222
fixture.AssertFullSemver(expectedFullSemVer, configuration);
2323
}
@@ -33,7 +33,7 @@ public void ShouldNotFallbackToBaseVersionWhenAllCommitsAreNotIgnored(string? ne
3333
fixture.MakeACommit();
3434

3535
var configuration = GitFlowConfigurationBuilder.New.WithNextVersion(nextVersion)
36-
.WithIgnoreConfiguration(new IgnoreConfiguration() { Before = dateTimeNow.AddDays(-1) }).Build();
36+
.WithIgnoreConfiguration(new IgnoreConfiguration { Before = dateTimeNow.AddDays(-1) }).Build();
3737

3838
fixture.AssertFullSemver(expectedFullSemVer, configuration);
3939
}

src/GitVersion.Core.Tests/MergeMessageTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ public void ParsesBitBucketPullMergeMessage_v7(
176176

177177
private static readonly object?[] BitBucketCloudPullMergeMessages =
178178
{
179-
new object?[] { $@"Merged in release/2.301.0 (pull request #1789)
179+
new object?[] { @"Merged in release/2.301.0 (pull request #1789)
180180
181181
Release/2.301.0
182182

src/GitVersion.Core.Tests/VersionCalculation/Strategies/ConfigNextVersionBaseVersionStrategyTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public void ReturnsNullWhenNoNextVersionIsInConfig()
2424
[TestCase("0.1", "0.1.0", SemanticVersionFormat.Loose)]
2525
public void ConfigNextVersionTest(string nextVersion, string expectedVersion, SemanticVersionFormat versionFormat)
2626
{
27-
var overrideConfiguration = new Dictionary<object, object?>()
27+
var overrideConfiguration = new Dictionary<object, object?>
2828
{
2929
{ "next-version", nextVersion },
3030
{ "semantic-version-format", versionFormat }
@@ -39,7 +39,7 @@ public void ConfigNextVersionTest(string nextVersion, string expectedVersion, Se
3939
[TestCase("0.1", SemanticVersionFormat.Strict)]
4040
public void ConfigNextVersionTestShouldFail(string nextVersion, SemanticVersionFormat versionFormat)
4141
{
42-
var overrideConfiguration = new Dictionary<object, object?>()
42+
var overrideConfiguration = new Dictionary<object, object?>
4343
{
4444
{ "next-version", nextVersion },
4545
{ "semantic-version-format", versionFormat }

src/GitVersion.Core/Configuration/ConfigurationExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public static IBranchConfiguration GetBranchConfiguration(this IGitVersionConfig
2020
public static IBranchConfiguration GetBranchConfiguration(this IGitVersionConfiguration configuration, ReferenceName branchName)
2121
{
2222
var branchConfiguration = GetBranchConfigurations(configuration, branchName.WithoutOrigin).FirstOrDefault();
23-
branchConfiguration ??= new BranchConfiguration()
23+
branchConfiguration ??= new BranchConfiguration
2424
{
2525
RegularExpression = string.Empty,
2626
Label = ConfigurationConstants.BranchNamePlaceholder,

src/GitVersion.Core/Configuration/GitFlowConfigurationBuilder.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ internal sealed class GitFlowConfigurationBuilder : ConfigurationBuilderBase<Git
99

1010
private GitFlowConfigurationBuilder()
1111
{
12-
WithConfiguration(new GitVersionConfiguration()
12+
WithConfiguration(new GitVersionConfiguration
1313
{
1414
AssemblyFileVersioningScheme = AssemblyFileVersioningScheme.MajorMinorPatch,
1515
AssemblyVersioningScheme = AssemblyVersioningScheme.MajorMinorPatch,
@@ -36,7 +36,7 @@ private GitFlowConfigurationBuilder()
3636
IsMainline = false
3737
});
3838

39-
WithBranch(DevelopBranch.Name).WithConfiguration(new BranchConfiguration()
39+
WithBranch(DevelopBranch.Name).WithConfiguration(new BranchConfiguration
4040
{
4141
Increment = IncrementStrategy.Minor,
4242
RegularExpression = DevelopBranch.RegexPattern,
@@ -50,7 +50,7 @@ private GitFlowConfigurationBuilder()
5050
PreReleaseWeight = 0
5151
});
5252

53-
WithBranch(MainBranch.Name).WithConfiguration(new BranchConfiguration()
53+
WithBranch(MainBranch.Name).WithConfiguration(new BranchConfiguration
5454
{
5555
Increment = IncrementStrategy.Patch,
5656
RegularExpression = MainBranch.RegexPattern,
@@ -67,7 +67,7 @@ private GitFlowConfigurationBuilder()
6767
PreReleaseWeight = 55000
6868
});
6969

70-
WithBranch(ReleaseBranch.Name).WithConfiguration(new BranchConfiguration()
70+
WithBranch(ReleaseBranch.Name).WithConfiguration(new BranchConfiguration
7171
{
7272
Increment = IncrementStrategy.None,
7373
RegularExpression = ReleaseBranch.RegexPattern,
@@ -87,7 +87,7 @@ private GitFlowConfigurationBuilder()
8787
PreReleaseWeight = 30000
8888
});
8989

90-
WithBranch(FeatureBranch.Name).WithConfiguration(new BranchConfiguration()
90+
WithBranch(FeatureBranch.Name).WithConfiguration(new BranchConfiguration
9191
{
9292
Increment = IncrementStrategy.Inherit,
9393
RegularExpression = FeatureBranch.RegexPattern,
@@ -104,7 +104,7 @@ private GitFlowConfigurationBuilder()
104104
PreReleaseWeight = 30000
105105
});
106106

107-
WithBranch(PullRequestBranch.Name).WithConfiguration(new BranchConfiguration()
107+
WithBranch(PullRequestBranch.Name).WithConfiguration(new BranchConfiguration
108108
{
109109
Increment = IncrementStrategy.Inherit,
110110
RegularExpression = PullRequestBranch.RegexPattern,
@@ -122,7 +122,7 @@ private GitFlowConfigurationBuilder()
122122
PreReleaseWeight = 30000
123123
});
124124

125-
WithBranch(HotfixBranch.Name).WithConfiguration(new BranchConfiguration()
125+
WithBranch(HotfixBranch.Name).WithConfiguration(new BranchConfiguration
126126
{
127127
Increment = IncrementStrategy.Inherit,
128128
RegularExpression = HotfixBranch.RegexPattern,
@@ -138,7 +138,7 @@ private GitFlowConfigurationBuilder()
138138
PreReleaseWeight = 30000
139139
});
140140

141-
WithBranch(SupportBranch.Name).WithConfiguration(new BranchConfiguration()
141+
WithBranch(SupportBranch.Name).WithConfiguration(new BranchConfiguration
142142
{
143143
Increment = IncrementStrategy.Patch,
144144
RegularExpression = SupportBranch.RegexPattern,
@@ -152,7 +152,7 @@ private GitFlowConfigurationBuilder()
152152
PreReleaseWeight = 55000
153153
});
154154

155-
WithBranch(UnknownBranch.Name).WithConfiguration(new BranchConfiguration()
155+
WithBranch(UnknownBranch.Name).WithConfiguration(new BranchConfiguration
156156
{
157157
RegularExpression = UnknownBranch.RegexPattern,
158158
Label = ConfigurationConstants.BranchNamePlaceholder,

src/GitVersion.Core/Configuration/GitHubFlowConfigurationBuilder.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ internal sealed class GitHubFlowConfigurationBuilder : ConfigurationBuilderBase<
99

1010
private GitHubFlowConfigurationBuilder()
1111
{
12-
WithConfiguration(new GitVersionConfiguration()
12+
WithConfiguration(new GitVersionConfiguration
1313
{
1414
AssemblyFileVersioningScheme = AssemblyFileVersioningScheme.MajorMinorPatch,
1515
AssemblyVersioningScheme = AssemblyVersioningScheme.MajorMinorPatch,
@@ -36,7 +36,7 @@ private GitHubFlowConfigurationBuilder()
3636
IsMainline = false
3737
});
3838

39-
WithBranch(MainBranch.Name).WithConfiguration(new BranchConfiguration()
39+
WithBranch(MainBranch.Name).WithConfiguration(new BranchConfiguration
4040
{
4141
Increment = IncrementStrategy.Patch,
4242
RegularExpression = MainBranch.RegexPattern,
@@ -52,7 +52,7 @@ private GitHubFlowConfigurationBuilder()
5252
PreReleaseWeight = 55000
5353
});
5454

55-
WithBranch(ReleaseBranch.Name).WithConfiguration(new BranchConfiguration()
55+
WithBranch(ReleaseBranch.Name).WithConfiguration(new BranchConfiguration
5656
{
5757
Increment = IncrementStrategy.None,
5858
RegularExpression = ReleaseBranch.RegexPattern,
@@ -70,7 +70,7 @@ private GitHubFlowConfigurationBuilder()
7070
PreReleaseWeight = 30000
7171
});
7272

73-
WithBranch(FeatureBranch.Name).WithConfiguration(new BranchConfiguration()
73+
WithBranch(FeatureBranch.Name).WithConfiguration(new BranchConfiguration
7474
{
7575
Increment = IncrementStrategy.Inherit,
7676
RegularExpression = FeatureBranch.RegexPattern,
@@ -84,7 +84,7 @@ private GitHubFlowConfigurationBuilder()
8484
PreReleaseWeight = 30000
8585
});
8686

87-
WithBranch(PullRequestBranch.Name).WithConfiguration(new BranchConfiguration()
87+
WithBranch(PullRequestBranch.Name).WithConfiguration(new BranchConfiguration
8888
{
8989
Increment = IncrementStrategy.Inherit,
9090
RegularExpression = PullRequestBranch.RegexPattern,
@@ -99,7 +99,7 @@ private GitHubFlowConfigurationBuilder()
9999
PreReleaseWeight = 30000
100100
});
101101

102-
WithBranch(UnknownBranch.Name).WithConfiguration(new BranchConfiguration()
102+
WithBranch(UnknownBranch.Name).WithConfiguration(new BranchConfiguration
103103
{
104104
RegularExpression = UnknownBranch.RegexPattern,
105105
Label = ConfigurationConstants.BranchNamePlaceholder,

src/GitVersion.Core/Configuration/IgnoreConfigurationBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public IgnoreConfigurationBuilder WithShas(HashSet<string> value)
3232
return this;
3333
}
3434

35-
public IIgnoreConfiguration Build() => new IgnoreConfiguration()
35+
public IIgnoreConfiguration Build() => new IgnoreConfiguration
3636
{
3737
Before = before,
3838
Shas = shas

src/GitVersion.Core/Configuration/Init/EditConfigStep.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
using GitVersion.Configuration.Init.SetConfig;
33
using GitVersion.Configuration.Init.Wizard;
44
using GitVersion.Logging;
5+
using GitVersion.VersionCalculation;
56

67
namespace GitVersion.Configuration.Init;
78

@@ -57,7 +58,7 @@ protected override string GetPrompt(ConfigurationBuilder configurationBuilder, s
5758
5859
3) Set next version number
5960
4) Branch specific configuration
60-
5) Branch Increment mode (per commit/after tag) (Current: {configuration.VersioningMode ?? VersionCalculation.VersioningMode.ContinuousDeployment})
61+
5) Branch Increment mode (per commit/after tag) (Current: {configuration.VersioningMode ?? VersioningMode.ContinuousDeployment})
6162
6) Assembly versioning scheme (Current: {configuration.AssemblyVersioningScheme})
6263
7) Setup build scripts";
6364
}

0 commit comments

Comments
 (0)