Skip to content

Commit 940a0aa

Browse files
authored
Merge pull request #3835 from arturcic/fix/3832
#3832 - fix setting the TargetFramework in the GitVersion.MsBuild.targets
2 parents c704b65 + 6336b80 commit 940a0aa

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

src/GitVersion.MsBuild/msbuild/tools/GitVersion.MsBuild.props

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,6 @@
1818
<GitVersion_ToolArgments Condition=" '$(GitVersion_NoCacheEnabled)' == 'true' ">$(GitVersion_ToolArgments) -nocache</GitVersion_ToolArgments>
1919
</PropertyGroup>
2020

21-
<PropertyGroup>
22-
<GitVersionFileExe Condition="'$(GitVersionFileExe)' == ''">dotnet --roll-forward Major &quot;$(MSBuildThisFileDirectory)$(TargetFramework)/gitversion.dll&quot;</GitVersionFileExe>
23-
<GitVersionAssemblyFile Condition="'$(GitVersionAssemblyFile)' == ''">$(MSBuildThisFileDirectory)$(TargetFramework)/GitVersion.MsBuild.dll</GitVersionAssemblyFile>
24-
</PropertyGroup>
25-
2621
<PropertyGroup>
2722
<!-- The GitVersion task is explicitly disabled when running on the .NET Framework because it's no longer supported.
2823
If a project that uses GitVersion.MsBuild is opened in Visual Studio,

src/GitVersion.MsBuild/msbuild/tools/GitVersion.MsBuild.targets

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,21 @@
11
<?xml version="1.0" encoding="utf-8"?>
22

33
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
4-
<UsingTask TaskName="GetVersion" AssemblyFile="$(GitVersionAssemblyFile)" />
5-
<UsingTask TaskName="GenerateGitVersionInformation" AssemblyFile="$(GitVersionAssemblyFile)" />
6-
<UsingTask TaskName="WriteVersionInfoToBuildLog" AssemblyFile="$(GitVersionAssemblyFile)" />
7-
<UsingTask TaskName="UpdateAssemblyInfo" AssemblyFile="$(GitVersionAssemblyFile)" />
8-
94
<PropertyGroup>
105
<GenerateGitVersionFiles>false</GenerateGitVersionFiles>
116
<GenerateGitVersionFiles Condition=" '$(Language)' == 'C#' Or '$(Language)' == 'F#' Or '$(Language)' == 'VB' ">true</GenerateGitVersionFiles>
127

138
<UpdateAssemblyInfo Condition=" '$(UpdateAssemblyInfo)' == 'true' And '$(GenerateGitVersionFiles)' == 'true' ">true</UpdateAssemblyInfo>
149
<GenerateGitVersionInformation Condition=" '$(GenerateGitVersionInformation)' == '' And '$(GenerateGitVersionFiles)' == 'true' ">true</GenerateGitVersionInformation>
10+
11+
<GitVersionFileExe Condition="'$(GitVersionFileExe)' == ''">dotnet --roll-forward Major &quot;$(MSBuildThisFileDirectory)$(TargetFramework)/gitversion.dll&quot;</GitVersionFileExe>
12+
<GitVersionAssemblyFile Condition="'$(GitVersionAssemblyFile)' == ''">$(MSBuildThisFileDirectory)$(TargetFramework)/GitVersion.MsBuild.dll</GitVersionAssemblyFile>
1513
</PropertyGroup>
14+
15+
<UsingTask TaskName="GetVersion" AssemblyFile="$(GitVersionAssemblyFile)" />
16+
<UsingTask TaskName="GenerateGitVersionInformation" AssemblyFile="$(GitVersionAssemblyFile)" />
17+
<UsingTask TaskName="WriteVersionInfoToBuildLog" AssemblyFile="$(GitVersionAssemblyFile)" />
18+
<UsingTask TaskName="UpdateAssemblyInfo" AssemblyFile="$(GitVersionAssemblyFile)" />
1619

1720
<Target Name="RunGitVersion" Condition="'$(DisableGitVersionTask)' == 'false'">
1821
<Exec Command="$(GitVersionFileExe) &quot;$(MSBuildProjectDirectory)&quot; $(GitVersion_ToolArgments)" />

0 commit comments

Comments
 (0)