Reference proxy

Author: arturcic

src/GitVersionCore.Tests/Core/RepositoryExtensionsTests.cs

@@ -11,6 +11,7 @@
 using Commit = GitVersion.Commit;
 using Branch = GitVersion.Branch;
 using BranchCollection = GitVersion.BranchCollection;
+using Reference = GitVersion.Reference;
 using ReferenceCollection = GitVersion.ReferenceCollection;
 using Remote = GitVersion.Remote;
 
@@ -181,19 +182,15 @@ public override Reference UpdateTarget(Reference directRef, ObjectId targetId)
 
         private class TestableReference : Reference
         {
-            private readonly string canonicalName;
 
             public TestableReference(string canonicalName)
             {
-                this.canonicalName = canonicalName;
+                this.CanonicalName = canonicalName;
             }
 
-            public override string CanonicalName => canonicalName;
+            public override string CanonicalName { get; }
 
-            public override DirectReference ResolveToDirectReference()
-            {
-                throw new NotImplementedException();
-            }
+            public override DirectReference ResolveToDirectReference() => throw new NotImplementedException();
         }
     }
 }

src/GitVersionCore/Core/GitModel.cs

@@ -132,6 +132,26 @@ protected Branch()
         public virtual bool IsTracking => innerBranch != null && innerBranch.IsTracking;
     }
 
+    public class Reference
+    {
+        private readonly LibGit2Sharp.Reference innerReference;
+
+        private Reference(LibGit2Sharp.Reference reference)
+        {
+            innerReference = reference;
+        }
+
+        protected Reference()
+        {
+        }
+        public virtual string CanonicalName => innerReference.CanonicalName;
+        public string TargetIdentifier => innerReference.TargetIdentifier;
+
+        public virtual DirectReference ResolveToDirectReference() => innerReference.ResolveToDirectReference();
+        public static implicit operator LibGit2Sharp.Reference(Reference d) => d?.innerReference;
+        public static explicit operator Reference(LibGit2Sharp.Reference b) => b is null ? null : new Reference(b);
+    }
+
     public class Remote
     {
         private readonly LibGit2Sharp.Remote innerRemote;
@@ -220,12 +240,12 @@ protected ReferenceCollection()
         public IEnumerator<Reference> GetEnumerator()
         {
             foreach (var reference in innerCollection)
-                yield return reference;
+                yield return (Reference)reference;
         }
 
         public virtual Reference Add(string name, string canonicalRefNameOrObjectish)
         {
-            return innerCollection.Add(name, canonicalRefNameOrObjectish);
+            return (Reference)innerCollection.Add(name, canonicalRefNameOrObjectish);
         }
 
         public virtual DirectReference Add(string name, ObjectId targetId)
@@ -240,7 +260,7 @@ public virtual DirectReference Add(string name, ObjectId targetId, bool allowOve
 
         public virtual Reference UpdateTarget(Reference directRef, ObjectId targetId)
         {
-            return innerCollection.UpdateTarget(directRef, targetId);
+            return (Reference)innerCollection.UpdateTarget(directRef, targetId);
         }
 
         public virtual ReflogCollection Log(string canonicalName)
@@ -249,12 +269,13 @@ public virtual ReflogCollection Log(string canonicalName)
         }
 
         IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
-        public virtual Reference this[string name] => innerCollection[name];
+        public virtual Reference this[string name] => (Reference)innerCollection[name];
         public virtual Reference Head => this["HEAD"];
 
         public virtual IEnumerable<Reference> FromGlob(string pattern)
         {
-            return innerCollection.FromGlob(pattern);
+            foreach (var reference in innerCollection.FromGlob(pattern))
+                yield return (Reference)reference;
         }
     }
 

src/GitVersionCore/Core/RepositoryMetadataProvider.cs

@@ -427,7 +427,7 @@ private IEnumerable<BranchCommit> GetMergeCommitsForBranch(Branch branch, Config
                 {
                     if (otherBranch.Tip == null)
                     {
-                        log.Warning(String.Format(MissingTipFormat, otherBranch.FriendlyName));
+                        log.Warning(string.Format(MissingTipFormat, otherBranch.FriendlyName));
                         return BranchCommit.Empty;
                     }