Skip to content

Commit 972ce71

Browse files
Stefan Schickarturcic
authored andcommitted
Add Test and add EnumConverter
1 parent 5606bf1 commit 972ce71

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

src/GitVersion.App.Tests/ArgumentParserTests.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -533,6 +533,13 @@ private static IEnumerable<TestCaseData> OverrideConfigWithSingleOptionTestData(
533533
UpdateBuildNumber = true
534534
}
535535
);
536+
yield return new TestCaseData(
537+
"strategies=[\"None\",\"Mainline\"]",
538+
new GitVersionConfiguration()
539+
{
540+
VersionStrategies = [ VersionStrategies.None, VersionStrategies.Mainline]
541+
}
542+
);
536543
}
537544

538545
[TestCaseSource(nameof(OverrideConfigWithMultipleOptionsTestData))]

src/GitVersion.App/OverrideConfigurationOptionParser.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using GitVersion.Configuration;
2+
using GitVersion.VersionCalculation;
23

34
namespace GitVersion;
45

@@ -45,7 +46,8 @@ private static bool IsSupportedPropertyType(Type propertyType)
4546
return unwrappedType == typeof(string)
4647
|| unwrappedType.IsEnum
4748
|| unwrappedType == typeof(int)
48-
|| unwrappedType == typeof(bool);
49+
|| unwrappedType == typeof(bool)
50+
|| unwrappedType == typeof(VersionStrategies[]);
4951
}
5052

5153
internal void SetValue(string key, string value) => overrideConfiguration[key] = QuotedStringHelpers.UnquoteText(value);

src/GitVersion.Core/VersionCalculation/VersionStrategies.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
namespace GitVersion.VersionCalculation;
22

33
[Flags]
4+
[JsonConverter(typeof(JsonStringEnumConverter))]
45
public enum VersionStrategies
56
{
67
None = 0,

0 commit comments

Comments
 (0)