Code review feedback - adding assemblyversion formatting unit tests

Author: MarkZuber

src/GitVersionCore.Tests/ConfigProviderTests.cs

@@ -125,6 +125,20 @@ public void CanUpdateAssemblyInformationalVersioningScheme()
         config.AssemblyInformationalFormat.ShouldBe("{NugetVersion}");
     }
 
+    [Test]
+    public void CanUpdateAssemblyInformationalVersioningSchemeWithMultipleVariables()
+    {
+        const string text = @"
+assembly-versioning-scheme: MajorMinor
+assembly-informational-format: '{Major}.{Minor}.{Patch}'";
+
+        SetupConfigFileContent(text);
+
+        var config = ConfigurationProvider.Provide(repoPath, fileSystem);
+        config.AssemblyVersioningScheme.ShouldBe(AssemblyVersioningScheme.MajorMinor);
+        config.AssemblyInformationalFormat.ShouldBe("{Major}.{Minor}.{Patch}");
+    }
+
     [Test]
     public void CanReadDefaultDocument()
     {

src/GitVersionTask.Tests/AssemblyInfoBuilderTests.VerifyAssemblyVersion_MajorMinor_NugetAssemblyInfoWithMultipleVariables.approved.txt

@@ -0,0 +1,46 @@
+//------------------------------------------------------------------------------
+// <auto-generated>
+//     This code was generated by a tool.
+//     GitVersion
+//
+//     Changes to this file may cause incorrect behavior and will be lost if
+//     the code is regenerated.
+// </auto-generated>
+//------------------------------------------------------------------------------
+
+using System;
+using System.Reflection;
+
+[assembly: AssemblyVersion("2.3.0.0")]
+[assembly: AssemblyFileVersion("2.3.4.0")]
+[assembly: AssemblyInformationalVersion("master-2.3.4-commitSha")]
+
+namespace Fake
+{
+
+    [System.Runtime.CompilerServices.CompilerGenerated]
+    static class GitVersionInformation
+    {
+        public static string Major = "2";
+        public static string Minor = "3";
+        public static string Patch = "4";
+        public static string PreReleaseTag = "beta.5";
+        public static string PreReleaseTagWithDash = "-beta.5";
+        public static string BuildMetaData = "6";
+        public static string BuildMetaDataPadded = "0006";
+        public static string FullBuildMetaData = "6.Branch.master.Sha.commitSha";
+        public static string MajorMinorPatch = "2.3.4";
+        public static string SemVer = "2.3.4-beta.5";
+        public static string LegacySemVer = "2.3.4-beta5";
+        public static string LegacySemVerPadded = "2.3.4-beta0005";
+        public static string AssemblySemVer = "2.3.0.0";
+        public static string FullSemVer = "2.3.4-beta.5+6";
+        public static string InformationalVersion = "master-2.3.4-commitSha";
+        public static string BranchName = "master";
+        public static string Sha = "commitSha";
+        public static string NuGetVersionV2 = "2.3.4-beta0005";
+        public static string NuGetVersion = "2.3.4-beta0005";
+        public static string CommitDate = "2014-03-06";
+    }
+
+}

src/GitVersionTask.Tests/AssemblyInfoBuilderTests.cs

@@ -93,6 +93,13 @@ public void VerifyAssemblyVersion_Major_NugetAssemblyInfo()
         VerifyAssemblyVersion(AssemblyVersioningScheme.Major, "{NugetVersion}");
     }
 
+    [Test]
+    [MethodImpl(MethodImplOptions.NoInlining)]
+    public void VerifyAssemblyVersion_MajorMinor_NugetAssemblyInfoWithMultipleVariables()
+    {
+        VerifyAssemblyVersion(AssemblyVersioningScheme.MajorMinor, "{BranchName}-{Major}.{Minor}.{Patch}-{Sha}");
+    }
+
     [Test]
     [MethodImpl(MethodImplOptions.NoInlining)]
     public void VerifyAssemblyVersion_MajorMinor_NugetAssemblyInfo()