Skip to content

Commit aa273df

Browse files
arturcicarturcic
committed
made LibGit2Sharp implementation classes sealed
1 parent fa6d7ec commit aa273df

File tree

11 files changed

+43
-43
lines changed

11 files changed

+43
-43
lines changed

‎src/GitVersion.LibGit2Sharp/Git/Branch.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
namespace GitVersion
66
{
7-
internal class Branch : IBranch
7+
internal sealed class Branch : IBranch
88
{
99
private static readonly LambdaEqualityHelper<IBranch> equalityHelper = new(x => x.CanonicalName);
1010
private static readonly LambdaKeyComparer<IBranch, string> comparerHelper = new(x => x.CanonicalName);
@@ -19,8 +19,8 @@ internal class Branch : IBranch
1919
public override int GetHashCode() => equalityHelper.GetHashCode(this);
2020
public static implicit operator LibGit2Sharp.Branch(Branch d) => d.innerBranch;
2121

22-
public virtual string CanonicalName => innerBranch.CanonicalName;
23-
public virtual string FriendlyName => innerBranch.FriendlyName;
22+
public string CanonicalName => innerBranch.CanonicalName;
23+
public string FriendlyName => innerBranch.FriendlyName;
2424

2525
public string NameWithoutRemote =>
2626
IsRemote
@@ -32,7 +32,7 @@ internal class Branch : IBranch
3232
? FriendlyName.Substring("origin/".Length)
3333
: FriendlyName;
3434

35-
public virtual ICommit? Tip
35+
public ICommit? Tip
3636
{
3737
get
3838
{
@@ -41,7 +41,7 @@ public virtual ICommit? Tip
4141
}
4242
}
4343

44-
public virtual ICommitCollection? Commits
44+
public ICommitCollection? Commits
4545
{
4646
get
4747
{
@@ -61,7 +61,7 @@ public bool IsSameBranch(IBranch otherBranch)
6161
}
6262
public bool IsDetachedHead => CanonicalName.Equals("(no branch)", StringComparison.OrdinalIgnoreCase);
6363

64-
public virtual bool IsRemote => innerBranch.IsRemote;
65-
public virtual bool IsTracking => innerBranch.IsTracking;
64+
public bool IsRemote => innerBranch.IsRemote;
65+
public bool IsTracking => innerBranch.IsTracking;
6666
}
6767
}

‎src/GitVersion.LibGit2Sharp/Git/BranchCollection.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@
44

55
namespace GitVersion
66
{
7-
internal class BranchCollection : IBranchCollection
7+
internal sealed class BranchCollection : IBranchCollection
88
{
99
private readonly LibGit2Sharp.BranchCollection innerCollection;
1010
internal BranchCollection(LibGit2Sharp.BranchCollection collection) => innerCollection = collection;
1111

12-
public virtual IEnumerator<IBranch> GetEnumerator()
12+
public IEnumerator<IBranch> GetEnumerator()
1313
{
1414
return innerCollection.Select(branch => new Branch(branch)).GetEnumerator();
1515
}
1616
IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
17-
public virtual IBranch? this[string friendlyName]
17+
public IBranch? this[string friendlyName]
1818
{
1919
get
2020
{

‎src/GitVersion.LibGit2Sharp/Git/Commit.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
namespace GitVersion
66
{
7-
internal class Commit : ICommit
7+
internal sealed class Commit : ICommit
88
{
99
private static readonly LambdaEqualityHelper<ICommit> equalityHelper = new(x => x.Id);
1010
private static readonly LambdaKeyComparer<ICommit, string> comparerHelper = new(x => x.Sha);
@@ -20,7 +20,7 @@ internal class Commit : ICommit
2020

2121
public static implicit operator LibGit2Sharp.Commit(Commit d) => d.innerCommit;
2222

23-
public virtual IEnumerable<ICommit?> Parents
23+
public IEnumerable<ICommit?> Parents
2424
{
2525
get
2626
{
@@ -31,9 +31,9 @@ public virtual IEnumerable<ICommit?> Parents
3131
}
3232
}
3333

34-
public virtual string Sha => innerCommit.Sha;
34+
public string Sha => innerCommit.Sha;
3535

36-
public virtual IObjectId? Id
36+
public IObjectId? Id
3737
{
3838
get
3939
{
@@ -42,7 +42,7 @@ public virtual IObjectId? Id
4242
}
4343
}
4444

45-
public virtual DateTimeOffset When => innerCommit.Committer.When;
46-
public virtual string Message => innerCommit.Message;
45+
public DateTimeOffset When => innerCommit.Committer.When;
46+
public string Message => innerCommit.Message;
4747
}
4848
}

‎src/GitVersion.LibGit2Sharp/Git/CommitCollection.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,20 @@
66

77
namespace GitVersion
88
{
9-
internal class CommitCollection : ICommitCollection
9+
internal sealed class CommitCollection : ICommitCollection
1010
{
1111
private readonly ICommitLog innerCollection;
1212
internal CommitCollection(ICommitLog collection) => innerCollection = collection;
1313

14-
public virtual IEnumerator<ICommit> GetEnumerator()
14+
public IEnumerator<ICommit> GetEnumerator()
1515
{
1616
return innerCollection.Select(commit => new Commit(commit)).GetEnumerator();
1717
}
1818

1919
IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
2020

2121
public IEnumerable<ICommit> GetCommitsPriorTo(DateTimeOffset olderThan) => this.SkipWhile(c => c.When > olderThan);
22-
public virtual ICommitCollection QueryBy(CommitFilter commitFilter)
22+
public ICommitCollection QueryBy(CommitFilter commitFilter)
2323
{
2424
static object? GetReacheableFrom(object item)
2525
{

‎src/GitVersion.LibGit2Sharp/Git/GitRepository.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
namespace GitVersion
99
{
10-
internal class GitRepository : IGitRepository
10+
internal sealed class GitRepository : IGitRepository
1111
{
1212
private readonly ILog log;
1313
private Lazy<IRepository> repositoryLazy;

‎src/GitVersion.LibGit2Sharp/Git/ObjectId.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace GitVersion
44
{
5-
internal class ObjectId : IObjectId
5+
internal sealed class ObjectId : IObjectId
66
{
77
private static readonly LambdaEqualityHelper<IObjectId> equalityHelper = new(x => x.Sha);
88
private static readonly LambdaKeyComparer<IObjectId, string> comparerHelper = new(x => x.Sha);

‎src/GitVersion.LibGit2Sharp/Git/Reference.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
namespace GitVersion
55
{
6-
internal class Reference : IReference
6+
internal sealed class Reference : IReference
77
{
88
private static readonly LambdaEqualityHelper<IReference> equalityHelper = new(x => x.CanonicalName);
99
private static readonly LambdaKeyComparer<IReference, string> comparerHelper = new(x => x.CanonicalName);
@@ -18,11 +18,11 @@ internal class Reference : IReference
1818
public bool Equals(IReference other) => equalityHelper.Equals(this, other);
1919
public override int GetHashCode() => equalityHelper.GetHashCode(this);
2020

21-
public virtual string CanonicalName => innerReference.CanonicalName;
22-
public virtual string TargetIdentifier => innerReference.TargetIdentifier;
23-
public virtual string DirectReferenceTargetIdentifier => directReference.TargetIdentifier;
24-
public virtual IObjectId DirectReferenceTargetId => new ObjectId(directReference.Target.Id);
25-
public virtual IReference ResolveToDirectReference() => new Reference(directReference);
21+
public string CanonicalName => innerReference.CanonicalName;
22+
public string TargetIdentifier => innerReference.TargetIdentifier;
23+
public string DirectReferenceTargetIdentifier => directReference.TargetIdentifier;
24+
public IObjectId DirectReferenceTargetId => new ObjectId(directReference.Target.Id);
25+
public IReference ResolveToDirectReference() => new Reference(directReference);
2626
public static implicit operator LibGit2Sharp.Reference(Reference d) => d.innerReference;
2727
}
2828
}

‎src/GitVersion.LibGit2Sharp/Git/ReferenceCollection.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,31 +4,31 @@
44

55
namespace GitVersion
66
{
7-
internal class ReferenceCollection : IReferenceCollection
7+
internal sealed class ReferenceCollection : IReferenceCollection
88
{
99
private readonly LibGit2Sharp.ReferenceCollection innerCollection;
1010
internal ReferenceCollection(LibGit2Sharp.ReferenceCollection collection) => innerCollection = collection;
1111

12-
public virtual IEnumerator<IReference> GetEnumerator()
12+
public IEnumerator<IReference> GetEnumerator()
1313
{
1414
return innerCollection.Select(reference => new Reference(reference)).GetEnumerator();
1515
}
1616

17-
public virtual void Add(string name, string canonicalRefNameOrObjectish, bool allowOverwrite = false)
17+
public void Add(string name, string canonicalRefNameOrObjectish, bool allowOverwrite = false)
1818
{
1919
innerCollection.Add(name, canonicalRefNameOrObjectish, allowOverwrite);
2020
}
2121

22-
public virtual void UpdateTarget(IReference directRef, IObjectId targetId)
22+
public void UpdateTarget(IReference directRef, IObjectId targetId)
2323
{
2424
innerCollection.UpdateTarget((Reference)directRef, (ObjectId)targetId);
2525
}
2626

2727
IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
28-
public virtual IReference this[string name] => new Reference(innerCollection[name]);
29-
public virtual IReference Head => this["HEAD"];
28+
public IReference this[string name] => new Reference(innerCollection[name]);
29+
public IReference Head => this["HEAD"];
3030

31-
public virtual IEnumerable<IReference> FromGlob(string pattern)
31+
public IEnumerable<IReference> FromGlob(string pattern)
3232
{
3333
return innerCollection.FromGlob(pattern).Select(reference => new Reference(reference));
3434
}

‎src/GitVersion.LibGit2Sharp/Git/Remote.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
namespace GitVersion
55
{
6-
internal class Remote : IRemote
6+
internal sealed class Remote : IRemote
77
{
88
private static readonly LambdaEqualityHelper<IRemote> equalityHelper = new(x => x.Name);
99
private static readonly LambdaKeyComparer<IRemote, string> comparerHelper = new(x => x.Name);
@@ -16,7 +16,7 @@ internal class Remote : IRemote
1616
public override bool Equals(object obj) => Equals((obj as IRemote)!);
1717
public bool Equals(IRemote other) => equalityHelper.Equals(this, other);
1818
public override int GetHashCode() => equalityHelper.GetHashCode(this);
19-
public virtual string Name => innerRemote.Name;
20-
public virtual string RefSpecs => string.Join(", ", innerRemote.FetchRefSpecs.Select(r => r.Specification));
19+
public string Name => innerRemote.Name;
20+
public string RefSpecs => string.Join(", ", innerRemote.FetchRefSpecs.Select(r => r.Specification));
2121
}
2222
}

‎src/GitVersion.LibGit2Sharp/Git/Tag.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
namespace GitVersion
55
{
6-
internal class Tag : ITag
6+
internal sealed class Tag : ITag
77
{
88
private static readonly LambdaEqualityHelper<ITag> equalityHelper = new(x => x.CanonicalName);
99
private static readonly LambdaKeyComparer<ITag, string> comparerHelper = new(x => x.CanonicalName);
@@ -15,9 +15,9 @@ internal class Tag : ITag
1515
public override bool Equals(object obj) => Equals((obj as ITag)!);
1616
public bool Equals(ITag other) => equalityHelper.Equals(this, other);
1717
public override int GetHashCode() => equalityHelper.GetHashCode(this);
18-
public virtual string CanonicalName => innerTag.CanonicalName;
19-
public virtual string TargetSha => innerTag.Target.Sha;
20-
public virtual string FriendlyName => innerTag.FriendlyName;
18+
public string CanonicalName => innerTag.CanonicalName;
19+
public string TargetSha => innerTag.Target.Sha;
20+
public string FriendlyName => innerTag.FriendlyName;
2121

2222
public ICommit? PeeledTargetCommit()
2323
{

0 commit comments

Comments
 (0)