cleanup for GitPreparer

Author: arturcic

src/GitVersion.App.Tests/ArgumentParserTests.cs

@@ -631,7 +631,7 @@ public void EnsureAssemblyInfoFalse()
     public void DynamicRepoLocation()
     {
         var arguments = this.argumentParser.ParseArguments("-dynamicRepoLocation c:\\foo\\");
-        arguments.DynamicRepositoryClonePath.ShouldBe("c:\\foo\\");
+        arguments.ClonePath.ShouldBe("c:\\foo\\");
     }
 
     [Test]

src/GitVersion.App.Tests/HelpWriterTests.cs

@@ -26,7 +26,7 @@ public void AllArgsAreInHelp()
             { nameof(Arguments.TargetBranch), "/b" },
             { nameof(Arguments.LogFilePath) , "/l" },
             { nameof(Arguments.OutputFile) , "/outputfile" },
-            { nameof(Arguments.DynamicRepositoryClonePath), "/dynamicRepoLocation" },
+            { nameof(Arguments.ClonePath), "/dynamicRepoLocation" },
             { nameof(Arguments.IsHelp), "/?" },
             { nameof(Arguments.IsVersion), "/version" },
             { nameof(Arguments.UpdateWixVersionFile), "/updatewixversionfile" },

src/GitVersion.App/ArgumentParser.cs

@@ -311,7 +311,7 @@ private static bool ParseRemoteArguments(Arguments arguments, string? name, IRea
         if (name.IsSwitch("dynamicRepoLocation"))
         {
             EnsureArgumentValueCount(values);
-            arguments.DynamicRepositoryClonePath = value;
+            arguments.ClonePath = value;
             return true;
         }
 

src/GitVersion.App/Arguments.cs

@@ -19,7 +19,7 @@ public class Arguments
     public string? TargetUrl;
     public string? TargetBranch;
     public string? CommitId;
-    public string? DynamicRepositoryClonePath;
+    public string? ClonePath;
 
     public bool Init;
     public bool Diag;
@@ -72,7 +72,7 @@ public GitVersionOptions ToOptions()
                 TargetUrl = TargetUrl,
                 TargetBranch = TargetBranch,
                 CommitId = CommitId,
-                DynamicRepositoryClonePath = DynamicRepositoryClonePath
+                ClonePath = ClonePath
             },
 
             Settings =

src/GitVersion.Core.Tests/Core/DynamicRepositoryTests.cs

@@ -61,7 +61,7 @@ public void FindsVersionInDynamicRepo(string name, string url, string targetBran
             RepositoryInfo =
             {
                 TargetUrl = url,
-                DynamicRepositoryClonePath = dynamicDirectory,
+                ClonePath = dynamicDirectory,
                 TargetBranch = targetBranch,
                 CommitId = commitId
             },

src/GitVersion.Core/Core/GitPreparer.cs

@@ -5,5 +5,5 @@ public class RepositoryInfo
     public string? TargetUrl;
     public string? TargetBranch;
     public string? CommitId;
-    public string? DynamicRepositoryClonePath;
+    public string? ClonePath;
 }

src/GitVersion.Core/Model/RepositoryInfo.cs

@@ -35,9 +35,9 @@ public GitRepositoryInfo(IOptions<GitVersionOptions> options)
         if (repositoryInfo.TargetUrl.IsNullOrWhiteSpace()) return null;
 
         var targetUrl = repositoryInfo.TargetUrl;
-        var dynamicRepositoryClonePath = repositoryInfo.DynamicRepositoryClonePath;
+        var clonePath = repositoryInfo.ClonePath;
 
-        var userTemp = dynamicRepositoryClonePath ?? Path.GetTempPath();
+        var userTemp = clonePath ?? Path.GetTempPath();
         var repositoryName = targetUrl.Split('/', '\\').Last().Replace(".git", string.Empty);
         var possiblePath = PathHelper.Combine(userTemp, repositoryName);