Remove protected constructor in EffectiveConfiguration class and integrate code review remarks.

Author: HHobeck

src/GitVersion.Core.Tests/Extensions/GitToolsTestingExtensions.cs

@@ -92,8 +92,7 @@ public static GitVersionVariables GetVersion(this RepositoryFixtureBase fixture,
 
             var semanticVersion = nextVersionCalculator.FindVersion();
 
-            var branchConfiguration = context.Configuration.GetBranchConfiguration(context.CurrentBranch);
-            EffectiveConfiguration effectiveConfiguration = new(context.Configuration, branchConfiguration);
+            var effectiveConfiguration = context.Configuration.GetEffectiveConfiguration(context.CurrentBranch.Name);
             return variableProvider.GetVariablesFor(semanticVersion, context.Configuration, effectiveConfiguration.PreReleaseWeight);
         }
         catch (Exception)