caches git objects

Uses lazy initialization to cache references and remotes.

Author: arturcic

src/GitVersion.LibGit2Sharp/Git/GitRepository.cs

@@ -65,23 +65,17 @@ public int UncommittedChangesCount()
 
     public Branch GetOrWrap(LibGit2Sharp.Branch innerBranch, Diff repoDiff)
     {
-        if (innerBranch.Tip is null)
-        {
-            return new Branch(innerBranch, repoDiff, this);
-        }
-
-        var cacheKey = $"{innerBranch.RemoteName}/{innerBranch.CanonicalName}@{innerBranch.Tip.Sha}";
+        var cacheKey = innerBranch.Tip is null
+            ? $"{innerBranch.RemoteName}/{innerBranch.CanonicalName}"
+            : $"{innerBranch.RemoteName}/{innerBranch.CanonicalName}@{innerBranch.Tip.Sha}";
         return cachedBranches.GetOrAdd(cacheKey, _ => new Branch(innerBranch, repoDiff, this));
     }
 
-    public Commit GetOrWrap(LibGit2Sharp.Commit innerCommit, Diff repoDiff) =>
-        cachedCommits.GetOrAdd(innerCommit.Sha, _ => new Commit(innerCommit, repoDiff, this));
+    public Commit GetOrWrap(LibGit2Sharp.Commit innerCommit, Diff repoDiff)
+        => cachedCommits.GetOrAdd(innerCommit.Sha, _ => new Commit(innerCommit, repoDiff, this));
 
     public Tag GetOrWrap(LibGit2Sharp.Tag innerTag, Diff repoDiff)
-    {
-        var cacheKey = $"{innerTag.CanonicalName}@{innerTag.Target.Sha}";
-        return cachedTags.GetOrAdd(cacheKey, _ => new Tag(innerTag, repoDiff, this));
-    }
+        => cachedTags.GetOrAdd(innerTag.CanonicalName, _ => new Tag(innerTag, repoDiff, this));
 
     public void Dispose()
     {

src/GitVersion.LibGit2Sharp/Git/ReferenceCollection.cs

@@ -5,25 +5,22 @@ namespace GitVersion.Git;
 internal sealed class ReferenceCollection : IReferenceCollection
 {
     private readonly LibGit2Sharp.ReferenceCollection innerCollection;
-    private IReadOnlyCollection<IReference>? references;
+    private readonly Lazy<IReadOnlyCollection<IReference>> references;
 
-    internal ReferenceCollection(LibGit2Sharp.ReferenceCollection collection) => this.innerCollection = collection.NotNull();
-
-    public IEnumerator<IReference> GetEnumerator()
+    internal ReferenceCollection(LibGit2Sharp.ReferenceCollection collection)
     {
-        this.references ??= [.. this.innerCollection.Select(reference => new Reference(reference))];
-        return this.references.GetEnumerator();
+        this.innerCollection = collection.NotNull();
+        this.references = new Lazy<IReadOnlyCollection<IReference>>(() => [.. this.innerCollection.Select(reference => new Reference(reference))]);
     }
 
+    public IEnumerator<IReference> GetEnumerator() => this.references.Value.GetEnumerator();
+
     IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
 
     public void Add(string name, string canonicalRefNameOrObject, bool allowOverwrite = false) => this.innerCollection.Add(name, canonicalRefNameOrObject, allowOverwrite);
 
     public void UpdateTarget(IReference directRef, IObjectId targetId)
-    {
-        RepositoryExtensions.RunSafe(() => this.innerCollection.UpdateTarget((Reference)directRef, (ObjectId)targetId));
-        this.references = null;
-    }
+        => RepositoryExtensions.RunSafe(() => this.innerCollection.UpdateTarget((Reference)directRef, (ObjectId)targetId));
 
     public IReference? this[string name]
     {

src/GitVersion.LibGit2Sharp/Git/RemoteCollection.cs

@@ -5,16 +5,16 @@ namespace GitVersion.Git;
 internal sealed class RemoteCollection : IRemoteCollection
 {
     private readonly LibGit2Sharp.RemoteCollection innerCollection;
-    private IReadOnlyCollection<IRemote>? remotes;
+    private readonly Lazy<IReadOnlyCollection<IRemote>> remotes;
 
-    internal RemoteCollection(LibGit2Sharp.RemoteCollection collection) => this.innerCollection = collection.NotNull();
-
-    public IEnumerator<IRemote> GetEnumerator()
+    internal RemoteCollection(LibGit2Sharp.RemoteCollection collection)
     {
-        this.remotes ??= [.. this.innerCollection.Select(reference => new Remote(reference))];
-        return this.remotes.GetEnumerator();
+        this.innerCollection = collection.NotNull();
+        this.remotes = new Lazy<IReadOnlyCollection<IRemote>>(() => [.. this.innerCollection.Select(reference => new Remote(reference))]);
     }
 
+    public IEnumerator<IRemote> GetEnumerator() => this.remotes.Value.GetEnumerator();
+
     IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
 
     public IRemote? this[string name]
@@ -27,14 +27,8 @@ public IRemote? this[string name]
     }
 
     public void Remove(string remoteName)
-    {
-        this.innerCollection.Remove(remoteName);
-        this.remotes = null;
-    }
+        => this.innerCollection.Remove(remoteName);
 
     public void Update(string remoteName, string refSpec)
-    {
-        this.innerCollection.Update(remoteName, r => r.FetchRefSpecs.Add(refSpec));
-        this.remotes = null;
-    }
+        => this.innerCollection.Update(remoteName, r => r.FetchRefSpecs.Add(refSpec));
 }