(build) remove workaround for .netcoreapp 3.1 tests

Author: arturcic

build/build/Tasks/Test/UnitTest.cs

@@ -88,11 +88,6 @@ private static void TestProjectForTarget(BuildContext context, FilePath project,
             Exclude = new List<string> { "[GitVersion*.Tests]*", "[GitTools.Testing]*" }
         };
 
-        if (string.Equals(framework, Constants.CoreFxVersion31))
-        {
-            // settings.Filter = $"TestCategory!={Constants.NoNetCoreApp31}";
-        }
-
         if (string.Equals(framework, Constants.FullFxVersion48))
         {
             settings.Filter = context.IsRunningOnUnix() ? $"TestCategory!={Constants.NoMono}" : $"TestCategory!={Constants.NoNet48}";

build/common/Utilities/Constants.cs

@@ -16,7 +16,6 @@ public class Constants
 
     public const string NoMono = "NoMono";
     public const string NoNet48 = "NoNet48";
-    public const string NoNetCoreApp31 = "NoNetCoreApp31";
 
     public static readonly string[] VersionsToBuild = { Version60, Version50, Version31 };
     public static readonly Architecture[] ArchToBuild = { Architecture.Amd64, Architecture.Arm64 };

src/GitVersion.Core.Tests/Helpers/TestBase.cs

@@ -11,7 +11,6 @@ public class TestBase
     protected const string NoMonoDescription = "Won't run on Mono due to source information not being available for ShouldMatchApproved.";
     protected const string NoMono = "NoMono";
     protected const string NoNet48 = "NoNet48";
-    protected const string NoNetCoreApp31 = "NoNetCoreApp31";
     public const string MainBranch = "main";
 
     protected static IServiceProvider ConfigureServices(Action<IServiceCollection> overrideServices = null)

src/GitVersion.MsBuild.Tests/Tasks/GenerateGitVersionInformationTest.cs

@@ -50,7 +50,6 @@ public void GenerateGitVersionInformationTaskShouldCreateFileInBuildServer()
     }
 
     [Test]
-    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuild()
@@ -78,7 +77,6 @@ public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuild(
     }
 
     [Test]
-    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuildInBuildServer()

src/GitVersion.MsBuild.Tests/Tasks/GetVersionTaskTests.cs

@@ -61,7 +61,6 @@ public void GetVersionTaskShouldReturnVersionOutputVariablesForBuildServer()
     [TestCase(nameof(VersionVariables.Patch), "4")]
     [TestCase(nameof(VersionVariables.MajorMinorPatch), "1.2.4")]
     [TestCase(nameof(VersionVariables.FullSemVer), "1.2.4+1")]
-    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void GetVersionTaskShouldReturnVersionOutputVariablesWhenRunWithMsBuild(string outputProperty, string version)
@@ -83,7 +82,6 @@ public void GetVersionTaskShouldReturnVersionOutputVariablesWhenRunWithMsBuild(s
     [TestCase(nameof(VersionVariables.Patch), "1")]
     [TestCase(nameof(VersionVariables.MajorMinorPatch), "1.0.1")]
     [TestCase(nameof(VersionVariables.FullSemVer), "1.0.1+1")]
-    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void GetVersionTaskShouldReturnVersionOutputVariablesWhenRunWithMsBuildInBuildServer(string outputProperty, string version)

src/GitVersion.MsBuild.Tests/Tasks/UpdateAssemblyInfoTaskTest.cs

@@ -41,7 +41,6 @@ public void UpdateAssemblyInfoTaskShouldCreateFileInBuildServer()
     }
 
     [Test]
-    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void UpdateAssemblyInfoTaskShouldCreateFileWhenRunWithMsBuild()
@@ -65,7 +64,6 @@ public void UpdateAssemblyInfoTaskShouldCreateFileWhenRunWithMsBuild()
     }
 
     [Test]
-    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void UpdateAssemblyInfoTaskShouldCreateFileWhenRunWithMsBuildInBuildServer()

src/GitVersion.MsBuild.Tests/Tasks/WriteVersionInfoTest.cs

@@ -80,7 +80,6 @@ public void WriteVersionInfoTaskShouldUpdateBuildNumberInAzurePipeline(string bu
 
 
     [Test]
-    [Category(NoNetCoreApp31)]
     public void WriteVersionInfoTaskShouldLogOutputVariablesToBuildOutputInGitHubActions()
     {
         var task = new WriteVersionInfoToBuildLog();
@@ -94,7 +93,6 @@ public void WriteVersionInfoTaskShouldLogOutputVariablesToBuildOutputInGitHubAct
     }
 
     [Test]
-    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void WriteVersionInfoTaskShouldNotLogOutputVariablesToBuildOutputWhenRunWithMsBuild()
@@ -112,7 +110,6 @@ public void WriteVersionInfoTaskShouldNotLogOutputVariablesToBuildOutputWhenRunW
     }
 
     [Test]
-    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void WriteVersionInfoTaskShouldLogOutputVariablesToBuildOutputWhenRunWithMsBuildInAzurePipeline()