Fix ShouldFilterVersion unit test

Author: HHobeck

src/GitVersion.Core.Tests/VersionCalculation/NextVersionCalculatorTests.cs

@@ -477,11 +477,11 @@ private record TestIgnoreConfig : IgnoreConfiguration
     {
         private readonly IVersionFilter filter;
 
-        public virtual bool IsEmpty => false;
+        public override bool IsEmpty => false;
 
         public TestIgnoreConfig(IVersionFilter filter) => this.filter = filter;
 
-        public virtual IEnumerable<IVersionFilter> ToFilters()
+        public override IEnumerable<IVersionFilter> ToFilters()
         {
             yield return this.filter;
         }

src/GitVersion.Core/Configuration/IIgnoreConfiguration.cs

@@ -8,12 +8,8 @@ public interface IIgnoreConfiguration
 
         IReadOnlyList<string> Shas { get; }
 
-        public IEnumerable<IVersionFilter> ToFilters()
-        {
-            if (Shas.Any()) yield return new ShaVersionFilter(Shas);
-            if (Before.HasValue) yield return new MinDateVersionFilter(Before.Value);
-        }
+        IEnumerable<IVersionFilter> ToFilters();
 
-        public bool IsEmpty => Before == null && !Shas.Any();
+        bool IsEmpty { get; }
     }
 }

src/GitVersion.Core/Configuration/IgnoreConfiguration.cs

@@ -1,7 +1,9 @@
 using GitVersion.Attributes;
+using GitVersion.VersionCalculation;
 
 namespace GitVersion.Configuration;
 
+
 public record IgnoreConfiguration : IIgnoreConfiguration
 {
     [JsonPropertyName("commits-before")]
@@ -15,4 +17,14 @@ public record IgnoreConfiguration : IIgnoreConfiguration
     [JsonPropertyName("sha")]
     [JsonPropertyDescription("A sequence of SHAs to be excluded from the version calculations.")]
     public List<string> Shas { get; init; } = new();
+
+    [JsonIgnore]
+    public virtual bool IsEmpty => Before == null && !Shas.Any();
+
+    public virtual IEnumerable<IVersionFilter> ToFilters()
+    {
+        if (Shas.Any()) yield return new ShaVersionFilter(Shas);
+        if (Before.HasValue) yield return new MinDateVersionFilter(Before.Value);
+    }
+
 }

src/GitVersion.Core/PublicAPI.Unshipped.txt

@@ -1224,6 +1224,8 @@ virtual GitVersion.Configuration.BranchConfigurationBuilder.WithTrackMergeMessag
 virtual GitVersion.Configuration.BranchConfigurationBuilder.WithTrackMergeTarget(bool? value) -> GitVersion.Configuration.BranchConfigurationBuilder!
 virtual GitVersion.Configuration.BranchConfigurationBuilder.WithTracksReleaseBranches(bool? value) -> GitVersion.Configuration.BranchConfigurationBuilder!
 virtual GitVersion.Configuration.BranchConfigurationBuilder.WithVersioningMode(GitVersion.VersionCalculation.VersioningMode? value) -> GitVersion.Configuration.BranchConfigurationBuilder!
+virtual GitVersion.Configuration.IgnoreConfiguration.IsEmpty.get -> bool
+virtual GitVersion.Configuration.IgnoreConfiguration.ToFilters() -> System.Collections.Generic.IEnumerable<GitVersion.VersionCalculation.IVersionFilter!>!
 virtual GitVersion.VersionCalculation.EffectiveBranchConfigurationFinder.GetConfigurations(GitVersion.IBranch! branch, GitVersion.Configuration.IGitVersionConfiguration! configuration) -> System.Collections.Generic.IEnumerable<GitVersion.Configuration.EffectiveBranchConfiguration!>!
 virtual GitVersion.VersionCalculation.FallbackVersionStrategy.GetBaseVersions(GitVersion.Configuration.EffectiveBranchConfiguration! configuration) -> System.Collections.Generic.IEnumerable<GitVersion.VersionCalculation.BaseVersion!>!
 virtual GitVersion.VersionCalculation.NextVersionCalculator.FindVersion() -> GitVersion.VersionCalculation.NextVersion!