(build) cleaning up credentials

Author: arturcic

.github/workflows/docs.yml

@@ -13,8 +13,8 @@ jobs:
   build:
     runs-on: ubuntu-latest
     env:
+      GITHUB_USERNAME: ${{ github.repository_owner }}
       GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      GITHUB_USERNAME: ${{ secrets.GITHUB_USERNAME }}
     steps:
     -
       name: Checkout

build/artifacts/Tasks/ArtifactsMsBuildFullTest.cs

@@ -6,7 +6,6 @@
 using Cake.Common.Tools.MSBuild;
 using Cake.Core;
 using Cake.Core.Diagnostics;
-using Cake.Core.IO;
 using Cake.Frosting;
 using Common.Utilities;
 

build/common/Utilities/Models.cs

@@ -9,10 +9,6 @@ public record CodeCovCredentials(string Token);
 
     public record GitHubCredentials(string UserName, string Token);
 
-    public record GitterCredentials(string Token, string RoomId);
-
-    public record DockerCredentials(string UserName, string Password);
-
     public record NugetCredentials(string ApiKey, string ApiUrl);
 
     public record ChocolateyCredentials(string ApiKey, string ApiUrl);

build/docker/BuildContext.cs

@@ -1,15 +1,13 @@
 using System.Collections.Generic;
 using Cake.Core;
 using Common.Utilities;
-using Docker.Utilities;
 
 namespace Docker
 {
     public class BuildContext : BuildContextBase
     {
         public bool IsDockerOnLinux { get; set; }
 
-        public Credentials? Credentials { get; set; }
         public IEnumerable<DockerImage> Images { get; set; } = new List<DockerImage>();
 
         public BuildContext(ICakeContext context) : base(context)

build/docker/BuildLifetime.cs

@@ -3,7 +3,6 @@
 using Cake.Common.Diagnostics;
 using Cake.Docker;
 using Common.Utilities;
-using Docker.Utilities;
 using Constants = Common.Utilities.Constants;
 
 namespace Docker
@@ -29,7 +28,6 @@ from distro in distros
                              select new DockerImage(distro, version, registry, false);
 
             context.StartGroup("Build Setup");
-            context.Credentials = Credentials.GetCredentials(context, dockerRegistry);
 
             LogBuildInformation(context);
 

build/docker/Tasks/DockerBuild.cs

@@ -1,5 +1,4 @@
 using Cake.Common.IO;
-using Cake.Core.IO;
 using Cake.Frosting;
 using Common.Utilities;
 

build/docker/Tasks/DockerPublish.cs

@@ -1,4 +1,3 @@
-using System;
 using Cake.Frosting;
 using Common.Utilities;
 
@@ -37,18 +36,6 @@ public override bool ShouldRun(BuildContext context)
 
         public override void Run(BuildContext context)
         {
-            var username = context.Credentials?.Docker?.UserName;
-            if (string.IsNullOrEmpty(username))
-            {
-                throw new InvalidOperationException("Could not resolve Docker user name.");
-            }
-
-            var password = context.Credentials?.Docker?.Password;
-            if (string.IsNullOrEmpty(password))
-            {
-                throw new InvalidOperationException("Could not resolve Docker password.");
-            }
-
             foreach (var dockerImage in context.Images)
             {
                 context.DockerPush(dockerImage);

build/docker/Utilities/Credentials.cs

@@ -4,6 +4,6 @@
         <RootNamespace>Docker</RootNamespace>
     </PropertyGroup>
     <ItemGroup>
-        <ProjectReference Include="..\common\common.csproj"/>
+        <ProjectReference Include="..\common\common.csproj" />
     </ItemGroup>
 </Project>

build/docker/docker.csproj

@@ -7,16 +7,11 @@ namespace Publish.Utilities
     public class Credentials
     {
         public GitHubCredentials? GitHub { get; private set; }
-        public GitterCredentials? Gitter { get; private set; }
         public NugetCredentials? Nuget { get; private set; }
         public ChocolateyCredentials? Chocolatey { get; private set; }
 
         public static Credentials GetCredentials(ICakeContext context) => new()
         {
-            Gitter = new GitterCredentials(
-                context.EnvironmentVariable("GITTER_TOKEN"),
-                context.EnvironmentVariable("GITTER_ROOM_ID")),
-
             GitHub = new GitHubCredentials(
                 context.EnvironmentVariable("GITHUB_USERNAME"),
                 context.EnvironmentVariable("GITHUB_TOKEN")),