wip

Author: arturcic

.editorconfig

@@ -154,13 +154,13 @@ csharp_space_between_method_declaration_name_and_open_parenthesis = false
 csharp_space_between_method_declaration_parameter_list_parentheses = false
 csharp_space_between_square_brackets = false
 
-csharp_use_roslyn_logic_for_evident_types = true
+resharper_csharp_use_roslyn_logic_for_evident_types = true
 
 # Alignment
-align_multiline_parameter = true
+resharper_csharp_align_multiline_parameter = true
 
 # Qualify fields with "this."
-csharp_instance_members_qualify_members = field
+resharper_csharp_instance_members_qualify_members = field
 
 # IDE0011: Add braces
 dotnet_diagnostic.IDE0011.severity = none
@@ -197,4 +197,8 @@ dotnet_diagnostic.RCS1036.severity = error
 
 xml_space_before_self_closing = true
 
-resharper_arrange_object_creation_when_type_not_evident_highlighting = none
+resharper_arrange_object_creation_when_type_not_evident_highlighting = none
+
+resharper_unused_auto_property_accessor_global_highlighting = none
+
+resharper_unused_method_return_value_global_highlighting = none

src/GitVersion.App.Tests/HelpWriterTests.cs

@@ -51,7 +51,7 @@ public void AllArgsAreInHelp()
             .ShouldBeEmpty();
     }
 
-    private static bool IsNotInHelp(IReadOnlyDictionary<string, string> lookup, string propertyName, string helpText)
+    private static bool IsNotInHelp(Dictionary<string, string> lookup, string propertyName, string helpText)
     {
         if (lookup.TryGetValue(propertyName, out var value))
             return !helpText.Contains(value);

src/GitVersion.App.Tests/Helpers/ProgramFixture.cs

@@ -7,7 +7,7 @@ namespace GitVersion.App.Tests;
 
 public sealed class ProgramFixture
 {
-    private readonly IEnvironment environment;
+    private readonly TestEnvironment environment;
     private List<Action<IServiceCollection>> Overrides { get; } = [];
     private readonly Lazy<string> logger;
     private readonly Lazy<string?> output;
@@ -49,7 +49,7 @@ public void WithEnv(params KeyValuePair<string, string>[] envs)
 
     public Task<ExecutionResults> Run(string arg)
     {
-        var args = arg.Split([' '], StringSplitOptions.RemoveEmptyEntries).ToArray();
+        var args = arg.Split([' '], StringSplitOptions.RemoveEmptyEntries);
         return Run(args);
     }
 

src/GitVersion.App/ArgumentParser.cs

@@ -562,14 +562,14 @@ private static void EnsureArgumentValueCount(IReadOnlyList<string>? values)
         }
     }
 
-    private static NameValueCollection CollectSwitchesAndValuesFromArguments(IList<string> namedArguments, out bool firstArgumentIsSwitch)
+    private static NameValueCollection CollectSwitchesAndValuesFromArguments(string[] namedArguments, out bool firstArgumentIsSwitch)
     {
         firstArgumentIsSwitch = true;
         var switchesAndValues = new NameValueCollection();
         string? currentKey = null;
         var argumentRequiresValue = false;
 
-        for (var i = 0; i < namedArguments.Count; ++i)
+        for (var i = 0; i < namedArguments.Length; ++i)
         {
             var arg = namedArguments[i];
 

src/GitVersion.BuildAgents/Agents/MyGet.cs

@@ -28,7 +28,7 @@ public override string[] SetOutputVariables(string name, string? value)
         return [.. messages];
     }
 
-    public override string? SetBuildNumber(GitVersionVariables variables) =>
+    public override string SetBuildNumber(GitVersionVariables variables) =>
         $"##myget[buildNumber '{ServiceMessageEscapeHelper.EscapeValue(variables.FullSemVer)}']";
 
     public override bool PreventFetch() => false;

src/GitVersion.Configuration/ConfigurationProvider.cs

@@ -73,7 +73,7 @@ private IGitVersionConfiguration ProvideConfiguration(string? configFile,
         }
     }
 
-    private IReadOnlyDictionary<object, object?>? ReadOverrideConfiguration(string? configFilePath)
+    private Dictionary<object, object?>? ReadOverrideConfiguration(string? configFilePath)
     {
         if (configFilePath == null)
         {

src/GitVersion.Core.Tests/DocumentationTests.cs

@@ -9,7 +9,7 @@ namespace GitVersion.Core.Tests;
 [TestFixture]
 public class DocumentationTests : TestBase
 {
-    private IFileSystem fileSystem;
+    private FileSystem fileSystem;
     private IDirectoryInfo docsDirectory;
 
     [OneTimeSetUp]

src/GitVersion.Core.Tests/Extensions/GitRepositoryTestingExtensions.cs

@@ -165,7 +165,7 @@ internal static IGitRepository ToGitRepository(this IRepository repository)
         return gitRepository;
     }
 
-    private static IServiceProvider ConfigureServices(Action<IServiceCollection>? servicesOverrides = null)
+    private static ServiceProvider ConfigureServices(Action<IServiceCollection>? servicesOverrides = null)
     {
         var services = new ServiceCollection()
             .AddModule(new GitVersionCoreTestModule());

src/GitVersion.Core.Tests/Extensions/StringFormatWithExtensionTests.cs

@@ -6,7 +6,7 @@ namespace GitVersion.Core.Tests;
 [TestFixture]
 public class StringFormatWithExtensionTests
 {
-    private IEnvironment environment;
+    private TestEnvironment environment;
 
     [SetUp]
     public void Setup() => this.environment = new TestEnvironment();

src/GitVersion.Core.Tests/Helpers/GitVersionContextBuilder.cs

@@ -84,7 +84,7 @@ private static IGitRepository CreateRepository()
         return mockRepository;
     }
 
-    private static IServiceProvider ConfigureServices(Action<IServiceCollection>? overrideServices = null)
+    private static ServiceProvider ConfigureServices(Action<IServiceCollection>? overrideServices = null)
     {
         var services = new ServiceCollection()
             .AddModule(new GitVersionCoreTestModule());