Temporary tests removed

Author: Furkan Küçük

src/GitVersion.Configuration.Tests/Configuration/ConfigurationFileLocatorTests.cs

@@ -188,55 +188,6 @@ public void ReturnConfigurationFilePathIfCustomConfigurationIsSet()
             config.ShouldBe(Path.GetFullPath("Configuration/CustomConfig.yaml"));
         }
 
-        [Test]
-        public void ReturnConfigurationFilePathIfCustomConfigurationIsSet_PerformanceComparison()
-        {
-            this.workingPath = this.repoPath;
-
-            this.gitVersionOptions = new() { ConfigurationInfo = { ConfigurationFile = Path.Combine(this.workingPath, "Configuration", "CustomConfig.yaml") } };
-
-            var serviceProvider = GetServiceProvider(this.gitVersionOptions);
-            this.fileSystem = serviceProvider.GetRequiredService<IFileSystem>();
-
-            using var _ = this.fileSystem.SetupConfigFile(
-                path: Path.Combine(this.workingPath, "Configuration"), fileName: "CustomConfig2.yaml"
-            );
-            this.configFileLocator = serviceProvider.GetRequiredService<IConfigurationFileLocator>();
-            Stopwatch stopwatch = new();
-            stopwatch.Start();
-            var config = this.configFileLocator.GetConfigurationFile(this.workingPath);
-            stopwatch.Stop();
-            long et1 = stopwatch.ElapsedTicks;
-
-            stopwatch.Reset();
-            stopwatch.Start();
-            config = this.configFileLocator.GetConfigurationFileTemp(this.workingPath);
-            stopwatch.Stop();
-            long et2 = stopwatch.ElapsedTicks;
-
-            //et1.ShouldBeLessThan(et2);
-
-            stopwatch.Reset();
-            stopwatch.Start();
-            for (int i = 0; i < 1000000; i++)
-            {
-                config = this.configFileLocator.GetConfigurationFile(this.workingPath);
-            }
-            stopwatch.Stop();
-            long et3 = stopwatch.ElapsedMilliseconds;
-
-            stopwatch.Reset();
-            stopwatch.Start();
-            for (int i = 0; i < 1000000; i++)
-            {
-                config = this.configFileLocator.GetConfigurationFileTemp(this.workingPath);
-            }
-            stopwatch.Stop();
-            long et4 = stopwatch.ElapsedMilliseconds;
-
-            et3.ShouldBeLessThan(et4);
-        }
-
         [TestCase(null)]
         [TestCase("")]
         [TestCase(" ")]

src/GitVersion.Configuration/ConfigurationFileLocator.cs

@@ -47,90 +47,14 @@ public void Verify(string? workingDirectory, string? projectRootDirectory)
         {
             this.log.Debug($"Trying to find configuration file {item} at '{directoryPath}'");
 
-            var configurationFilePath = item;
-            if (!PathHelper.IsPathRooted(configurationFilePath))
+            string configurationFilePath;
+            if (!PathHelper.IsPathRooted(item))
             {
                 if (string.IsNullOrEmpty(directoryPath))
                 {
-                    throw new WarningException(
-                        $"The configuration file '{configurationFilePath}' is relative and no directory path known."
-                    );
-                }
-                configurationFilePath = Path.Combine(directoryPath, configurationFilePath);
-            }
-
-            if (fileSystem.File.Exists(configurationFilePath))
-            {
-                this.log.Info($"Found configuration file at '{configurationFilePath}'");
-                return configurationFilePath;
-            }
-
-            this.log.Debug($"Configuration file {configurationFilePath} not found at '{directoryPath}'");
-        }
-
-        return null;
-    }
-
-    public string? GetConfigurationFileTemp(string? directoryPath)
-    {
-        // If configuration file overriden and its exists, return it
-        if (!string.IsNullOrWhiteSpace(this.ConfigurationFile) &&
-            PathHelper.IsPathRooted(this.ConfigurationFile) &&
-            fileSystem.File.Exists(this.ConfigurationFile))
-        {
-            return this.ConfigurationFile;
-        }
-
-        if (directoryPath is null) return null;
-
-        string[] candidates = !string.IsNullOrWhiteSpace(this.ConfigurationFile)
-            ? [this.ConfigurationFile, .. this.SupportedConfigFileNames]
-            : this.SupportedConfigFileNames;
-
-        foreach (var fileName in candidates)
-        {
-            this.log.Debug($"Trying to find configuration file {fileName} at '{directoryPath}'");
-            if (directoryPath != null && fileSystem.Directory.Exists(directoryPath))
-            {
-                var files = fileSystem.Directory.GetFiles(directoryPath);
-
-                var matchingFile = files.FirstOrDefault(file =>
-                    string.Equals(fileSystem.Path.GetFileName(file), fileName, StringComparison.OrdinalIgnoreCase));
-
-                if (matchingFile != null)
-                {
-                    this.log.Info($"Found configuration file at '{matchingFile}'");
-                    return matchingFile;
+                    this.log.Info($"The configuration file '{item}' is relative and no directory path known.");
+                    continue;
                 }
-            }
-
-            this.log.Debug($"Configuration file {fileName} not found at '{directoryPath}'");
-        }
-
-        return null;
-    }
-
-    public string? GetConfigurationFileCombined(string? directoryPath)
-    {
-        if (!string.IsNullOrWhiteSpace(this.ConfigurationFile) &&
-            PathHelper.IsPathRooted(this.ConfigurationFile) &&
-            fileSystem.File.Exists(this.ConfigurationFile))
-        {
-            return this.ConfigurationFile;
-        }
-
-        if (directoryPath is null) return null;
-
-        string[] configurationFilePaths = string.IsNullOrWhiteSpace(this.ConfigurationFile)
-        ? this.SupportedConfigFileNames : [this.ConfigurationFile, .. this.SupportedConfigFileNames];
-
-        foreach (var item in configurationFilePaths)
-        {
-            this.log.Debug($"Trying to find configuration file {item} at '{directoryPath}'");
-
-            string configurationFilePath;
-            if (!PathHelper.IsPathRooted(item))
-            {
                 configurationFilePath = Path.Combine(directoryPath, item);
             }
             else

src/GitVersion.Core/Configuration/IConfigurationFileLocator.cs

@@ -4,5 +4,4 @@ public interface IConfigurationFileLocator
 {
     void Verify(string? workingDirectory, string? projectRootDirectory);
     string? GetConfigurationFile(string? directoryPath);
-    string? GetConfigurationFileTemp(string? directoryPath);
 }

src/GitVersion.Core/PublicAPI.Shipped.txt

@@ -114,7 +114,6 @@ GitVersion.Configuration.IConfigurationBuilder.AddOverride(System.Collections.Ge
 GitVersion.Configuration.IConfigurationBuilder.Build() -> GitVersion.Configuration.IGitVersionConfiguration!
 GitVersion.Configuration.IConfigurationFileLocator
 GitVersion.Configuration.IConfigurationFileLocator.GetConfigurationFile(string? directoryPath) -> string?
-GitVersion.Configuration.IConfigurationFileLocator.GetConfigurationFileTemp(string? directoryPath) -> string?
 GitVersion.Configuration.IConfigurationFileLocator.Verify(string? workingDirectory, string? projectRootDirectory) -> void
 GitVersion.Configuration.IConfigurationProvider
 GitVersion.Configuration.IConfigurationProvider.Provide(System.Collections.Generic.IReadOnlyDictionary<object!, object?>? overrideConfiguration = null) -> GitVersion.Configuration.IGitVersionConfiguration!