Skip to content

Commit c2a7981

Browse files
committed
better use of when
1 parent f58a509 commit c2a7981

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

GitVersionCore.Tests/LastVersionOnMasterFinderTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ static void EnsureMetaDataMatch(CommitCountingRepoFixture fixture, string branch
8585

8686
var commit = referenceCommitFinder(fixture.Repository);
8787
var releaseDate = LastVersionOnMasterFinder.Execute(fixture.Repository, commit);
88-
releaseDate.ShouldBe(commit.Committer.When);
88+
releaseDate.ShouldBe(commit.When());
8989
}
9090

9191
void DropTags(IRepository repo, params string[] names)

GitVersionCore/GitFlow/BranchFinders/DevelopBasedVersionFinderBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ protected SemanticVersion FindVersion(
1818
}
1919

2020
var versionOnMasterFinder = new VersionOnMasterFinder();
21-
var versionFromMaster = versionOnMasterFinder.Execute(context, context.CurrentCommit.Committer.When);
21+
var versionFromMaster = versionOnMasterFinder.Execute(context, context.CurrentCommit.When());
2222

2323
var numberOfCommitsOnBranchSinceCommit = NumberOfCommitsOnBranchSinceCommit(context, ancestor);
2424
var preReleaseTag = context.CurrentBranch.Name

GitVersionCore/GitHubFlow/LastTaggedReleaseFinder.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ VersionTaggedCommit GetVersion(GitVersionContext context)
3131
})
3232
.Where(a => a != null)
3333
.ToArray();
34-
var olderThan = context.CurrentCommit.Committer.When;
34+
var olderThan = context.CurrentCommit.When();
3535
var lastTaggedCommit =
36-
context.CurrentBranch.Commits.FirstOrDefault(c => c.Committer.When <= olderThan && tags.Any(a => a.Commit == c));
36+
context.CurrentBranch.Commits.FirstOrDefault(c => c.When() <= olderThan && tags.Any(a => a.Commit == c));
3737

3838
if (lastTaggedCommit != null)
3939
return tags.Last(a => a.Commit.Sha == lastTaggedCommit.Sha);

0 commit comments

Comments
 (0)