Skip to content

Commit c2d1080

Browse files
authored
Merge branch 'master' into bugfix/targets
2 parents 10748ec + 409a287 commit c2d1080

20 files changed

+391
-156
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
---
2+
name: Bug report
3+
about: Create a report to help us improve
4+
title: "[Bug]"
5+
labels: bug
6+
assignees: ''
7+
8+
---
9+
10+
**Describe the bug**
11+
A clear and concise description of what the bug is.
12+
13+
## Expected Behavior
14+
<!-- Tell us what you believe should happen -->
15+
16+
## Actual Behavior
17+
<!-- Tell us what is happening -->
18+
19+
## Possible Fix
20+
<!-- Not obligatory, but suggest a fix or reason for the bug -->
21+
22+
## Steps to Reproduce
23+
<!-- Provide a link to a live example, or an unambiguous set of steps to -->
24+
<!-- reproduce this bug. Include code to reproduce, if relevant -->
25+
26+
## Context
27+
<!-- How has this bug affected you? What were you trying to accomplish? -->
28+
29+
## Your Environment
30+
<!-- Include as many relevant details about the environment -->
31+
<!-- you experienced the bug in -->
32+
33+
- Version Used:
34+
- Operating System and version (Windows 10, Ubuntu 18.04):
35+
- Link to your project:
36+
- Link to your CI build (if appropriate):

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
blank_issues_enabled: false
2+
contact_links:
3+
- name: Gitter Community Chat
4+
url: https://gitter.im/GitTools/GitVersion
5+
about: Please ask and answer questions here.
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
name: Documentation
3+
about: Describe this issue template's purpose here.
4+
title: "[Docs]"
5+
labels: documentation
6+
assignees: ''
7+
8+
---
9+
10+
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
---
2+
name: Failing test
3+
about: Describe this issue template's purpose here.
4+
title: "[Failing test]"
5+
labels: failing test case
6+
assignees: ''
7+
8+
---
9+
10+
**Describe the bug**
11+
A clear and concise description of what the bug is or a link to it
12+
13+
## Test code
14+
```
15+
using var fixture = new EmptyRepositoryFixture();
16+
fixture.Repository.MakeACommit();
17+
fixture.BranchTo("develop");
18+
fixture.Repository.MakeCommits(3);
19+
20+
fixture.AssertFullSemver("0.1.0-alpha.1");
21+
```
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
---
2+
name: Feature request
3+
about: Suggest an idea for this project
4+
title: "[Feature]"
5+
labels: feature
6+
assignees: ''
7+
8+
---
9+
10+
**Is your feature request related to a problem? Please describe.**
11+
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
12+
13+
## Detailed Description
14+
<!--- Provide a detailed description of the change or addition you are proposing -->
15+
16+
## Context
17+
<!--- Why is this change important to you? How would you use it? -->
18+
<!--- How can it benefit other users? -->
19+
20+
## Possible Implementation
21+
<!--- Not obligatory, but suggest an idea for implementing addition or change -->
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
---
2+
name: Improvement request
3+
about: Describe this issue template's purpose here.
4+
title: "[Improvement]"
5+
labels: improvement
6+
assignees: ''
7+
8+
---
9+
10+
**Is your improvement request related to a problem? Please describe.**
11+
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
12+
13+
## Detailed Description
14+
<!--- Provide a detailed description of the change or addition you are proposing -->
15+
16+
## Context
17+
<!--- Why is this change important to you? How would you use it? -->
18+
<!--- How can it benefit other users? -->
19+
20+
## Possible Implementation
21+
<!--- Not obligatory, but suggest an idea for implementing addition or change -->

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
<!--- Provide a general summary of your changes in the Title above -->
2+
3+
## Description
4+
<!--- Describe your changes in detail -->
5+
6+
## Related Issue
7+
<!--- This project only accepts pull requests related to open issues -->
8+
<!--- If suggesting a new feature or change, please discuss it in an issue first -->
9+
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
10+
<!--- Please link to the issue here: -->
11+
12+
## Motivation and Context
13+
<!--- Why is this change required? What problem does it solve? -->
14+
15+
## How Has This Been Tested?
16+
<!--- Please describe in detail how you tested your changes. -->
17+
<!--- Include details of your testing environment, and the tests you ran to -->
18+
<!--- see how your change affects other areas of the code, etc. -->
19+
20+
## Screenshots (if appropriate):
21+
22+
## Checklist:
23+
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
24+
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
25+
26+
- [ ] My code follows the code style of this project.
27+
- [ ] My change requires a change to the documentation.
28+
- [ ] I have updated the documentation accordingly.
29+
- [ ] I have added tests to cover my changes.
30+
- [ ] All new and existing tests passed.

.github/workflows/release.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@ name: Release
22
on:
33
release:
44
types: [published]
5-
5+
push:
6+
tags:
7+
- '*'
8+
69
jobs:
710
callBuildFlow:
811
name: Trigger Build flow

src/GitVersionCore.Tests/BuildServers/AzurePipelinesTests.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ public void EscapeValues()
4949
{
5050
var vsVersion = buildServer.GenerateSetParameterMessage("Foo", "0.8.0-unstable568 Branch:'develop' Sha:'ee69bff1087ebc95c6b43aa2124bd58f5722e0cb'");
5151

52-
vsVersion[0].ShouldBe("##vso[task.setvariable variable=GitVersion.Foo;isOutput=true]0.8.0-unstable568 Branch:'develop' Sha:'ee69bff1087ebc95c6b43aa2124bd58f5722e0cb'");
52+
vsVersion.ShouldContain("##vso[task.setvariable variable=GitVersion.Foo]0.8.0-unstable568 Branch:'develop' Sha:'ee69bff1087ebc95c6b43aa2124bd58f5722e0cb'");
53+
vsVersion.ShouldContain("##vso[task.setvariable variable=GitVersion.Foo;isOutput=true]0.8.0-unstable568 Branch:'develop' Sha:'ee69bff1087ebc95c6b43aa2124bd58f5722e0cb'");
5354
}
5455

5556
[Test]

src/GitVersionCore.Tests/BuildServers/CodeBuildTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,14 @@ public void SetUp()
3333
[Test]
3434
public void CorrectlyIdentifiesCodeBuildPresence()
3535
{
36-
environment.SetEnvironmentVariable(CodeBuild.HeadRefEnvironmentName, "a value");
36+
environment.SetEnvironmentVariable(CodeBuild.EnvironmentVariableName, "a value");
3737
buildServer.CanApplyToCurrentContext().ShouldBe(true);
3838
}
3939

4040
[Test]
4141
public void PicksUpBranchNameFromEnvironment()
4242
{
43-
environment.SetEnvironmentVariable(CodeBuild.HeadRefEnvironmentName, "refs/heads/master");
43+
environment.SetEnvironmentVariable(CodeBuild.EnvironmentVariableName, "refs/heads/master");
4444
buildServer.GetCurrentBranch(false).ShouldBe("refs/heads/master");
4545
}
4646

0 commit comments

Comments
 (0)