use primary constructors - GitVersion.Configuration & GitVersion.LibGit2Sharp

Author: arturcic

src/GitVersion.BuildAgents.Tests/Agents/BuildServerBaseTests.cs

@@ -49,14 +49,10 @@ public void BuildNumberIsFullSemVer()
         writes.ShouldNotContain(x => x != null && x.StartsWith("Executing GenerateSetVersionMessage for "));
     }
 
-    private class BuildAgent : BuildAgentBase
+    private class BuildAgent(IEnvironment environment, ILog log) : BuildAgentBase(environment, log)
     {
         protected override string EnvironmentVariable => throw new NotImplementedException();
 
-        public BuildAgent(IEnvironment environment, ILog log) : base(environment, log)
-        {
-        }
-
         public override bool CanApplyToCurrentContext() => throw new NotImplementedException();
 
         public override string GenerateSetVersionMessage(GitVersionVariables variables) => variables.FullSemVer;

src/GitVersion.BuildAgents/Agents/AppVeyor.cs

@@ -4,12 +4,8 @@
 
 namespace GitVersion.Agents;
 
-internal class AppVeyor : BuildAgentBase
+internal class AppVeyor(IEnvironment environment, ILog log) : BuildAgentBase(environment, log)
 {
-    public AppVeyor(IEnvironment environment, ILog log) : base(environment, log)
-    {
-    }
-
     public const string EnvironmentVariableName = "APPVEYOR";
 
     protected override string EnvironmentVariable => EnvironmentVariableName;

src/GitVersion.BuildAgents/Agents/AzurePipelines.cs

@@ -5,12 +5,8 @@
 
 namespace GitVersion.Agents;
 
-internal class AzurePipelines : BuildAgentBase
+internal class AzurePipelines(IEnvironment environment, ILog log) : BuildAgentBase(environment, log)
 {
-    public AzurePipelines(IEnvironment environment, ILog log) : base(environment, log)
-    {
-    }
-
     public const string EnvironmentVariableName = "TF_BUILD";
 
     protected override string EnvironmentVariable => EnvironmentVariableName;

src/GitVersion.BuildAgents/Agents/BuildKite.cs

@@ -3,12 +3,8 @@
 
 namespace GitVersion.Agents;
 
-internal class BuildKite : BuildAgentBase
+internal class BuildKite(IEnvironment environment, ILog log) : BuildAgentBase(environment, log)
 {
-    public BuildKite(IEnvironment environment, ILog log) : base(environment, log)
-    {
-    }
-
     public const string EnvironmentVariableName = "BUILDKITE";
 
     protected override string EnvironmentVariable => EnvironmentVariableName;

src/GitVersion.BuildAgents/Agents/ContinuaCi.cs

@@ -3,12 +3,8 @@
 
 namespace GitVersion.Agents;
 
-internal class ContinuaCi : BuildAgentBase
+internal class ContinuaCi(IEnvironment environment, ILog log) : BuildAgentBase(environment, log)
 {
-    public ContinuaCi(IEnvironment environment, ILog log) : base(environment, log)
-    {
-    }
-
     public const string EnvironmentVariableName = "ContinuaCI.Version";
 
     protected override string EnvironmentVariable => EnvironmentVariableName;

src/GitVersion.BuildAgents/Agents/Drone.cs

@@ -4,12 +4,8 @@
 
 namespace GitVersion.Agents;
 
-internal class Drone : BuildAgentBase
+internal class Drone(IEnvironment environment, ILog log) : BuildAgentBase(environment, log)
 {
-    public Drone(IEnvironment environment, ILog log) : base(environment, log)
-    {
-    }
-
     public const string EnvironmentVariableName = "DRONE";
     protected override string EnvironmentVariable => EnvironmentVariableName;
     public override bool CanApplyToCurrentContext() => "true".Equals(Environment.GetEnvironmentVariable(EnvironmentVariable), StringComparison.OrdinalIgnoreCase);

src/GitVersion.BuildAgents/Agents/EnvRun.cs

@@ -4,12 +4,8 @@
 
 namespace GitVersion.Agents;
 
-internal class EnvRun : BuildAgentBase
+internal class EnvRun(IEnvironment environment, ILog log) : BuildAgentBase(environment, log)
 {
-    public EnvRun(IEnvironment environment, ILog log) : base(environment, log)
-    {
-    }
-
     public const string EnvironmentVariableName = "ENVRUN_DATABASE";
     protected override string EnvironmentVariable => EnvironmentVariableName;
     public override bool CanApplyToCurrentContext()

src/GitVersion.BuildAgents/Agents/GitHubActions.cs

@@ -4,14 +4,10 @@
 
 namespace GitVersion.Agents;
 
-internal class GitHubActions : BuildAgentBase
+internal class GitHubActions(IEnvironment environment, ILog log) : BuildAgentBase(environment, log)
 {
     // https://help.github.com/en/actions/automating-your-workflow-with-github-actions/using-environment-variables#default-environment-variables
 
-    public GitHubActions(IEnvironment environment, ILog log) : base(environment, log)
-    {
-    }
-
     public const string EnvironmentVariableName = "GITHUB_ACTIONS";
     public const string GitHubSetEnvTempFileEnvironmentVariableName = "GITHUB_ENV";
 

src/GitVersion.BuildAgents/Agents/MyGet.cs

@@ -5,12 +5,8 @@
 
 namespace GitVersion.Agents;
 
-internal class MyGet : BuildAgentBase
+internal class MyGet(IEnvironment environment, ILog log) : BuildAgentBase(environment, log)
 {
-    public MyGet(IEnvironment environment, ILog log) : base(environment, log)
-    {
-    }
-
     public const string EnvironmentVariableName = "BuildRunner";
     protected override string EnvironmentVariable => EnvironmentVariableName;
     public override bool CanApplyToCurrentContext()

src/GitVersion.BuildAgents/Agents/SpaceAutomation.cs

@@ -3,12 +3,8 @@
 
 namespace GitVersion.Agents;
 
-internal class SpaceAutomation : BuildAgentBase
+internal class SpaceAutomation(IEnvironment environment, ILog log) : BuildAgentBase(environment, log)
 {
-    public SpaceAutomation(IEnvironment environment, ILog log) : base(environment, log)
-    {
-    }
-
     public const string EnvironmentVariableName = "JB_SPACE_PROJECT_KEY";
 
     protected override string EnvironmentVariable => EnvironmentVariableName;