remove need to lookup sha

SimonCropp · SimonCropp · commit c899ce36353c · 2014-10-04T14:45:59.000+10:00
diff --git a/GitVersionCore/GitFlow/BranchFinders/DevelopBasedVersionFinderBase.cs b/GitVersionCore/GitFlow/BranchFinders/DevelopBasedVersionFinderBase.cs
@@ -21,8 +21,7 @@ protected SemanticVersion FindVersion(
             var versionFromMaster = versionOnMasterFinder.Execute(context, context.CurrentCommit.Committer.When);
 
             var numberOfCommitsOnBranchSinceCommit = NumberOfCommitsOnBranchSinceCommit(context, ancestor);
-            var sha = context.CurrentCommit.Sha;
-            var releaseDate = ReleaseDateFinder.Execute(context.Repository, sha, 0);
+            var releaseDate = ReleaseDateFinder.Execute(context.Repository, context.CurrentCommit, 0);
             var preReleaseTag = context.CurrentBranch.Name
                 .TrimStart(branchType.ToString() + '-')
                 .TrimStart(branchType.ToString() + '/');
diff --git a/GitVersionCore/GitFlow/BranchFinders/DevelopVersionFinder.cs b/GitVersionCore/GitFlow/BranchFinders/DevelopVersionFinder.cs
@@ -21,7 +21,7 @@ public SemanticVersion FindVersion(GitVersionContext context)
             var c = context.Repository.Commits.QueryBy(f);
             var numberOfCommitsSinceRelease = c.Count();
 
-            var releaseDate = ReleaseDateFinder.Execute(context.Repository, tip.Sha, 0);
+            var releaseDate = ReleaseDateFinder.Execute(context.Repository, tip, 0);
             var semanticVersion = new SemanticVersion
             {
                 Major = versionFromMaster.Major,
diff --git a/GitVersionCore/GitFlow/BranchFinders/MasterVersionFinder.cs b/GitVersionCore/GitFlow/BranchFinders/MasterVersionFinder.cs
@@ -33,7 +33,7 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)
 
         SemanticVersion BuildVersion(IRepository repository, Commit tip, ShortVersion shortVersion)
         {
-            var releaseDate = ReleaseDateFinder.Execute(repository, tip.Sha, shortVersion.Patch);
+            var releaseDate = ReleaseDateFinder.Execute(repository, tip, shortVersion.Patch);
             return new SemanticVersion
             {
                 Major = shortVersion.Major,
diff --git a/GitVersionCore/GitFlow/BranchFinders/OptionallyTaggedBranchVersionFinderBase.cs b/GitVersionCore/GitFlow/BranchFinders/OptionallyTaggedBranchVersionFinderBase.cs
@@ -30,8 +30,7 @@ protected SemanticVersion FindVersion(
 
             var tagVersion = RetrieveMostRecentOptionalTagVersion(context.Repository, version, context.CurrentBranch.Commits.Take(nbHotfixCommits + 1));
 
-            var sha = context.CurrentCommit.Sha;
-            var releaseDate = ReleaseDateFinder.Execute(context.Repository, sha, version.Patch);
+            var releaseDate = ReleaseDateFinder.Execute(context.Repository, context.CurrentCommit, version.Patch);
             var semanticVersion = new SemanticVersion
             {
                 Major = version.Major,
diff --git a/GitVersionCore/GitFlow/BranchFinders/SupportVersionFinder.cs b/GitVersionCore/GitFlow/BranchFinders/SupportVersionFinder.cs
@@ -35,7 +35,7 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)
 
         SemanticVersion BuildVersion(IRepository repository, Commit tip, ShortVersion shortVersion)
         {
-            var releaseDate = ReleaseDateFinder.Execute(repository, tip.Sha, shortVersion.Patch);
+            var releaseDate = ReleaseDateFinder.Execute(repository, tip, shortVersion.Patch);
             return new SemanticVersion
             {
                 Major = shortVersion.Major,
diff --git a/GitVersionCore/GitHubFlow/BuildNumberCalculator.cs b/GitVersionCore/GitHubFlow/BuildNumberCalculator.cs
@@ -23,8 +23,7 @@ public SemanticVersion GetBuildNumber(GitVersionContext context)
             var commitsSinceLastRelease = NumberOfCommitsOnBranchSinceCommit(context, commit);
             var semanticVersion = nextSemverCalculator.NextVersion();
 
-            var sha = context.CurrentCommit.Sha;
-            var releaseDate = ReleaseDateFinder.Execute(context.Repository, sha, semanticVersion.Patch);
+            var releaseDate = ReleaseDateFinder.Execute(context.Repository, context.CurrentCommit, semanticVersion.Patch);
 
             // TODO Need a way of setting this in a cross cutting way
             semanticVersion.BuildMetaData = new SemanticVersionBuildMetaData(commitsSinceLastRelease,
diff --git a/GitVersionCore/ReleaseDateFinder.cs b/GitVersionCore/ReleaseDateFinder.cs
@@ -7,9 +7,8 @@ namespace GitVersion
 {
     public class ReleaseDateFinder
     {
-        public static ReleaseDate Execute(IRepository repo, string commitSha, int calculatedPatch)
+        public static ReleaseDate Execute(IRepository repo, Commit commit, int calculatedPatch)
         {
-            var commit = repo.Lookup<Commit>(commitSha);
             var rd = new ReleaseDate
             {
                 OriginalDate = commit.When(),

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public SemanticVersion FindVersion(GitVersionContext context)`
`21`	`21`	`var c = context.Repository.Commits.QueryBy(f);`
`22`	`22`	`var numberOfCommitsSinceRelease = c.Count();`
`23`	`23`
`24`		`- var releaseDate = ReleaseDateFinder.Execute(context.Repository, tip.Sha, 0);`
	`24`	`+ var releaseDate = ReleaseDateFinder.Execute(context.Repository, tip, 0);`
`25`	`25`	`var semanticVersion = new SemanticVersion`
`26`	`26`	`{`
`27`	`27`	`Major = versionFromMaster.Major,`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)`
`33`	`33`
`34`	`34`	`SemanticVersion BuildVersion(IRepository repository, Commit tip, ShortVersion shortVersion)`
`35`	`35`	`{`
`36`		`- var releaseDate = ReleaseDateFinder.Execute(repository, tip.Sha, shortVersion.Patch);`
	`36`	`+ var releaseDate = ReleaseDateFinder.Execute(repository, tip, shortVersion.Patch);`
`37`	`37`	`return new SemanticVersion`
`38`	`38`	`{`
`39`	`39`	`Major = shortVersion.Major,`
Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,7 @@ protected SemanticVersion FindVersion(`
`30`	`30`
`31`	`31`	`var tagVersion = RetrieveMostRecentOptionalTagVersion(context.Repository, version, context.CurrentBranch.Commits.Take(nbHotfixCommits + 1));`
`32`	`32`
`33`		`- var sha = context.CurrentCommit.Sha;`
`34`		`- var releaseDate = ReleaseDateFinder.Execute(context.Repository, sha, version.Patch);`
	`33`	`+ var releaseDate = ReleaseDateFinder.Execute(context.Repository, context.CurrentCommit, version.Patch);`
`35`	`34`	`var semanticVersion = new SemanticVersion`
`36`	`35`	`{`
`37`	`36`	`Major = version.Major,`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)`
`35`	`35`
`36`	`36`	`SemanticVersion BuildVersion(IRepository repository, Commit tip, ShortVersion shortVersion)`
`37`	`37`	`{`
`38`		`- var releaseDate = ReleaseDateFinder.Execute(repository, tip.Sha, shortVersion.Patch);`
	`38`	`+ var releaseDate = ReleaseDateFinder.Execute(repository, tip, shortVersion.Patch);`
`39`	`39`	`return new SemanticVersion`
`40`	`40`	`{`
`41`	`41`	`Major = shortVersion.Major,`
Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,8 @@ namespace GitVersion`
`7`	`7`	`{`
`8`	`8`	`public class ReleaseDateFinder`
`9`	`9`	`{`
`10`		`- public static ReleaseDate Execute(IRepository repo, string commitSha, int calculatedPatch)`
	`10`	`+ public static ReleaseDate Execute(IRepository repo, Commit commit, int calculatedPatch)`
`11`	`11`	`{`
`12`		`- var commit = repo.Lookup<Commit>(commitSha);`
`13`	`12`	`var rd = new ReleaseDate`
`14`	`13`	`{`
`15`	`14`	`OriginalDate = commit.When(),`