Deleted ProcessHelper

Deleted ProcessHelper and replaced usage with the one from GitTools.Core.

Author: asbjornu

src/GitVersionCore/GitVersionCore.csproj

@@ -119,7 +119,6 @@
     <Compile Include="GitVersionCache.cs" />
     <Compile Include="Helpers\FileSystem.cs" />
     <Compile Include="Helpers\IFileSystem.cs" />
-    <Compile Include="Helpers\ProcessHelper.cs" />
     <Compile Include="Helpers\ServiceMessageEscapeHelper.cs" />
     <Compile Include="IncrementStrategyFinder.cs" />
     <Compile Include="OutputVariables\VersionVariables.cs" />

src/GitVersionCore/Helpers/ProcessHelper.cs

@@ -2,8 +2,7 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Text;
-
-using GitVersion.Helpers;
+using GitTools;
 
 public static class GitVersionHelper
 {
@@ -41,10 +40,23 @@ static ExecutionResults ExecuteIn(ArgumentBuilder arguments)
                 new KeyValuePair<string, string>("APPVEYOR", null)
             };
 
-        var exitCode = ProcessHelper.Run(
-            s => output.AppendLine(s), s => output.AppendLine(s), null,
-            gitVersion, arguments.ToString(), arguments.WorkingDirectory,
-            environmentalVariables);
+        var exitCode = -1;
+
+        try
+        {
+            exitCode = ProcessHelper.Run(
+                s => output.AppendLine(s), s => output.AppendLine(s), null,
+                gitVersion, arguments.ToString(), arguments.WorkingDirectory,
+                environmentalVariables);
+        }
+        catch (Exception exception)
+        {
+            // NOTE: It's the exit code and output from the process we want to test,
+            //       not the internals of the ProcessHelper. That's why we're catching
+            //       any exceptions here, because problems in the process being executed
+            //       should be visible in the output or exit code. @asbjornu
+            Console.WriteLine(exception);
+        }
 
         Console.WriteLine("Output from GitVersion.exe");
         Console.WriteLine("-------------------------------------------------------");

src/GitVersionExe.Tests/GitVersionHelper.cs

@@ -2,10 +2,10 @@ namespace GitVersion
 {
     using System;
     using System.Collections.Generic;
-    using System.ComponentModel;
     using System.Linq;
-
+    using GitTools;
     using GitVersion.Helpers;
+    using WarningException = System.ComponentModel.WarningException;
 
     class SpecifiedArgumentRunner
     {