code cleanup

Author: arturcic

src/GitVersion.App/ArgumentParserExtensions.cs

@@ -69,7 +69,7 @@ public static bool ArgumentRequiresValue(this string argument, int argumentIndex
 
         var argumentMightRequireValue = !booleanArguments.Contains(argument[1..], StringComparer.OrdinalIgnoreCase);
 
-        // If this is the first argument that might be a target path, the argument starts with slash and we're on an OS that supports paths with slashes, the argument does not require a value.
+        // If this is the first argument that might be a target path, the argument starts with slash, and we're on an OS that supports paths with slashes, the argument does not require a value.
         if (argumentMightRequireValue && argumentIndex == 0 && argument.StartsWith('/') && Path.DirectorySeparatorChar == '/' && argument.IsValidPath())
             return false;
 

src/GitVersion.App/QuotedStringHelpers.cs

@@ -71,7 +71,7 @@ public static string UnquoteText(string input)
         if (sb[0] == '"')
             sb.Remove(0, 1);
 
-        if (sb[sb.Length - 1] == '"' && sb[sb.Length - 2] != '\\')
+        if (sb[^1] == '"' && sb[^2] != '\\')
             sb.Remove(sb.Length - 1, 1);
 
         sb.Replace("\\\"", "\""); // unescape quotes.

src/GitVersion.Configuration.Tests/Configuration/ConfigurationProviderTests.cs

@@ -126,7 +126,7 @@ public void SourceBranchesValidationShouldSucceedForWellKnownBranches(string wel
         using var _ = this.fileSystem.SetupConfigFile(path: this.repoPath, text: text);
         var configuration = this.configurationProvider.ProvideForDirectory(this.repoPath);
 
-        configuration.Branches["bug"].SourceBranches.ShouldBe(new List<string> { wellKnownBranchKey });
+        configuration.Branches["bug"].SourceBranches.ShouldBe([wellKnownBranchKey]);
     }
 
     [Test]
@@ -301,7 +301,7 @@ public void ShouldUseSpecifiedSourceBranchesForDevelop()
         using var _ = this.fileSystem.SetupConfigFile(path: this.repoPath, text: text);
         var configuration = this.configurationProvider.ProvideForDirectory(this.repoPath);
 
-        configuration.Branches["develop"].SourceBranches.ShouldBe(new List<string> { "develop" });
+        configuration.Branches["develop"].SourceBranches.ShouldBe(["develop"]);
     }
 
     [Test]
@@ -332,7 +332,7 @@ public void ShouldUseSpecifiedSourceBranchesForFeature()
         using var _ = this.fileSystem.SetupConfigFile(path: this.repoPath, text: text);
         var configuration = this.configurationProvider.ProvideForDirectory(this.repoPath);
 
-        configuration.Branches["feature"].SourceBranches.ShouldBe(new List<string> { "develop", "release" });
+        configuration.Branches["feature"].SourceBranches.ShouldBe(["develop", "release"]);
     }
 
     [Test]

src/GitVersion.Configuration/Attributes/JsonPropertyFormatAttribute.cs

@@ -1,7 +1,7 @@
 namespace GitVersion.Configuration.Attributes;
 
 /// <summary>
-/// <para>The <c>format</c> keyword allows for basic semantic identification of certain kinds of string values that are commonly used. For example, because JSON doesn't have a "DateTime" type, dates need to be encoded as strings. <c>format</c> allows the schema author to indicate that the string value should be interpreted as a date. By default, <c>format</c> is just an annotation and does not effect validation.</para>
+/// <para>The <c>format</c> keyword allows for basic semantic identification of certain kinds of string values that are commonly used. For example, because JSON doesn't have a "DateTime" type, dates need to be encoded as strings. <c>format</c> allows the schema author to indicate that the string value should be interpreted as a date. By default, <c>format</c> is just an annotation and does not affect validation.</para>
 /// <para>Optionally, validator implementations can [...] enable <c>format</c> to function as an assertion rather than just an annotation.</para>
 /// <see href="https://json-schema.org/understanding-json-schema/reference/string#format"/>
 /// </summary>

src/GitVersion.Configuration/PreventIncrementConfiguration.cs

@@ -13,6 +13,6 @@ internal class PreventIncrementConfiguration : IPreventIncrementConfiguration
     public bool? WhenBranchMerged { get; set; }
 
     [JsonPropertyName("when-current-commit-tagged")]
-    [JsonPropertyDescription("This branch related property controls the behvior whether to use the tagged (value set to true) or the incremented (value set to false) semantic version. Defaults to true.")]
+    [JsonPropertyDescription("This branch related property controls the behavior whether to use the tagged (value set to true) or the incremented (value set to false) semantic version. Defaults to true.")]
     public bool? WhenCurrentCommitTagged { get; set; }
 }

src/GitVersion.Core.Tests/Helpers/TestFileSystem.cs

@@ -74,10 +74,9 @@ public void WriteAllText(string? file, string fileContents, Encoding encoding)
     public Stream OpenRead(string path)
     {
         var fullPath = Path.GetFullPath(path);
-        if (!this.fileSystem.ContainsKey(fullPath))
+        if (!this.fileSystem.TryGetValue(fullPath, out var content))
             throw new FileNotFoundException("File not found.", fullPath);
 
-        var content = this.fileSystem[fullPath];
         return new MemoryStream(content);
     }