cleanup

Author: arturcic

src/GitVersionCore.Tests/Core/RepositoryExtensionsTests.cs

@@ -76,7 +76,7 @@ public void EnsureLocalBranchExistsForCurrentBranch_CaseInsensitivelyMatchesBran
             EnsureLocalBranchExistsForCurrentBranch(repository, log, remote, "refs/heads/featurE/feat-test");
         }
 
-        private IGitRepository MockRepository()
+        private static IGitRepository MockRepository()
         {
             var repository = Substitute.For<IGitRepository>();
             var commands = Substitute.For<IGitRepositoryCommands>();

src/GitVersionCore.Tests/Mocks/MockBranchCollection.cs

@@ -23,23 +23,5 @@ public void Add(Branch item)
         {
             Branches.Add(item);
         }
-
-        public void Clear()
-        {
-            Branches.Clear();
-        }
-
-        public bool Contains(Branch item)
-        {
-            return Branches.Contains(item);
-        }
-
-        public void CopyTo(Branch[] array, int arrayIndex)
-        {
-            Branches.CopyTo(array, arrayIndex);
-        }
-
-        public int Count => Branches.Count;
-        public bool IsReadOnly => false;
     }
 }

src/GitVersionCore.Tests/Mocks/MockCommitLog.cs

@@ -5,9 +5,9 @@
 
 namespace GitVersionCore.Tests.Mocks
 {
-    public class MockCommitLog : ICommitLog, ICollection<Commit>
+    public class MockCommitLog : ICommitLog
     {
-        public List<Commit> Commits = new List<Commit>();
+        private List<Commit> Commits = new List<Commit>();
 
         public IEnumerator<Commit> GetEnumerator()
         {

src/GitVersionCore.Tests/Mocks/MockMergeCommit.cs

@@ -36,16 +36,6 @@ public IEnumerable<LogEntry> QueryBy(string path)
             throw new NotImplementedException();
         }
 
-        public Commit FindMergeBase(Commit first, Commit second)
-        {
-            return null;
-        }
-
-        public Commit FindMergeBase(IEnumerable<Commit> commits, MergeBaseFindingStrategy strategy)
-        {
-            throw new NotImplementedException();
-        }
-
         public IEnumerable<LogEntry> QueryBy(string path, CommitFilter filter)
         {
             throw new NotImplementedException();

src/GitVersionCore.Tests/Mocks/MockQueryableCommitLog.cs

@@ -1,12 +1,10 @@
-using System.Collections;
 using System.Collections.Generic;
 using LibGit2Sharp;
 
 namespace GitVersionCore.Tests.Mocks
 {
-    public class MockReferenceCollection : ReferenceCollection, ICollection<Commit>
+    public class MockReferenceCollection : ReferenceCollection
     {
-
         public override ReflogCollection Log(string canonicalName)
         {
             return new MockReflogCollection
@@ -15,45 +13,16 @@ public override ReflogCollection Log(string canonicalName)
             };
         }
 
-        public List<Commit> Commits = new List<Commit>();
+        private List<Commit> Commits = new List<Commit>();
 
         public new IEnumerator<Commit> GetEnumerator()
         {
             return Commits.GetEnumerator();
         }
 
-        IEnumerator IEnumerable.GetEnumerator()
-        {
-            return GetEnumerator();
-        }
-
         public void Add(Commit item)
         {
             Commits.Add(item);
         }
-
-        public void Clear()
-        {
-            Commits.Clear();
-        }
-
-        public bool Contains(Commit item)
-        {
-            return Commits.Contains(item);
-        }
-
-        public void CopyTo(Commit[] array, int arrayIndex)
-        {
-            Commits.CopyTo(array, arrayIndex);
-        }
-
-        public bool Remove(Commit item)
-        {
-            return Commits.Remove(item);
-        }
-
-        public int Count => Commits.Count;
-
-        public bool IsReadOnly => false;
     }
 }

src/GitVersionCore.Tests/Mocks/MockReferenceCollection.cs

@@ -1,50 +1,19 @@
-using System.Collections;
 using System.Collections.Generic;
 using LibGit2Sharp;
 
 namespace GitVersionCore.Tests.Mocks
 {
-    public class MockReflogCollection : ReflogCollection, ICollection<Commit>
+    public class MockReflogCollection : ReflogCollection
     {
         public List<Commit> Commits = new List<Commit>();
-
         public new IEnumerator<Commit> GetEnumerator()
         {
             return Commits.GetEnumerator();
         }
 
-        IEnumerator IEnumerable.GetEnumerator()
-        {
-            return GetEnumerator();
-        }
-
         public void Add(Commit item)
         {
             Commits.Add(item);
         }
-
-        public void Clear()
-        {
-            Commits.Clear();
-        }
-
-        public bool Contains(Commit item)
-        {
-            return Commits.Contains(item);
-        }
-
-        public void CopyTo(Commit[] array, int arrayIndex)
-        {
-            Commits.CopyTo(array, arrayIndex);
-        }
-
-        public bool Remove(Commit item)
-        {
-            return Commits.Remove(item);
-        }
-
-        public int Count => Commits.Count;
-
-        public bool IsReadOnly => false;
     }
 }

src/GitVersionCore.Tests/Mocks/MockReflogCollection.cs

@@ -1,59 +1,18 @@
-using System.Collections;
 using System.Collections.Generic;
 using LibGit2Sharp;
 
 namespace GitVersionCore.Tests.Mocks
 {
-    public class MockTagCollection : TagCollection, ICollection<Tag>
+    public class MockTagCollection : TagCollection
     {
-
-        public List<Tag> Tags = new List<Tag>();
+        private List<Tag> Tags = new List<Tag>();
         public override IEnumerator<Tag> GetEnumerator()
         {
             return Tags.GetEnumerator();
         }
-
-        IEnumerator<Tag> IEnumerable<Tag>.GetEnumerator()
-        {
-            return GetEnumerator();
-        }
-
-        IEnumerator IEnumerable.GetEnumerator()
-        {
-            return GetEnumerator();
-        }
-
         public void Add(Tag item)
         {
             Tags.Add(item);
         }
-
-        public void Clear()
-        {
-            Tags.Clear();
-        }
-
-        public bool Contains(Tag item)
-        {
-            return Tags.Contains(item);
-        }
-
-        public void CopyTo(Tag[] array, int arrayIndex)
-        {
-            Tags.CopyTo(array, arrayIndex);
-        }
-
-        public override void Remove(Tag tag)
-        {
-            Tags.Remove(tag);
-        }
-
-        bool ICollection<Tag>.Remove(Tag item)
-        {
-            return Tags.Remove(item);
-        }
-
-        public int Count => Tags.Count;
-        public bool IsReadOnly => false;
     }
 }