Set a default value of 60000 for the TagPreReleaseWeight

Author: ruhullahshah

docs/input/docs/configuration.md

@@ -201,7 +201,7 @@ set to `4`, which will pad the `CommitsSinceVersionSource` value of `1` to
 
 ### tag-pre-release-weight
 
-The pre-release weight in case of tagged commits. If the value is not set in the configuration, a default weight of 0 is used instead. If the `WeightedPreReleaseNumber` [variable](./more-info/variables) is 0 and this parameter is set, its value is used. This helps if your branching model is GitFlow and the last release build, which is often tagged, can utilise this parameter to produce a monotonically increasing build number.
+The pre-release weight in case of tagged commits. If the value is not set in the configuration, a default weight of 60000 is used instead. If the `WeightedPreReleaseNumber` [variable](./more-info/variables) is 0 and this parameter is set, its value is used. This helps if your branching model is GitFlow and the last release build, which is often tagged, can utilise this parameter to produce a monotonically increasing build number.
 
 ### commit-message-incrementing
 

src/GitVersionCore.Tests/Configuration/ConfigProviderTests.CanWriteOutEffectiveConfiguration.approved.txt

@@ -10,7 +10,7 @@ no-bump-message: '\+semver:\s?(none|skip)'
 legacy-semver-padding: 4
 build-metadata-padding: 4
 commits-since-version-source-padding: 4
-tag-pre-release-weight: 0
+tag-pre-release-weight: 60000
 commit-message-incrementing: Enabled
 branches:
   develop:

src/GitVersionCore.Tests/IntegrationTests/VersionInTagScenarios.cs

@@ -11,7 +11,7 @@ namespace GitVersionCore.Tests.IntegrationTests
     class VersionInTagScenarios
     {
         [Test]
-        public void TagPreReleaseWeightIsNotConfigured_HeadIsATaggedCommit_WeightedPreReleaseNumberShouldBeZero()
+        public void TagPreReleaseWeightIsNotConfigured_HeadIsATaggedCommit_WeightedPreReleaseNumberShouldBeTheDefaultValue()
         {
             // Arrange
             var config = new Config()
@@ -26,7 +26,7 @@ public void TagPreReleaseWeightIsNotConfigured_HeadIsATaggedCommit_WeightedPreRe
             var version = fixture.GetVersion(config);
 
             // Assert
-            version.AssemblySemFileVer.ShouldBe("1.1.0.0");
+            version.AssemblySemFileVer.ShouldBe("1.1.0.60000");
         }
 
         [Test]
@@ -36,7 +36,7 @@ public void TagPreReleaseWeightIsConfigured_HeadIsATaggedCommit_WeightedPreRelea
             var config = new Config()
             {
                 AssemblyFileVersioningFormat = "{Major}.{Minor}.{Patch}.{WeightedPreReleaseNumber}",
-                TagPreReleaseWeight = 60000
+                TagPreReleaseWeight = 65535
             };
             config.ApplyDefaults();
 
@@ -46,7 +46,7 @@ public void TagPreReleaseWeightIsConfigured_HeadIsATaggedCommit_WeightedPreRelea
             var version = fixture.GetVersion(config);
 
             // Assert
-            version.AssemblySemFileVer.ShouldBe("1.1.0.60000");
+            version.AssemblySemFileVer.ShouldBe("1.1.0.65535");
         }
 
         [Test]
@@ -56,7 +56,7 @@ public void TagPreReleaseWeightIsConfigured_GitFlowReleaseIsFinished_WeightedPre
             var config = new Config()
             {
                 AssemblyFileVersioningFormat = "{Major}.{Minor}.{Patch}.{WeightedPreReleaseNumber}",
-                TagPreReleaseWeight = 60000,
+                TagPreReleaseWeight = 65535,
                 VersioningMode = VersioningMode.ContinuousDeployment
             };
             config.ApplyDefaults();
@@ -74,11 +74,11 @@ public void TagPreReleaseWeightIsConfigured_GitFlowReleaseIsFinished_WeightedPre
             var version = fixture.GetVersion(config);
 
             // Assert
-            version.AssemblySemFileVer.ShouldBe("1.1.0.60000");
+            version.AssemblySemFileVer.ShouldBe("1.1.0.65535");
         }
 
         [Test]
-        public void TagPreReleaseWeightIsNotConfigured_GitFlowReleaseIsFinished_WeightedPreReleaseNumberShouldBeZero()
+        public void TagPreReleaseWeightIsNotConfigured_GitFlowReleaseIsFinished_WeightedPreReleaseNumberShouldBeTheDefaultValue()
         {
             // Arrange
             var config = new Config()
@@ -101,7 +101,7 @@ public void TagPreReleaseWeightIsNotConfigured_GitFlowReleaseIsFinished_Weighted
             var version = fixture.GetVersion(config);
 
             // Assert
-            version.AssemblySemFileVer.ShouldBe("1.1.0.0");
+            version.AssemblySemFileVer.ShouldBe("1.1.0.60000");
         }
     }
 }

src/GitVersionCore/Configuration/ConfigExtensions.cs

@@ -37,7 +37,7 @@ public static void Reset(this Config config)
             config.CommitsSinceVersionSourcePadding ??= 4;
             config.CommitDateFormat ??= "yyyy-MM-dd";
             config.UpdateBuildNumber ??= true;
-            config.TagPreReleaseWeight ??= 0;
+            config.TagPreReleaseWeight ??= DefaultTagPreReleaseWeight;
 
             var configBranches = config.Branches.ToList();
 
@@ -129,6 +129,7 @@ public static void Reset(this Config config)
                 { Config.MasterBranchRegex, 55000 }
             };
         private const IncrementStrategy DefaultIncrementStrategy = IncrementStrategy.Inherit;
+        private const int DefaultTagPreReleaseWeight = 60000;
 
         public static void ApplyBranchDefaults(this Config config,
             BranchConfig branchConfig,
@@ -267,7 +268,7 @@ public static EffectiveConfiguration CalculateEffectiveConfiguration(this Config
             var noBumpMessage = configuration.NoBumpMessage;
             var commitDateFormat = configuration.CommitDateFormat;
             var updateBuildNumber = configuration.UpdateBuildNumber ?? true;
-            var tagPreReleaseWeight = configuration.TagPreReleaseWeight;
+            var tagPreReleaseWeight = configuration.TagPreReleaseWeight ?? DefaultTagPreReleaseWeight;
 
             var commitMessageVersionBump = currentBranchConfig.CommitMessageIncrementing ?? configuration.CommitMessageIncrementing.Value;
             return new EffectiveConfiguration(
@@ -288,7 +289,7 @@ public static EffectiveConfiguration CalculateEffectiveConfiguration(this Config
                 commitDateFormat,
                 updateBuildNumber,
                 preReleaseWeight,
-                tagPreReleaseWeight.HasValue ? tagPreReleaseWeight.Value : 0);
+                tagPreReleaseWeight);
         }
 
         public static string GetBranchSpecificTag(this EffectiveConfiguration configuration, ILog log, string branchFriendlyName, string branchNameOverride)