Merge pull request #3844 from HHobeck/feature/Replace-the-version-mode-Mainline-Part-I.A

Feature/replace the version mode mainline part i.a

Author: arturcic

src/GitVersion.Core.Tests/Core/RepositoryStoreTests.cs

@@ -209,7 +209,7 @@ public void GetBranchesContainingCommitThrowsDirectlyOnNullCommit()
         var fixtureRepository = fixture.Repository.ToGitRepository();
         var gitRepoMetadataProvider = new RepositoryStore(this.log, fixtureRepository);
 
-        Assert.Throws<ArgumentNullException>(() => gitRepoMetadataProvider.GetBranchesContainingCommit(null));
+        Assert.Throws<ArgumentNullException>(() => gitRepoMetadataProvider.GetBranchesContainingCommit(null!));
     }
 
     [Test]

src/GitVersion.Core.Tests/IntegrationTests/HotfixBranchScenarios.cs

@@ -53,13 +53,15 @@ public void CanTakeVersionFromHotfixesBranch()
             r.MakeATaggedCommit("2.0.0");
         });
         // Merge hotfix branch to support
-        Commands.Checkout(fixture.Repository, MainBranch);
-        Commands.Checkout(fixture.Repository, fixture.Repository.CreateBranch("support-1.1", (LibGit2Sharp.Commit)fixture.Repository.Tags.Single(t => t.FriendlyName == "1.1.0").Target));
+        var branch = fixture.Repository.CreateBranch(
+            "support-1.1", (LibGit2Sharp.Commit)fixture.Repository.Tags.Single(t => t.FriendlyName == "1.1.0").Target
+        );
+        Commands.Checkout(fixture.Repository, branch);
         fixture.AssertFullSemver("1.1.0");
 
         // create hotfix branch
         Commands.Checkout(fixture.Repository, fixture.Repository.CreateBranch("hotfixes/1.1.1"));
-        fixture.AssertFullSemver("1.1.1+0");
+        fixture.AssertFullSemver("1.1.1-beta.1+0");
         fixture.Repository.MakeACommit();
 
         fixture.AssertFullSemver("1.1.1-beta.1+1");
@@ -85,7 +87,7 @@ public void PatchOlderReleaseExample()
 
         // create hotfix branch
         fixture.BranchTo("hotfix-1.1.1");
-        fixture.AssertFullSemver("1.1.1+0");
+        fixture.AssertFullSemver("1.1.1-beta.1+0");
         fixture.MakeACommit();
 
         fixture.AssertFullSemver("1.1.1-beta.1+1");

src/GitVersion.Core.Tests/IntegrationTests/PerformanceScenarios.cs

@@ -24,6 +24,8 @@ public void RepositoryWithALotOfTags()
         var sw = Stopwatch.StartNew();
 
         fixture.AssertFullSemver($"1.0.{maxCommits}-feature.1+1", configuration);
+        sw.Stop();
+
         sw.ElapsedMilliseconds.ShouldBeLessThan(5000);
     }
 }

src/GitVersion.Core.Tests/IntegrationTests/SupportBranchScenarios.cs

@@ -79,7 +79,7 @@ public void WhenSupportIsBranchedFromMainWithSpecificTag()
         using var fixture = new EmptyRepositoryFixture();
 
         fixture.MakeACommit();
-        fixture.AssertFullSemver("0.0.1-1");
+        fixture.AssertFullSemver("0.0.1-1", configuration);
 
         fixture.ApplyTag("1.4.0-rc");
         fixture.MakeACommit();

src/GitVersion.Core.Tests/VersionCalculation/SemanticVersionTests.cs

@@ -33,7 +33,7 @@ public void ConfigNextVersionTest(string nextVersion, string expectedVersion, Se
 
         baseVersion.ShouldNotBeNull();
         baseVersion.ShouldIncrement.ShouldBe(false);
-        baseVersion.SemanticVersion.ToString().ShouldBe(expectedVersion);
+        baseVersion.GetSemanticVersion().ToString().ShouldBe(expectedVersion);
     }
 
     [TestCase("0.1", SemanticVersionFormat.Strict)]

src/GitVersion.Core.Tests/VersionCalculation/Strategies/ConfigNextVersionBaseVersionStrategyTests.cs

@@ -177,7 +177,7 @@ private static void AssertMergeMessage(string message, string? expectedVersion,
         else
         {
             baseVersion.ShouldNotBeNull();
-            baseVersion.SemanticVersion.ToString().ShouldBe(expectedVersion);
+            baseVersion.GetSemanticVersion().ToString().ShouldBe(expectedVersion);
         }
     }
 

src/GitVersion.Core.Tests/VersionCalculation/Strategies/MergeMessageBaseVersionStrategyTests.cs

@@ -28,7 +28,7 @@ public void CanTakeVersionFromNameOfReleaseBranch(string branchName, string expe
         strategy.ShouldNotBeNull();
         var baseVersion = strategy.GetBaseVersions(effectiveBranchConfiguration).Single();
 
-        baseVersion.SemanticVersion.ToString().ShouldBe(expectedBaseVersion);
+        baseVersion.GetSemanticVersion().ToString().ShouldBe(expectedBaseVersion);
     }
 
     [TestCase("origin/hotfix-2.0.0")]
@@ -90,7 +90,7 @@ public void CanTakeVersionFromNameOfConfiguredReleaseBranch(string branchName, s
         strategy.ShouldNotBeNull();
         var baseVersion = strategy.GetBaseVersions(effectiveBranchConfiguration).Single();
 
-        baseVersion.SemanticVersion.ToString().ShouldBe(expectedBaseVersion);
+        baseVersion.GetSemanticVersion().ToString().ShouldBe(expectedBaseVersion);
     }
 
     [TestCase("origin", "release-2.0.0", "2.0.0")]
@@ -114,7 +114,7 @@ public void CanTakeVersionFromNameOfRemoteReleaseBranch(string origin, string br
         strategy.ShouldNotBeNull();
         var baseVersion = strategy.GetBaseVersions(effectiveBranchConfiguration).Single();
 
-        baseVersion.SemanticVersion.ToString().ShouldBe(expectedBaseVersion);
+        baseVersion.GetSemanticVersion().ToString().ShouldBe(expectedBaseVersion);
     }
 
     private static IVersionStrategy GetVersionStrategy(IGitRepository repository,

src/GitVersion.Core.Tests/VersionCalculation/Strategies/VersionInBranchNameBaseVersionStrategyTests.cs

@@ -16,12 +16,13 @@ public interface IRepositoryStore
     IEnumerable<ICommit> GetCommitLog(ICommit? baseVersionSource, ICommit? currentCommit);
 
     IBranch GetTargetBranch(string? targetBranchName);
-    IBranch? FindBranch(string? branchName);
+    IBranch? FindBranch(ReferenceName branchName);
+    IBranch? FindBranch(string branchName);
     IBranch? FindMainBranch(IGitVersionConfiguration configuration);
     IEnumerable<IBranch> FindMainlineBranches(IGitVersionConfiguration configuration);
     IEnumerable<IBranch> GetReleaseBranches(IEnumerable<KeyValuePair<string, IBranchConfiguration>> releaseBranchConfig);
     IEnumerable<IBranch> ExcludingBranches(IEnumerable<IBranch> branchesToExclude);
-    IEnumerable<IBranch> GetBranchesContainingCommit(ICommit? commit, IEnumerable<IBranch>? branches = null, bool onlyTrackedBranches = false);
+    IEnumerable<IBranch> GetBranchesContainingCommit(ICommit commit, IEnumerable<IBranch>? branches = null, bool onlyTrackedBranches = false);
 
     IDictionary<string, List<IBranch>> GetMainlineBranches(ICommit commit, IGitVersionConfiguration configuration);
 
@@ -41,8 +42,6 @@ public interface IRepositoryStore
 
     SemanticVersion? GetCurrentCommitTaggedVersion(ICommit? commit, string? tagPrefix, SemanticVersionFormat format, bool handleDetachedBranch);
 
-    IEnumerable<SemanticVersion> GetVersionTagsOnBranch(IBranch branch, string? tagPrefix, SemanticVersionFormat format);
-
     IReadOnlyList<SemanticVersionWithTag> GetTaggedSemanticVersions(string? tagPrefix, SemanticVersionFormat format);
 
     IReadOnlyList<SemanticVersionWithTag> GetTaggedSemanticVersionsOnBranch(IBranch branch, string? tagPrefix, SemanticVersionFormat format);

src/GitVersion.Core/Core/Abstractions/IRepositoryStore.cs

@@ -0,0 +1,41 @@
+using GitVersion.Configuration;
+using GitVersion.Extensions;
+
+namespace GitVersion.Core;
+
+internal sealed class BranchRepository : IBranchRepository
+{
+    private GitVersionContext VersionContext => this.versionContextLazy.Value;
+    private readonly Lazy<GitVersionContext> versionContextLazy;
+
+    private readonly IGitRepository gitRepository;
+
+    public BranchRepository(Lazy<GitVersionContext> versionContext, IGitRepository gitRepository)
+    {
+        this.versionContextLazy = versionContext.NotNull();
+        this.gitRepository = gitRepository.NotNull();
+    }
+
+    public IEnumerable<IBranch> GetMainlineBranches(params IBranch[] excludeBranches)
+        => GetBranches(new HashSet<IBranch>(excludeBranches), configuration => configuration.IsMainline == true);
+
+    public IEnumerable<IBranch> GetReleaseBranches(params IBranch[] excludeBranches)
+        => GetBranches(new HashSet<IBranch>(excludeBranches), configuration => configuration.IsReleaseBranch == true);
+
+    private IEnumerable<IBranch> GetBranches(HashSet<IBranch> excludeBranches, Func<IBranchConfiguration, bool> predicate)
+    {
+        predicate.NotNull();
+
+        foreach (var branch in this.gitRepository.Branches)
+        {
+            if (!excludeBranches.Contains(branch))
+            {
+                var branchConfiguration = VersionContext.Configuration.GetBranchConfiguration(branch.Name);
+                if (predicate(branchConfiguration))
+                {
+                    yield return branch;
+                }
+            }
+        }
+    }
+}