(build) cleanup

Author: arturcic

build/artifacts/BuildLifetime.cs

@@ -15,8 +15,8 @@ public override void Setup(BuildContext context, ISetupContext info)
         var dotnetVersion = context.Argument(Arguments.DockerDotnetVersion, string.Empty).ToLower();
         var dockerDistro = context.Argument(Arguments.DockerDistro, string.Empty).ToLower();
 
-        var versions = string.IsNullOrWhiteSpace(dotnetVersion) ? Constants.VersionsToBuild : new[] { dotnetVersion };
-        var distros = string.IsNullOrWhiteSpace(dockerDistro) ? Constants.DockerDistrosToBuild : new[] { dockerDistro };
+        var versions = string.IsNullOrWhiteSpace(dotnetVersion) ? Constants.VersionsToBuild : [dotnetVersion];
+        var distros = string.IsNullOrWhiteSpace(dockerDistro) ? Constants.DockerDistrosToBuild : [dockerDistro];
 
         var architectures = context.HasArgument(Arguments.Architecture) ? context.Arguments<Architecture>(Arguments.Architecture) : Constants.ArchToBuild;
 

build/artifacts/Tasks/ArtifactsExecutableTest.cs

@@ -47,10 +47,7 @@ private static void PackageTest(BuildContextBase context, string packageToTest)
 
         var settings = new GitVersionSettings
         {
-            OutputTypes = new HashSet<GitVersionOutput>
-            {
-                GitVersionOutput.Json
-            },
+            OutputTypes = [GitVersionOutput.Json],
             ToolPath = outputDirectory.Combine(packageToTest).Combine("tools").CombineWithFilePath("gitversion.exe").FullPath
         };
         var gitVersion = context.GitVersion(settings);

build/build/BuildContext.cs

@@ -9,9 +9,9 @@ public class BuildContext : BuildContextBase
 
     public readonly Dictionary<PlatformFamily, string[]> NativeRuntimes = new()
     {
-        [PlatformFamily.Windows] = new[] { "win-x64", "win-arm64" },
-        [PlatformFamily.Linux] = new[] { "linux-x64", "linux-musl-x64", "linux-arm64", "linux-musl-arm64" },
-        [PlatformFamily.OSX] = new[] { "osx-x64", "osx-arm64" },
+        [PlatformFamily.Windows] = ["win-x64", "win-arm64"],
+        [PlatformFamily.Linux] = ["linux-x64", "linux-musl-x64", "linux-arm64", "linux-musl-arm64"],
+        [PlatformFamily.OSX] = ["osx-x64", "osx-arm64"],
     };
 
     public bool EnabledUnitTests { get; set; }

build/build/Tasks/Test/UnitTest.cs

@@ -24,7 +24,7 @@ public override void Run(BuildContext context)
             {
                 throw new Exception($"Dotnet Target {dotnetTarget} is not supported at the moment");
             }
-            frameworks = new[] { dotnetTarget };
+            frameworks = [dotnetTarget];
         }
 
         foreach (var framework in frameworks)
@@ -81,7 +81,7 @@ private static void TestProjectForTarget(BuildContext context, FilePath project,
             CoverletOutputFormat = CoverletOutputFormat.cobertura,
             CoverletOutputDirectory = testResultsPath,
             CoverletOutputName = $"{projectName}.coverage.xml",
-            Exclude = new List<string> { "[GitVersion*.Tests]*", "[GitTools.Testing]*" }
+            Exclude = ["[GitVersion*.Tests]*", "[GitTools.Testing]*"]
         };
 
         context.DotNetTest(project.FullPath, settings, coverletSettings);

build/common/Lifetime/BuildLifetimeBase.cs

@@ -33,7 +33,7 @@ public override void Setup(T context, ISetupContext info)
         var gitVersionSettings = new GitVersionSettings
         {
             OutputTypes = [GitVersionOutput.Json, GitVersionOutput.BuildServer],
-            ToolPath = context.Tools.Resolve(new[] { "dotnet.exe", "dotnet" }),
+            ToolPath = context.Tools.Resolve(["dotnet.exe", "dotnet"]),
             ArgumentCustomization = args => args.Prepend(context.GetGitVersionDotnetToolLocation()?.FullPath ?? throw new FileNotFoundException("Failed to locate the Release build of gitversion.dll in ./tools/gitversion. Try running \"./build.ps1 -Stage build -Target BuildPrepare\""))
         };
 

build/docker/BuildLifetime.cs

@@ -19,8 +19,8 @@ public override void Setup(BuildContext context, ISetupContext info)
         var dotnetVersion = context.Argument(Arguments.DockerDotnetVersion, string.Empty).ToLower();
         var dockerDistro = context.Argument(Arguments.DockerDistro, string.Empty).ToLower();
 
-        var versions = string.IsNullOrWhiteSpace(dotnetVersion) ? Constants.VersionsToBuild : new[] { dotnetVersion };
-        var distros = string.IsNullOrWhiteSpace(dockerDistro) ? Constants.DockerDistrosToBuild : new[] { dockerDistro };
+        var versions = string.IsNullOrWhiteSpace(dotnetVersion) ? Constants.VersionsToBuild : [dotnetVersion];
+        var distros = string.IsNullOrWhiteSpace(dockerDistro) ? Constants.DockerDistrosToBuild : [dockerDistro];
 
         var registry = dockerRegistry == DockerRegistry.DockerHub ? Constants.DockerHubRegistry : Constants.GitHubContainerRegistry;
         context.DockerRegistry = dockerRegistry;