Skip to content

Commit fa32b9f

Browse files
committed
small changes
1 parent 858ea20 commit fa32b9f

File tree

1 file changed

+16
-30
lines changed

1 file changed

+16
-30
lines changed

src/GitVersionExe.Tests/PullRequestInBuildAgentTest.cs

Lines changed: 16 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,14 @@ namespace GitVersionExe.Tests
1313
public class PullRequestInBuildAgentTest
1414
{
1515
private const string PullRequestBranchName = "PR-5";
16+
private static readonly string[] PrMergeRefs =
17+
{
18+
"refs/pull-requests/5/merge",
19+
"refs/pull/5/merge",
20+
"refs/heads/pull/5/head"
21+
};
1622

17-
[TestCase("refs/pull-requests/5/merge")]
18-
[TestCase("refs/pull/5/merge")]
19-
[TestCase("refs/heads/pull/5/head")]
23+
[TestCaseSource(nameof(PrMergeRefs))]
2024
public void VerifyAzurePipelinesPullRequest(string pullRequestRef)
2125
{
2226
var env = new[]
@@ -27,9 +31,7 @@ public void VerifyAzurePipelinesPullRequest(string pullRequestRef)
2731
VerifyPullRequestVersionIsCalculatedProperly(pullRequestRef, env);
2832
}
2933

30-
[TestCase("refs/pull-requests/5/merge")]
31-
[TestCase("refs/pull/5/merge")]
32-
[TestCase("refs/heads/pull/5/head")]
34+
[TestCaseSource(nameof(PrMergeRefs))]
3335
public void VerifyCodeBuildPullRequest(string pullRequestRef)
3436
{
3537
var env = new[]
@@ -39,9 +41,7 @@ public void VerifyCodeBuildPullRequest(string pullRequestRef)
3941
VerifyPullRequestVersionIsCalculatedProperly(pullRequestRef, env);
4042
}
4143

42-
[TestCase("refs/pull-requests/5/merge")]
43-
[TestCase("refs/pull/5/merge")]
44-
[TestCase("refs/heads/pull/5/head")]
44+
[TestCaseSource(nameof(PrMergeRefs))]
4545
public void VerifyContinuaCIPullRequest(string pullRequestRef)
4646
{
4747
var env = new[]
@@ -52,9 +52,7 @@ public void VerifyContinuaCIPullRequest(string pullRequestRef)
5252
}
5353

5454

55-
[TestCase("refs/pull-requests/5/merge")]
56-
[TestCase("refs/pull/5/merge")]
57-
[TestCase("refs/heads/pull/5/head")]
55+
[TestCaseSource(nameof(PrMergeRefs))]
5856
public void VerifyDronePullRequest(string pullRequestRef)
5957
{
6058
var env = new[]
@@ -65,9 +63,7 @@ public void VerifyDronePullRequest(string pullRequestRef)
6563
VerifyPullRequestVersionIsCalculatedProperly(pullRequestRef, env);
6664
}
6765

68-
[TestCase("refs/pull-requests/5/merge")]
69-
[TestCase("refs/pull/5/merge")]
70-
[TestCase("refs/heads/pull/5/head")]
66+
[TestCaseSource(nameof(PrMergeRefs))]
7167
public void VerifyGitHubActionsPullRequest(string pullRequestRef)
7268
{
7369
var env = new[]
@@ -78,9 +74,7 @@ public void VerifyGitHubActionsPullRequest(string pullRequestRef)
7874
VerifyPullRequestVersionIsCalculatedProperly(pullRequestRef, env);
7975
}
8076

81-
[TestCase("refs/pull-requests/5/merge")]
82-
[TestCase("refs/pull/5/merge")]
83-
[TestCase("refs/heads/pull/5/head")]
77+
[TestCaseSource(nameof(PrMergeRefs))]
8478
public void VerifyGitLabCIPullRequest(string pullRequestRef)
8579
{
8680
var env = new[]
@@ -91,9 +85,7 @@ public void VerifyGitLabCIPullRequest(string pullRequestRef)
9185
VerifyPullRequestVersionIsCalculatedProperly(pullRequestRef, env);
9286
}
9387

94-
[TestCase("refs/pull-requests/5/merge")]
95-
[TestCase("refs/pull/5/merge")]
96-
[TestCase("refs/heads/pull/5/head")]
88+
[TestCaseSource(nameof(PrMergeRefs))]
9789
public void VerifyJenkinsPullRequest(string pullRequestRef)
9890
{
9991
var env = new[]
@@ -105,9 +97,7 @@ public void VerifyJenkinsPullRequest(string pullRequestRef)
10597
VerifyPullRequestVersionIsCalculatedProperly(pullRequestRef, env);
10698
}
10799

108-
[TestCase("refs/pull-requests/5/merge")]
109-
[TestCase("refs/pull/5/merge")]
110-
[TestCase("refs/heads/pull/5/head")]
100+
[TestCaseSource(nameof(PrMergeRefs))]
111101
public void VerifyMyGetPullRequest(string pullRequestRef)
112102
{
113103
var env = new[]
@@ -118,9 +108,7 @@ public void VerifyMyGetPullRequest(string pullRequestRef)
118108
VerifyPullRequestVersionIsCalculatedProperly(pullRequestRef, env);
119109
}
120110

121-
[TestCase("refs/pull-requests/5/merge")]
122-
[TestCase("refs/pull/5/merge")]
123-
[TestCase("refs/heads/pull/5/head")]
111+
[TestCaseSource(nameof(PrMergeRefs))]
124112
public void VerifyTeamCityPullRequest(string pullRequestRef)
125113
{
126114
var env = new[]
@@ -130,9 +118,7 @@ public void VerifyTeamCityPullRequest(string pullRequestRef)
130118
VerifyPullRequestVersionIsCalculatedProperly(pullRequestRef, env);
131119
}
132120

133-
[TestCase("refs/pull-requests/5/merge")]
134-
[TestCase("refs/pull/5/merge")]
135-
[TestCase("refs/heads/pull/5/head")]
121+
[TestCaseSource(nameof(PrMergeRefs))]
136122
public void VerifyTravisCIPullRequest(string pullRequestRef)
137123
{
138124
var env = new[]

0 commit comments

Comments
 (0)