Skip to content

Commit 2e63128

Browse files
committed
Fix open in new tab button
1 parent f4c8eee commit 2e63128

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

packages/gitbook/src/components/Embeddable/EmbeddableDocsPage.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,12 @@ export async function EmbeddableDocsPage(props: EmbeddableDocsPageProps) {
5252
</EmbeddableFrameHeaderMain>
5353
<EmbeddableFrameButtons>
5454
<EmbeddableDocsPageControlButtons
55-
href={context.linker.toPathInSite(page.path)}
55+
href={context.linker
56+
.toPathForPage({
57+
pages: context.revision.pages,
58+
page,
59+
})
60+
.replace(/~gitbook\/embed\/page\/?/, '')}
5661
/>
5762
</EmbeddableFrameButtons>
5863
</EmbeddableFrameHeader>

packages/gitbook/src/components/primitives/Link.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,8 @@ export function Link(props: LinkProps) {
7878

7979
const onClick = (event: React.MouseEvent<HTMLAnchorElement>) => {
8080
const isExternalWithOrigin = isExternalLink(href, window.location.origin);
81-
// Only trigger navigation context for internal links without modifier keys (i.e. open in new tab).
82-
if (!isExternal && !event.ctrlKey && !event.metaKey) {
81+
// Only trigger navigation context for internal links in the same window without modifier keys (i.e. open in new tab).
82+
if (!isExternal && target !== '_blank' && !event.ctrlKey && !event.metaKey) {
8383
onNavigationClick(href);
8484
}
8585

0 commit comments

Comments
 (0)