review

Author: conico974

packages/gitbook/src/app/sites/dynamic/[mode]/[siteURL]/[siteData]/(content)/[pagePath]/page.tsx

@@ -16,7 +16,7 @@ export default async function Page(props: PageProps) {
     const { context } = await getDynamicSiteContext(params);
     const pathname = getPagePathFromParams(params);
 
-    return <SitePage context={context} pageParams={{ pathname }} isSSR />;
+    return <SitePage context={context} pageParams={{ pathname }} staticRoute={false} />;
 }
 
 export async function generateViewport(props: PageProps): Promise<Viewport> {

packages/gitbook/src/app/sites/dynamic/[mode]/[siteURL]/[siteData]/~gitbook/embed/page/[pagePath]/page.tsx

@@ -12,7 +12,7 @@ export default async function Page(props: PageProps) {
     const { context } = await getEmbeddableDynamicContext(params);
     const pathname = getPagePathFromParams(params);
 
-    return <EmbeddableDocsPage context={context} pageParams={{ pathname }} isSSR />;
+    return <EmbeddableDocsPage context={context} pageParams={{ pathname }} staticRoute={false} />;
 }
 
 export async function generateMetadata(props: PageProps): Promise<Metadata> {

packages/gitbook/src/app/sites/static/[mode]/[siteURL]/[siteData]/(content)/[pagePath]/page.tsx

@@ -18,7 +18,7 @@ export default async function Page(props: PageProps) {
     const { context } = await getStaticSiteContext(params);
     const pathname = getPagePathFromParams(params);
 
-    return <SitePage context={context} pageParams={{ pathname }} isSSR={false} />;
+    return <SitePage context={context} pageParams={{ pathname }} staticRoute />;
 }
 
 export async function generateViewport(props: PageProps): Promise<Viewport> {

packages/gitbook/src/app/sites/static/[mode]/[siteURL]/[siteData]/~gitbook/embed/page/[pagePath]/page.tsx

@@ -14,7 +14,7 @@ export default async function Page(props: PageProps) {
     const { context } = await getEmbeddableStaticContext(params);
     const pathname = getPagePathFromParams(params);
 
-    return <EmbeddableDocsPage context={context} pageParams={{ pathname }} isSSR={false} />;
+    return <EmbeddableDocsPage context={context} pageParams={{ pathname }} staticRoute />;
 }
 
 export async function generateMetadata(props: PageProps): Promise<Metadata> {

packages/gitbook/src/components/Embeddable/EmbeddableDocsPage.tsx

@@ -30,7 +30,9 @@ type EmbeddableDocsPageProps = {
 /**
  * Page component for the embed docs page.
  */
-export async function EmbeddableDocsPage(props: EmbeddableDocsPageProps & { isSSR: boolean }) {
+export async function EmbeddableDocsPage(
+    props: EmbeddableDocsPageProps & { staticRoute: boolean }
+) {
     const { context, pageParams } = props;
     const { page, document, ancestors, withPageFeedback } = await getSitePageData({
         context,
@@ -87,7 +89,7 @@ export async function EmbeddableDocsPage(props: EmbeddableDocsPageProps & { isSS
                             document={document}
                             withPageFeedback={withPageFeedback}
                             insightsDisplayContext={SiteInsightsDisplayContext.Embed}
-                            isSSR={props.isSSR}
+                            staticRoute={props.staticRoute}
                         />
                     </ScrollContainer>
                 </EmbeddableFrameBody>

packages/gitbook/src/components/PageBody/OptionalSuspense.tsx

@@ -6,13 +6,13 @@ import React from 'react';
  * causing flickering and bad UX.
  */
 export default function OptionalSuspense(props: {
-    isSSR: boolean;
+    staticRoute: boolean;
     fallback: React.ReactNode;
     children: React.ReactNode;
 }) {
-    const { isSSR, fallback, children } = props;
+    const { staticRoute, fallback, children } = props;
 
-    if (!isSSR) {
+    if (staticRoute) {
         return <>{children}</>;
     }
 

packages/gitbook/src/components/PageBody/PageBody.tsx

@@ -27,9 +27,17 @@ export function PageBody(props: {
     document: JSONDocument | null;
     withPageFeedback: boolean;
     insightsDisplayContext: SiteInsightsDisplayContext;
-    isSSR: boolean;
+    staticRoute: boolean;
 }) {
-    const { page, context, ancestors, document, withPageFeedback, insightsDisplayContext } = props;
+    const {
+        page,
+        context,
+        ancestors,
+        document,
+        withPageFeedback,
+        insightsDisplayContext,
+        staticRoute,
+    } = props;
     const { customization } = context;
 
     const contentFullWidth = document ? hasFullWidthBlock(document) : false;
@@ -86,7 +94,7 @@ export function PageBody(props: {
                 />
                 {document && !isNodeEmpty(document) ? (
                     <OptionalSuspense
-                        isSSR={props.isSSR}
+                        staticRoute={staticRoute}
                         fallback={
                             <DocumentViewSkeleton
                                 document={document}

packages/gitbook/src/components/SitePage/SitePage.tsx

@@ -53,7 +53,7 @@ export type PageMetaLinks = {
 /**
  * Fetch and render a page.
  */
-export async function SitePage(props: SitePageProps & { isSSR: boolean }) {
+export async function SitePage(props: SitePageProps & { staticRoute: boolean }) {
     const {
         context,
         page,
@@ -99,7 +99,7 @@ export async function SitePage(props: SitePageProps & { isSSR: boolean }) {
                         document={document}
                         withPageFeedback={withPageFeedback}
                         insightsDisplayContext={SiteInsightsDisplayContext.Site}
-                        isSSR={props.isSSR}
+                        staticRoute={props.staticRoute}
                     />
                 </div>
                 <PageClientLayout pageMetaLinks={pageMetaLinks} />