Skip to content

Commit 99da055

Browse files
committed
Translate aria-labels
1 parent 4d2a083 commit 99da055

File tree

14 files changed

+51
-6
lines changed

14 files changed

+51
-6
lines changed

packages/gitbook/src/components/Search/SearchInput.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import React from 'react';
33
import { useEffect, useRef, useState } from 'react';
44

5-
import { tString, useLanguage } from '@/intl/client';
5+
import { t, tString, useLanguage } from '@/intl/client';
66
import { tcls } from '@/lib/tailwind';
77
import { Icon } from '@gitbook/icons';
88
import { Button, variantClasses } from '../primitives';
@@ -103,8 +103,8 @@ export const SearchInput = React.forwardRef<HTMLDivElement, SearchInputProps>(
103103
<div className="sr-only" aria-live="assertive" role="alert" aria-relevant="all">
104104
{resultsShowing
105105
? resultsCount > 0
106-
? `${resultsCount} results`
107-
: 'No results'
106+
? t(language, 'search_results_count', resultsCount)
107+
: t(language, 'search_no_results')
108108
: ''}
109109
</div>
110110
<input

packages/gitbook/src/components/Search/SearchPageResultItem.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export const SearchPageResultItem = React.forwardRef(function SearchPageResultIt
4141
spaceId: item.spaceId,
4242
},
4343
}}
44-
aria-label={`Page with title '${item.title}'`}
44+
aria-label={tString(language, 'search_page_result_title', item.title)}
4545
{...rest}
4646
>
4747
{breadcrumbs.length > 0 ? (

packages/gitbook/src/components/Search/SearchResults.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,6 @@ export const SearchResults = React.forwardRef(function SearchResults(
265265
<div
266266
data-testid="search-results"
267267
className="flex flex-col gap-y-1"
268-
aria-label={`Search results`}
269268
id={id}
270269
role="listbox"
271270
aria-live="polite"

packages/gitbook/src/components/Search/SearchSectionResultItem.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,13 @@ export const SearchSectionResultItem = React.forwardRef(function SearchSectionRe
3232
spaceId: item.spaceId,
3333
},
3434
}}
35-
aria-label={`Section${item.title ? ` with title '${item.title}'` : item.body ? ` with content '${getAbbreviatedBody(item.body, query)}'` : ''}`}
35+
aria-label={
36+
item.title
37+
? tString(language, 'search_section_result_title', item.title)
38+
: item.body
39+
? tString(language, 'search_section_result_content', getAbbreviatedBody(item.body, query))
40+
: tString(language, 'search_section_result_default')
41+
}
3642
{...rest}
3743
>
3844
<div className="grow border-tint-subtle border-l-2 pl-4">

packages/gitbook/src/intl/translations/de.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ export const de = {
1212
search_no_results_for: 'Keine Ergebnisse für "${1}".',
1313
search_no_results: 'Keine Ergebnisse',
1414
search_results_count: '${1} Ergebnisse',
15+
search_page_result_title: 'Seite mit Titel ${1}',
16+
search_section_result_title: 'Abschnitt mit Titel ${1}',
17+
search_section_result_content: 'Abschnitt mit Inhalt ${1}',
18+
search_section_result_default: 'Abschnitt',
1519
search_scope_space: '${1}',
1620
search_scope_all: 'Alle Inhalte',
1721
ask: 'Fragen',

packages/gitbook/src/intl/translations/en.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ export const en = {
1212
search_no_results_for: 'No results for "${1}".',
1313
search_no_results: 'No results',
1414
search_results_count: '${1} results',
15+
search_page_result_title: 'Page with title ${1}',
16+
search_section_result_title: 'Section with title ${1}',
17+
search_section_result_content: 'Section with content ${1}',
18+
search_section_result_default: 'Section',
1519
search_scope_space: '${1}',
1620
search_scope_all: 'All content',
1721
ask: 'Ask',

packages/gitbook/src/intl/translations/es.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ export const es: TranslationLanguage = {
1414
search_no_results_for: 'No hay resultados para "${1}".',
1515
search_no_results: 'No hay resultados',
1616
search_results_count: '${1} resultados',
17+
search_page_result_title: 'Página con título ${1}',
18+
search_section_result_title: 'Sección con título ${1}',
19+
search_section_result_content: 'Sección con contenido ${1}',
20+
search_section_result_default: 'Sección',
1721
search_scope_space: '${1}',
1822
search_scope_all: 'Todo el contenido',
1923
ask: 'Preguntar',

packages/gitbook/src/intl/translations/fr.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ export const fr = {
1212
search_no_results_for: 'Aucun résultat pour « ${1} ».',
1313
search_no_results: 'Aucun résultat',
1414
search_results_count: '${1} résultats',
15+
search_page_result_title: 'Page avec titre ${1}',
16+
search_section_result_title: 'Section avec titre ${1}',
17+
search_section_result_content: 'Section avec contenu ${1}',
18+
search_section_result_default: 'Section',
1519
search_scope_space: '${1}',
1620
search_scope_all: 'Tous les contenus',
1721
ask: 'Poser une question',

packages/gitbook/src/intl/translations/ja.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ export const ja: TranslationLanguage = {
1414
search_no_results_for: '"${1}" の結果はありません。',
1515
search_no_results: '結果がありません',
1616
search_results_count: '${1}件の結果',
17+
search_page_result_title: 'タイトル「${1}」のページ',
18+
search_section_result_title: 'タイトル「${1}」のセクション',
19+
search_section_result_content: 'コンテンツ「${1}」のセクション',
20+
search_section_result_default: 'セクション',
1721
search_scope_space: '${1}',
1822
search_scope_all: '全てのコンテンツ',
1923
ask: '質問する',

packages/gitbook/src/intl/translations/nl.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ export const nl: TranslationLanguage = {
1414
search_no_results_for: 'Geen resultaten voor "${1}".',
1515
search_no_results: 'Geen resultaten',
1616
search_results_count: '${1} resultaten',
17+
search_page_result_title: 'Pagina met titel ${1}',
18+
search_section_result_title: 'Sectie met titel ${1}',
19+
search_section_result_content: 'Sectie met inhoud ${1}',
20+
search_section_result_default: 'Sectie',
1721
search_scope_space: '${1}',
1822
search_scope_all: 'Alle inhoud',
1923
ask: 'Vragen',

0 commit comments

Comments
 (0)