Review

Author: zenoachtig

packages/gitbook/src/components/DocumentView/InlineLink/InlineLink.tsx

@@ -69,8 +69,7 @@ export async function InlineLink(props: InlineProps<DocumentInlineLink>) {
                     icon="envelope"
                     className="ml-1 inline size-3 links-accent:text-tint-subtle"
                 />
-            ) : null}
-            {isExternal && !isMailto ? (
+            ) : isExternal ? (
                 <Icon
                     icon="arrow-up-right"
                     className="ml-0.5 inline size-3 links-accent:text-tint-subtle"
@@ -106,22 +105,21 @@ function InlineLinkTooltipWrapper(props: {
     const isMailto = resolved.href.startsWith('mailto:');
     const isExternal = inline.data.ref.kind === 'url';
     const isSamePage = inline.data.ref.kind === 'anchor' && inline.data.ref.page === undefined;
-    if (isExternal) {
+
+    if (isMailto) {
+        resolved.text = resolved.text.split('mailto:')[1] ?? resolved.text;
         breadcrumbs = [
             {
-                label: tString(language, 'link_tooltip_external_link'),
+                label: tString(language, 'link_tooltip_email'),
             },
         ];
-    }
-    if (isMailto) {
-        resolved.text = resolved.text.split('mailto:')[1] ?? resolved.text;
+    } else if (isExternal) {
         breadcrumbs = [
             {
-                label: tString(language, 'link_tooltip_email'),
+                label: tString(language, 'link_tooltip_external_link'),
             },
         ];
-    }
-    if (isSamePage) {
+    } else if (isSamePage) {
         breadcrumbs = [
             {
                 label: tString(language, 'link_tooltip_page_anchor'),