Skip to content

Fix cache revalidation for computed revisions #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 10, 2025
Merged

Fix cache revalidation for computed revisions #3134

merged 6 commits into from
Apr 10, 2025

Conversation

@SamyPesse
Copy link
Member

@SamyPesse SamyPesse commented Apr 10, 2025 •
edited
Loading

We considered all revisions to be immutable, even when they were computed. With this PR, we'll leverage the cache-tags provided by the API, to ensure the tag is invalidated when the sources of the computations are updated.

This PR should be combined with one in the API to pass tags for every revision APIs.

On Cloudflare, we'll still use unstable_cache and it'll not work properly for computed content (until opennextjs/opennextjs-aws#820 is ready).
On Vercel, it'll use use cache and the tags are based on the API response.

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9f9d562

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025 •
edited
Loading

Summary of the deployments:

Version 1

Version URL Status
Latest commit https://8aa90662.gitbook-open.pages.dev ✅
PR https://pr3134.gitbook-open.pages.dev ✅

Version 2

Version URL Status
Vercel https://gitbook-v2-r6dwc75u1-gitbook.vercel.app ✅
Cloudflare https://a6253bb5-gitbook-open-v2-preview.gitbook.workers.dev ✅

Test content

Site v1 2v 2c
GitBook https://8aa90662.gitbook-open.pages.dev/docs.gitbook.com https://gitbook-v2-r6dwc75u1-gitbook.vercel.app/url/docs.gitbook.com https://a6253bb5-gitbook-open-v2-preview.gitbook.workers.dev/url/docs.gitbook.com
E2E https://8aa90662.gitbook-open.pages.dev/gitbook.gitbook.io/test-gitbook-open https://gitbook-v2-r6dwc75u1-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open https://a6253bb5-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.gitbook.io/test-gitbook-open

@argos-ci
Copy link

argos-ci bot commented Apr 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - Apr 10, 2025, 1:40 PM
customers-v2 (Inspect) 👍 Changes approved 2 changed Apr 10, 2025, 1:42 PM
default (Inspect) 👍 Changes approved 3 changed Apr 10, 2025, 1:42 PM
v2-vercel (Inspect) ✅ No changes detected - Apr 10, 2025, 1:44 PM

gregberge
gregberge reviewed Apr 10, 2025
View reviewed changes
@SamyPesse SamyPesse marked this pull request as ready for review April 10, 2025 10:19
@SamyPesse SamyPesse merged commit bc081c4 into main Apr 10, 2025
20 checks passed
@SamyPesse SamyPesse deleted the fix-computed-revision-cached branch April 10, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregberge gregberge gregberge approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SamyPesse @gregberge