Skip to content

Commit a3daa1f

Browse files
authored
Log error stacktrace when getting route handling uncaught errors (#909)
* Log error stacktrace when getting route handling uncaught errors * Add changeset * review
1 parent bd09c62 commit a3daa1f

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

.changeset/eight-emus-flow.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@gitbook/integration-oidc': patch
3+
---
4+
5+
Log error stacktrace when getting route handling uncaught errors #909

integrations/oidc/src/index.tsx

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -380,10 +380,19 @@ const handleFetchEvent: FetchEventCallback<OIDCRuntimeContext> = async (request,
380380
let response;
381381
try {
382382
response = await router.handle(request, context);
383-
} catch (error: any) {
384-
logger.error('error handling request', error);
385-
return new Response(error.message, {
386-
status: error.status || 500,
383+
} catch (error: unknown) {
384+
if (error instanceof Error) {
385+
logger.error(
386+
'error handling request:',
387+
`${error}${error.stack ? `\n${error.stack}` : ''}`,
388+
);
389+
return new Response(error.message, {
390+
status: 500,
391+
});
392+
}
393+
394+
return new Response('Unexpected error when handling request', {
395+
status: 500,
387396
});
388397
}
389398

0 commit comments

Comments
 (0)