Enhance GitHub Actions workflow for Arch Linux ISO builds:

- Ensure the Pacman cache directory is emptied before use to prevent errors.
- Update caching key to include the runner OS for better cache management.
- Modify package update command to perform a full system upgrade.
- Improve error messages for missing tools and failed builds with standardized output.
- Refactor cleanup steps to check for container existence before stopping and removing.
- Upgrade artifact upload action to v4 and increase log compression level.

Author: Githubguy132010

.github/workflows/build.yaml

@@ -37,14 +37,16 @@ jobs:
         run: |
           sudo mkdir -p /tmp/pacman-cache
           sudo chmod 777 /tmp/pacman-cache
+          # Ensure the directory is empty to prevent tar errors
+          sudo rm -rf /tmp/pacman-cache/*
 
       - name: Cache Pacman packages
         uses: actions/cache@v3
         with:
           path: /tmp/pacman-cache
-          key: pacman-${{ env.CACHE_KEY }}
+          key: pacman-${{ runner.os }}-${{ env.CACHE_KEY }}
           restore-keys: |
-            pacman-
+            pacman-${{ runner.os }}-
 
       - name: Set up Arch Linux Container
         run: |
@@ -58,8 +60,8 @@ jobs:
           docker exec arch-container bash -c "
             set -euo pipefail
             
-            # Update package database
-            pacman -Sy --noconfirm
+            # Update package database and system
+            pacman -Syu --noconfirm
             
             # Install required packages
             pacman -S --noconfirm --needed \
@@ -74,7 +76,7 @@ jobs:
             
             # Verify installation
             command -v mkarchiso >/dev/null 2>&1 || {
-              echo 'Error: mkarchiso not found'
+              echo '::error::mkarchiso not found'
               exit 1
             }
           "
@@ -92,14 +94,14 @@ jobs:
             
             # Build the ISO with verbose output
             mkarchiso -v -w workdir/ -o out/ . 2>&1 | tee build.log || {
-              echo 'Error: ISO build failed!'
+              echo '::error::ISO build failed!'
               tail -n 50 build.log
               exit 1
             }
             
             # Verify ISO was created
             [ -f out/*.iso ] || {
-              echo 'Error: ISO file not found after build'
+              echo '::error::ISO file not found after build'
               exit 1
             }
           "
@@ -131,14 +133,6 @@ jobs:
             done
           "
 
-      - name: Upload ISO Artifact
-        uses: actions/upload-artifact@v3
-        with:
-          name: arch-linux-no-beeps-${{ env.VERSION }}
-          path: |
-            ${{ env.WORKSPACE }}/out/*.iso
-            ${{ env.WORKSPACE }}/out/*.sha*sum
-          retention-days: 5
 
       - name: Create Release
         id: create_release
@@ -169,15 +163,18 @@ jobs:
       - name: Clean Up
         if: always()
         run: |
-          docker stop arch-container || true
-          docker rm arch-container || true
+          if docker ps -a | grep -q arch-container; then
+            docker stop arch-container || true
+            docker rm -f arch-container || true
+          fi
           sudo rm -rf workdir/ out/ /tmp/pacman-cache/*
 
       - name: Upload Build Logs on Failure
         if: failure()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4  # Upgrade to v4
         with:
           name: build-logs
           path: |
             ${{ env.WORKSPACE }}/build.log
-          retention-days: 5
+          retention-days: 5
+          compression-level: 9  # Maximum compression for logs