Enhance release cleanup process with improved error handling, detailed logging, and authentication checks for GitHub CLI

Author: Githubguy132010

.github/workflows/build.yaml

@@ -194,54 +194,100 @@ jobs:
           && sudo apt install gh -y
 
       - name: Delete old releases
+        # This step runs after the GitHub CLI setup and release creation
+        if: github.ref == 'refs/heads/main' && success()
         env:
-          # We need to use a token with sufficient permissions
-          # Using GITHUB_TOKEN with proper permissions defined at workflow level
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
+          set +e  # Don't exit on error
+          
+          echo "::group::Release Cleanup"
+          
           # Get current release tag we're creating
           current_tag="v${{ env.VERSION }}"
-          echo "Current release tag: $current_tag"
+          echo "ℹ️ Current release tag: $current_tag"
+          
+          # Explicitly authenticate with GitHub CLI using the token
+          echo "$GITHUB_TOKEN" | gh auth login --with-token
+          
+          if [ $? -ne 0 ]; then
+            echo "::warning::Failed to authenticate with GitHub CLI. Skipping release cleanup."
+            exit 0  # Continue workflow
+          fi
+          
+          # List all releases 
+          echo "ℹ️ Listing existing releases..."
+          
+          # Use simple list format first to check if releases exist
+          release_count=$(gh release list | wc -l)
+          
+          if [ $release_count -eq 0 ]; then
+            echo "ℹ️ No existing releases found. Nothing to clean up."
+            echo "::endgroup::"
+            exit 0
+          fi
           
-          # List all releases excluding the current one we're creating
-          echo "Listing existing releases..."
+          echo "ℹ️ Found $release_count releases in total"
           
-          # Try to get releases, handling potential errors
-          if ! releases=$(gh release list --limit 100 --exclude-drafts --exclude-pre-releases --json tagName,createdAt); then
-            echo "::warning::Unable to list releases, skipping cleanup"
+          # Get detailed release info with JSON
+          releases=$(gh release list --limit 100 --json tagName,createdAt 2>/dev/null)
+          
+          if [ $? -ne 0 ] || [ -z "$releases" ]; then
+            echo "::warning::Unable to get detailed release information. Skipping cleanup."
+            echo "::endgroup::"
             exit 0
           fi
           
-          # Parse the JSON output and extract tag names sorted by creation date
-          readarray -t old_releases < <(echo "$releases" | jq -r 'sort_by(.createdAt) | .[].tagName')
+          # Check if jq command is available
+          if ! command -v jq &> /dev/null; then
+            echo "::warning::jq command not found. Installing jq..."
+            sudo apt-get update && sudo apt-get install -y jq
+          fi
+          
+          # Parse releases, handling potential JSON parsing errors
+          if ! old_releases=($(echo "$releases" | jq -r 'sort_by(.createdAt) | .[].tagName' 2>/dev/null)); then
+            echo "::warning::Failed to parse release information. Skipping cleanup."
+            echo "::endgroup::"
+            exit 0
+          fi
           
-          # Keep no old releases (excluding current new release)
+          # Number of releases to keep (0 means delete all old releases)
           keep=0
           count=0
           total=${#old_releases[@]}
           
-          echo "Found $total existing releases"
+          echo "ℹ️ Found $total releases after parsing"
           
-          # Delete all releases except the most recent 'keep' number
+          # Delete all releases except the most recent 'keep' number and current release
           for tag in "${old_releases[@]}"; do
-            # Skip the current release if it somehow appears in the list
+            # Skip the current release
             if [[ "$tag" == "$current_tag" ]]; then
-              echo "Skipping current release: $tag"
+              echo "ℹ️ Skipping current release: $tag"
               continue
             fi
             
             ((count++))
             if ((count > keep)); then
-              echo "Attempting to delete release: $tag"
-              if gh release delete "$tag" --yes; then
-                echo "Successfully deleted release: $tag"
+              echo "🗑️ Attempting to delete release: $tag"
+              
+              # Try to delete the release with a timeout
+              if timeout 30s gh release delete "$tag" --yes; then
+                echo "✅ Successfully deleted release: $tag"
               else
-                echo "::warning::Failed to delete release $tag - this is non-fatal"
+                deletion_status=$?
+                echo "::warning::Failed to delete release $tag (exit code: $deletion_status) - continuing with next release"
               fi
+              
+              # Small delay to avoid rate limiting
+              sleep 1
             else
-              echo "Keeping release: $tag"
+              echo "🔒 Keeping release: $tag (within keep limit)"
             fi
           done
           
-          echo "Release cleanup complete"
+          echo "🏁 Release cleanup completed"
+          echo "::endgroup::"
+          
+          # Always return success to avoid workflow failures
+          exit 0