Adapt to changes in cargo_metadata

`cargo_metadata`, starting in version 0.20.0, holds package names
in some of its public data structures in a `PackageName` type that
performs validation. This type is defined in `cargo-util-schemas`:

- oli-obk/cargo_metadata@e3373d0
- https://docs.rs/cargo-util-schemas/0.2.0/cargo_util_schemas/manifest/struct.PackageName.html

Code in `cargo-smart-release` that assumed `String` must, in some
places, be adjusted to accommodate `PackageName<String>` instead.

This makes such changes, including replacing `&` with `.as_str()`,
and `.clone()` or `.to_owned()` with `.to_string()`, where needed.

(At least at this time, `cargo-smart-release` itself continues to
represent package names as `String`.)

Author: EliahKagan

src/command/release/cargo.rs

@@ -45,7 +45,7 @@ pub(in crate::command::release_impl) fn publish_crate(
         }
         c.arg("--manifest-path").arg(&publishee.manifest_path);
         if prevent_default_members {
-            c.arg("--package").arg(&publishee.name);
+            c.arg("--package").arg(publishee.name.as_str());
         }
         if verbose {
             log::trace!("{} run {:?}", will(!cargo_must_run), c);

src/command/release/manifest.rs

@@ -521,11 +521,11 @@ fn set_version_and_update_package_dependency(
         }
     }
     for (dep_table, dep_type) in find_dependency_tables(&mut doc) {
-        for (name_to_find, new_version) in crates.iter().map(|(p, nv)| (&p.name, nv)) {
+        for (name_to_find, new_version) in crates.iter().map(|(p, nv)| (p.name.as_str(), nv)) {
             for name_to_find in package_to_update
                 .dependencies
                 .iter()
-                .filter(|dep| &dep.name == name_to_find)
+                .filter(|dep| dep.name == name_to_find)
                 .map(|dep| dep.rename.as_ref().unwrap_or(&dep.name))
             {
                 let Some(name_table) = dep_table

src/traverse.rs

@@ -305,7 +305,7 @@ fn forward_propagate_breaking_changes_for_manifest_updates<'meta>(
                         let adjustment = VersionAdjustment::Breakage {
                             bump,
                             change: None,
-                            causing_dependency_names: vec![dependee.package.name.to_owned()],
+                            causing_dependency_names: vec![dependee.package.name.to_string()],
                         };
                         new_crates_this_round.push(Dependency {
                             package: dependant,
@@ -407,7 +407,7 @@ impl EditForPublish {
         let causing_dependency_names = self
             .causing_dependency_indices
             .into_iter()
-            .map(|idx| crates[idx].package.name.clone())
+            .map(|idx| crates[idx].package.name.to_string())
             .collect();
         let dep_mut = &mut crates[self.crates_idx];
         if is_pre_release_version(&dep_mut.package.version) || allow_auto_publish_of_stable_crates {

src/utils.rs

@@ -64,20 +64,20 @@ pub fn version_req_unset_or_default(req: &VersionReq) -> bool {
 
 pub fn package_eq_dependency_ignore_dev_without_version(package: &Package, dependency: &Dependency) -> bool {
     (dependency.kind != DependencyKind::Development || !version_req_unset_or_default(&dependency.req))
-        && package.name == dependency.name
+        && package.name.as_str() == dependency.name
 }
 
 pub fn workspace_package_by_dependency<'a>(meta: &'a Metadata, dep: &Dependency) -> Option<&'a Package> {
     meta.packages
         .iter()
-        .find(|p| p.name == dep.name && p.source.as_ref().is_none_or(|s| !s.is_crates_io()))
+        .find(|p| p.name.as_str() == dep.name && p.source.as_ref().is_none_or(|s| !s.is_crates_io()))
         .filter(|p| meta.workspace_members.iter().any(|m| m == &p.id))
 }
 
 pub fn package_by_name<'a>(meta: &'a Metadata, name: &str) -> anyhow::Result<&'a Package> {
     meta.packages
         .iter()
-        .find(|p| p.name == name && p.source.as_ref().is_none_or(|s| !s.is_crates_io()))
+        .find(|p| p.name.as_str() == name && p.source.as_ref().is_none_or(|s| !s.is_crates_io()))
         .ok_or_else(|| anyhow!("workspace member '{}' must be a listed package", name))
 }