Skip to content

Commit 00127a7

Browse files
committed
Remove a fixme that should no longer be done
Add a couple explanatory comments in the implementation, one of which relates to (the absence of) this feature.
1 parent df175bc commit 00127a7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

gix-path/src/env/git.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,10 @@ where
6262
if let Some(value) = var_os_func(name) {
6363
let pf = Path::new(&value);
6464
if pf.is_relative() {
65+
// This should never happen, but if it does then we should not use the path.
6566
continue;
6667
};
68+
// Chain components to weakly normalize the path, mostly just for its separators.
6769
let components = pf.iter().chain(suffix.iter());
6870
let location = PathBuf::from_iter(components);
6971
if !locations.contains(&location) {
@@ -429,8 +431,6 @@ mod tests {
429431

430432
// Check that `ALTERNATIVE_LOCATIONS` correspond to them, with the correct subdirectories.
431433
GitBinSuffixes::assert_from(&pf, locations).assert_architectures();
432-
433-
// FIXME: Assert that the directory separators are `/` in the underlying `OsString`s.
434434
}
435435

436436
#[test]

0 commit comments

Comments
 (0)