Merge pull request #2196 from GitoxideLabs/copilot/fix-713956e8-cf8b-499a-99a8-92001948c9f8

Implement `std::fmt::Display` for `FullNameRef`, `PartialName`, and `PartialNameRef`

Author: Byron

gix-ref/src/fullname.rs

@@ -1,6 +1,5 @@
-use std::{borrow::Borrow, path::Path};
-
 use gix_object::bstr::{BStr, BString, ByteSlice};
+use std::{borrow::Borrow, path::Path};
 
 use crate::{bstr::ByteVec, name::is_pseudo_ref, Category, FullName, FullNameRef, Namespace, PartialNameRef};
 
@@ -73,6 +72,12 @@ impl std::fmt::Display for FullName {
     }
 }
 
+impl std::fmt::Display for FullNameRef {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        std::fmt::Display::fmt(&self.0, f)
+    }
+}
+
 impl FullNameRef {
     /// Interpret this fully qualified reference name as partial name.
     pub fn as_partial_name(&self) -> &PartialNameRef {

gix-ref/src/name.rs

@@ -266,6 +266,18 @@ impl convert::TryFrom<BString> for PartialName {
     }
 }
 
+impl std::fmt::Display for PartialName {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        std::fmt::Display::fmt(&self.0, f)
+    }
+}
+
+impl std::fmt::Display for PartialNameRef {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        std::fmt::Display::fmt(&self.0, f)
+    }
+}
+
 /// Note that this method is disagreeing with `gix_validate` as it allows dashes '-' for some reason.
 /// Since partial names cannot be created with dashes inside we adjusted this as it's probably unintended or git creates pseudo-refs
 /// which wouldn't pass its safety checks.

gix-ref/tests/refs/fullname.rs

@@ -1,6 +1,6 @@
 use std::borrow::Cow;
 
-use gix_ref::{Category, FullNameRef, PartialNameRef};
+use gix_ref::{Category, FullName, FullNameRef, PartialNameRef};
 
 #[test]
 fn cow() {
@@ -137,3 +137,12 @@ fn prefix_with_namespace_and_stripping() {
         "idempotent stripping"
     );
 }
+
+#[test]
+fn display() {
+    let full_name = FullName::try_from("refs/heads/main").unwrap();
+    assert_eq!(format!("{full_name}"), "refs/heads/main");
+
+    let full_name_ref = full_name.as_ref();
+    assert_eq!(format!("{full_name_ref}"), "refs/heads/main");
+}

gix-ref/tests/refs/main.rs

@@ -36,6 +36,15 @@ mod partialname {
         );
         Ok(())
     }
+
+    #[test]
+    fn display() {
+        let partial_name = PartialName::try_from("heads/main").unwrap();
+        assert_eq!(format!("{partial_name}"), "heads/main");
+
+        let partial_name_ref = partial_name.as_ref();
+        assert_eq!(format!("{partial_name_ref}"), "heads/main");
+    }
 }
 mod namespace;
 mod packed;