Skip to content

Commit 13e3677

Browse files
committed
Mark ReadDataLineFuture as #[allow(dead_code)]
The `ReadDataLineFuture` struct was among the facilities added within `gix-packetline` in 41fdb84 (#634), and it looks like it may have been intended to be used eventually. However, it is unused. While it is public in `read::sidebands::async_io` module, the only facility from that module that is exposed through `read::sidebands` is `WithSidebands`: https://github.com/GitoxideLabs/gitoxide/blob/04a18f3a4520dd6f49b5f87fe3782dd1cd1547f2/gix-packetline/src/read/sidebands/mod.rs#L6-L9 This situation appears to be long-standing. However, possibly because it is public in its own directly containing module, it was not detected as dead code by `cargo clippy` until recently. Specifically, this caused the CI `lint` job to fail starting in the recently released Rust 1.89. This can be observed by rerunning the workflow where it had passed before: https://github.com/EliahKagan/gitoxide/actions/runs/16739420509/job/47709197815 (The failure only happens in the `lean-async` run of `cargo clippy` because the containing module is not used at all in the `max`, `small`, and `max-pure` builds.) For now, this commit suppresses the error by adding `#[allow(dead_code)]` to `ReadDataLineFuture`.
1 parent 9946611 commit 13e3677

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

gix-packetline-blocking/src/read/sidebands/async_io.rs

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gix-packetline/src/read/sidebands/async_io.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ where
174174
}
175175
}
176176

177+
#[allow(dead_code)]
177178
pub struct ReadDataLineFuture<'a, 'b, T: AsyncRead, F> {
178179
parent: &'b mut WithSidebands<'a, T, F>,
179180
buf: &'b mut Vec<u8>,

0 commit comments

Comments
 (0)