Skip to content

Commit 29bc973

Browse files
committed
Temporarily break wasm feature of gix-diff to check CI
As noted in #2092, the `wasm` jobs on CI do not test `gix-diff` directly. However, my prediction there that breakage would not be detected on CI is likely mistaken, because those jobs do test the `wasm` feature of `gix-pack`. The `gix-pack` crate depends on `gix-diff`, and its `wasm` feature enable the `gix-diff` one. This temporary change checks that CI does fail when the `wasm` feature of `gix-diff` is broken in a simple way, even though it does not currently run WASM tests of `gix-diff` directly. This also temporarily makes the `wasm` matrix non-fail-fast, so that more failures can be observed.
1 parent 473fe52 commit 29bc973

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -401,6 +401,7 @@ jobs:
401401
strategy:
402402
matrix:
403403
target: [ wasm32-unknown-unknown, wasm32-wasip1 ]
404+
fail-fast: false
404405

405406
env:
406407
TARGET: ${{ matrix.target }}

gix-diff/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ gix-traverse = { version = "^0.47.0", path = "../gix-traverse", optional = true
4444
thiserror = "2.0.0"
4545
imara-diff = { version = "0.1.8", optional = true }
4646
serde = { version = "1.0.114", optional = true, default-features = false, features = ["derive"] }
47-
getrandom = { version = "0.2.8", optional = true, default-features = false, features = ["js"] }
47+
getrandom = { version = "0.2.8", optional = true, default-features = false }
4848
bstr = { version = "1.12.0", default-features = false }
4949

5050
document-features = { version = "0.2.0", optional = true }

0 commit comments

Comments
 (0)