Commit 352581d
committed
Compile the new tests on all platforms
Since the code under test is currently compiled on all platforms.
The current tests' assertions are not guaranteed to hold outside of
Windows systems. (It would be unusual to call the functions they
are testing outside of Windows. Those functions are themselves
mainly not marked to be conditionally compiled so that their
callers uses techniques like `if cfg!(windows)` that aren't
technically conditional compilation. Those technique are themselves
valuable because they can sometimes be simpler or more readable
than conditional compilation or easier to avoid false-positive
diagnostics, and because they allow type checking to occur even
when building on other platforms, while still usually being fast
because "runtime" conditions that are `false` constants still
facilitate removal of dead code as an optimization.) So the tests
of those functions are likewise built on all targets, but marked
conditonally ignored on non-Windows platforms.1 parent 38704ba commit 352581d
1 file changed
+5
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
142 | 143 | | |
143 | 144 | | |
144 | 145 | | |
| |||
147 | 148 | | |
148 | 149 | | |
149 | 150 | | |
| 151 | + | |
150 | 152 | | |
151 | 153 | | |
152 | 154 | | |
| |||
155 | 157 | | |
156 | 158 | | |
157 | 159 | | |
| 160 | + | |
158 | 161 | | |
159 | 162 | | |
160 | 163 | | |
| |||
163 | 166 | | |
164 | 167 | | |
165 | 168 | | |
| 169 | + | |
166 | 170 | | |
167 | 171 | | |
168 | 172 | | |
| |||
0 commit comments