Skip to content

Commit 4de994b

Browse files
committed
Remove potentially misleading "(limited)" for Android
This removes "(limited)" from the description of the `justfile` recipe `cross-test-android`. It *is* very limited, but that label is misleading, since currently `cross-test-s390x` (as well as other `cross` testing targets that could be run through the parameterized `cross-test` recipe) are limited in all the same ways. In particular, we are not currently testing them with any external components built for the target architecture. For example, `git` built for the host has been upgraded in the container and the environment has been configured so `gix-path`, `gix-testtools`, any test cases throughout the workspace can use it without problems (either directly or through a shell). In the future, some `cross` targets may gain a richer target environment to interact with when testing, by installing target builds of `git`, by installing target builds of libraries that facilitate more features than `max-pure`, or in other ways. At that point, convenience recipes for specific targets in the `justfile` that are more limited than other targets could be marked "(limited)".
1 parent c8e54bf commit 4de994b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

justfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ cross-test target: (cross-image target)
242242
# Test s390x with `cross`
243243
cross-test-s390x: (cross-test 's390x-unknown-linux-gnu')
244244

245-
# Test Android with `cross` (limited)
245+
# Test Android with `cross`
246246
cross-test-android: (cross-test 'armv7-linux-androideabi')
247247

248248
# Run `cargo diet` on all crates to see that they are still in bounds

0 commit comments

Comments
 (0)